You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2019/11/27 15:11:00 UTC
[jira] [Commented] (FLINK-14945) Simplify some code in runtime
[ https://issues.apache.org/jira/browse/FLINK-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983610#comment-16983610 ]
Chesnay Schepler commented on FLINK-14945:
------------------------------------------
We usually don't accept code "simplifications" unless they have practical benefits like performance improvements on critical code paths.
The overhead for reviewing these rarely outweighs the benefits.
> Simplify some code in runtime
> -----------------------------
>
> Key: FLINK-14945
> URL: https://issues.apache.org/jira/browse/FLINK-14945
> Project: Flink
> Issue Type: Task
> Components: Runtime / Checkpointing, Runtime / Metrics, Runtime / Task
> Reporter: clay
> Assignee: clay
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I found some code to simplify when using IDEA to inspect the code, so I submit a PR here, This change only involves code simplification
--
This message was sent by Atlassian Jira
(v8.3.4#803005)