You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/13 14:18:00 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #10821: [improvement]Use phmap for aggregation with serialized key
mrhhsg opened a new pull request, #10821:
URL: https://github.com/apache/doris/pull/10821
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Test on ssb-flat(100g) with SQL:
```sql
SELECT
C_CITY,
S_CITY,
(LO_ORDERDATE DIV 10000) AS YEAR,
SUM(LO_REVENUE) AS revenue
FROM
lineorder_flat
GROUP BY
C_CITY, S_CITY, YEAR
ORDER BY
YEAR ASC, revenue DESC limit 20;
```
master: 34 sec
agg_with_phmap: 28 sec
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10821:
URL: https://github.com/apache/doris/pull/10821#issuecomment-1183932085
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10821:
URL: https://github.com/apache/doris/pull/10821#discussion_r920710172
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1048,16 +1094,38 @@ Status AggregationNode::_merge_with_serialized_key(Block* block) {
std::visit(
[&](auto&& agg_method) -> void {
using HashMethodType = std::decay_t<decltype(agg_method)>;
+ using HashTableType = std::decay_t<decltype(agg_method.data)>;
using AggState = typename HashMethodType::State;
AggState state(key_columns, _probe_key_sz, nullptr);
_pre_serialize_key_if_need(state, agg_method, key_columns, rows);
+ std::vector<size_t> hash_values;
Review Comment:
any difference between vector and dynamic array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
wangbo commented on code in PR #10821:
URL: https://github.com/apache/doris/pull/10821#discussion_r920697002
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1048,16 +1094,38 @@ Status AggregationNode::_merge_with_serialized_key(Block* block) {
std::visit(
[&](auto&& agg_method) -> void {
using HashMethodType = std::decay_t<decltype(agg_method)>;
+ using HashTableType = std::decay_t<decltype(agg_method.data)>;
using AggState = typename HashMethodType::State;
AggState state(key_columns, _probe_key_sz, nullptr);
_pre_serialize_key_if_need(state, agg_method, key_columns, rows);
+ std::vector<size_t> hash_values;
+
+ if constexpr (IsPhmapTraits<HashTableType>::value) {
+ if (hash_values.size() < rows) hash_values.resize(rows);
+ for (size_t i = 0; i < rows; ++i) {
+ hash_values[i] = agg_method.data.hash(agg_method.keys[i]);
+ }
+ }
+
/// For all rows.
for (size_t i = 0; i < rows; ++i) {
AggregateDataPtr aggregate_data = nullptr;
- auto emplace_result = state.emplace_key(agg_method.data, i, _agg_arena_pool);
+ auto emplace_result = [&]() {
+ if constexpr (IsPhmapTraits<HashTableType>::value) {
+ if (LIKELY(i + HASH_MAP_PREFETCH_DIST < rows)) {
+ agg_method.data.prefetch_by_hash(
Review Comment:
1 Does this prefetch have a big impact on performance?
2 Is prefetch works at any case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
wangbo commented on code in PR #10821:
URL: https://github.com/apache/doris/pull/10821#discussion_r920698540
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1048,16 +1094,38 @@ Status AggregationNode::_merge_with_serialized_key(Block* block) {
std::visit(
[&](auto&& agg_method) -> void {
using HashMethodType = std::decay_t<decltype(agg_method)>;
+ using HashTableType = std::decay_t<decltype(agg_method.data)>;
using AggState = typename HashMethodType::State;
AggState state(key_columns, _probe_key_sz, nullptr);
_pre_serialize_key_if_need(state, agg_method, key_columns, rows);
+ std::vector<size_t> hash_values;
Review Comment:
Why not using size_t[rows] here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10821:
URL: https://github.com/apache/doris/pull/10821#discussion_r920709980
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1048,16 +1094,38 @@ Status AggregationNode::_merge_with_serialized_key(Block* block) {
std::visit(
[&](auto&& agg_method) -> void {
using HashMethodType = std::decay_t<decltype(agg_method)>;
+ using HashTableType = std::decay_t<decltype(agg_method.data)>;
using AggState = typename HashMethodType::State;
AggState state(key_columns, _probe_key_sz, nullptr);
_pre_serialize_key_if_need(state, agg_method, key_columns, rows);
+ std::vector<size_t> hash_values;
+
+ if constexpr (IsPhmapTraits<HashTableType>::value) {
+ if (hash_values.size() < rows) hash_values.resize(rows);
+ for (size_t i = 0; i < rows; ++i) {
+ hash_values[i] = agg_method.data.hash(agg_method.keys[i]);
+ }
+ }
+
/// For all rows.
for (size_t i = 0; i < rows; ++i) {
AggregateDataPtr aggregate_data = nullptr;
- auto emplace_result = state.emplace_key(agg_method.data, i, _agg_arena_pool);
+ auto emplace_result = [&]() {
+ if constexpr (IsPhmapTraits<HashTableType>::value) {
+ if (LIKELY(i + HASH_MAP_PREFETCH_DIST < rows)) {
+ agg_method.data.prefetch_by_hash(
Review Comment:
Yes, ssb 3.x query performance is bad without prefetch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10821:
URL: https://github.com/apache/doris/pull/10821#issuecomment-1183932533
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10821:
URL: https://github.com/apache/doris/pull/10821#issuecomment-1183932101
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10821:
URL: https://github.com/apache/doris/pull/10821#issuecomment-1183932509
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10821: [improvement]Use phmap for aggregation with serialized key
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10821:
URL: https://github.com/apache/doris/pull/10821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org