You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/13 22:09:53 UTC
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21831: Update references to Jira to GH for the Python SDK
TheNeuralBit commented on code in PR #21831:
URL: https://github.com/apache/beam/pull/21831#discussion_r896199855
##########
sdks/python/apache_beam/dataframe/frames.py:
##########
@@ -575,12 +575,12 @@ def reset_index(self, level=None, **kwargs):
if level is not None and not isinstance(level, (tuple, list)):
level = [level]
if level is None or len(level) == self._expr.proxy().index.nlevels:
- # TODO(BEAM-12182): Could do distributed re-index with offsets.
+ # TODO(Issue 20859): Could do distributed re-index with offsets.
requires_partition_by = partitionings.Singleton(
reason=(
f"reset_index(level={level!r}) drops the entire index and "
"creates a new one, so it cannot currently be parallelized "
- "(BEAM-12182)."))
+ "(Issue 20859)."))
Review Comment:
I think a URL would be preferable in the error message for easy discovery. Previously BEAM-12182 could likely be found with a Google search, but "20859" will require the user to construct the URL.
##########
sdks/python/apache_beam/dataframe/frames.py:
##########
@@ -575,12 +575,12 @@ def reset_index(self, level=None, **kwargs):
if level is not None and not isinstance(level, (tuple, list)):
level = [level]
if level is None or len(level) == self._expr.proxy().index.nlevels:
- # TODO(BEAM-12182): Could do distributed re-index with offsets.
+ # TODO(Issue 20859): Could do distributed re-index with offsets.
requires_partition_by = partitionings.Singleton(
reason=(
f"reset_index(level={level!r}) drops the entire index and "
"creates a new one, so it cannot currently be parallelized "
- "(BEAM-12182)."))
+ "(Issue 20859)."))
Review Comment:
I think a URL would be preferable in error messages for easy discovery. Previously BEAM-12182 could likely be found with a Google search, but "20859" will require the user to construct the URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org