You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/07 23:56:52 UTC
Review Request 68265: Built gRPC support in mesos-tidy.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68265/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Michael Park.
Repository: mesos
Description
-------
Built gRPC support in mesos-tidy.
Diffs
-----
support/mesos-tidy/Dockerfile 66adbd006490d4f6b2f10d77b612fe82f8ef6141
support/mesos-tidy/entrypoint.sh bb6344c01a01e35d32741f1886ef2029194e126b
Diff: https://reviews.apache.org/r/68265/diff/1/
Testing
-------
`support/mesos-tidy.sh`
Thanks,
Chun-Hung Hsiao
Re: Review Request 68265: Built gRPC support in mesos-tidy.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68265/#review206979
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68265]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 7, 2018, 11:56 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68265/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 11:56 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Built gRPC support in mesos-tidy.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile 66adbd006490d4f6b2f10d77b612fe82f8ef6141
> support/mesos-tidy/entrypoint.sh bb6344c01a01e35d32741f1886ef2029194e126b
>
>
> Diff: https://reviews.apache.org/r/68265/diff/1/
>
>
> Testing
> -------
>
> `support/mesos-tidy.sh`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68265: Built gRPC support in mesos-tidy.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68265/#review207000
-----------------------------------------------------------
Ship it!
```
make[1]: Leaving directory '/BUILD'
No mesos-tidy violations found.
```
- Andrew Schwartzmeyer
On Aug. 7, 2018, 4:56 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68265/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 4:56 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Built gRPC support in mesos-tidy.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile 66adbd006490d4f6b2f10d77b612fe82f8ef6141
> support/mesos-tidy/entrypoint.sh bb6344c01a01e35d32741f1886ef2029194e126b
>
>
> Diff: https://reviews.apache.org/r/68265/diff/1/
>
>
> Testing
> -------
>
> `support/mesos-tidy.sh`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68265: Built gRPC support in mesos-tidy.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68265/#review206964
-----------------------------------------------------------
PASS: Mesos patch 68265 was successfully built and tested.
Reviews applied: `['68265']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2117/mesos-review-68265
- Mesos Reviewbot Windows
On Aug. 7, 2018, 11:56 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68265/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 11:56 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Built gRPC support in mesos-tidy.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile 66adbd006490d4f6b2f10d77b612fe82f8ef6141
> support/mesos-tidy/entrypoint.sh bb6344c01a01e35d32741f1886ef2029194e126b
>
>
> Diff: https://reviews.apache.org/r/68265/diff/1/
>
>
> Testing
> -------
>
> `support/mesos-tidy.sh`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>