You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ca...@apache.org on 2023/06/13 11:16:43 UTC
[iotdb] 01/01: remove the usage of Validate.isTrue method to avoid unnecessary construction of string
This is an automated email from the ASF dual-hosted git repository.
caogaofei pushed a commit to branch beyyes/imporve_statistic_judgement
in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit 8ecf6f8953689ed49f0cec70991db5a316424917
Author: Beyyes <cg...@foxmail.com>
AuthorDate: Tue Jun 13 19:16:26 2023 +0800
remove the usage of Validate.isTrue method to avoid unnecessary construction of string
---
.../iotdb/db/mpp/plan/planner/LogicalPlanVisitor.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LogicalPlanVisitor.java b/server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LogicalPlanVisitor.java
index ecda02923eb..8f63b6905b7 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LogicalPlanVisitor.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/LogicalPlanVisitor.java
@@ -83,8 +83,6 @@ import org.apache.iotdb.db.mpp.plan.statement.metadata.view.ShowLogicalViewState
import org.apache.iotdb.db.mpp.plan.statement.sys.ShowQueriesStatement;
import org.apache.iotdb.tsfile.utils.Pair;
-import org.apache.commons.lang3.Validate;
-
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
@@ -346,12 +344,14 @@ public class LogicalPlanVisitor extends StatementVisitor<PlanNode, MPPQueryConte
private boolean cannotUseStatistics(Set<Expression> expressions) {
for (Expression expression : expressions) {
- Validate.isTrue(
- expression instanceof FunctionExpression,
- String.format("Invalid Aggregation Expression: %s", expression.getExpressionString()));
- if (!BuiltinAggregationFunction.canUseStatistics(
- ((FunctionExpression) expression).getFunctionName())) {
- return true;
+ if (expression instanceof FunctionExpression) {
+ if (!BuiltinAggregationFunction.canUseStatistics(
+ ((FunctionExpression) expression).getFunctionName())) {
+ return true;
+ }
+ } else {
+ throw new IllegalArgumentException(
+ String.format("Invalid Aggregation Expression: %s", expression.getExpressionString()));
}
}
return false;