You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/04 23:39:38 UTC
[GitHub] [incubator-druid] jon-wei commented on a change in pull request
#7413: Allow max rows and max segments for time-ordered scans to be
overridden using the scan query JSON spec
jon-wei commented on a change in pull request #7413: Allow max rows and max segments for time-ordered scans to be overridden using the scan query JSON spec
URL: https://github.com/apache/incubator-druid/pull/7413#discussion_r272404675
##########
File path: docs/content/querying/scan-query.md
##########
@@ -198,8 +200,27 @@ is complete.
## Configuration Properties
+Configuration properties:
+
|property|description|values|default|
|--------|-----------|------|-------|
|druid.query.scan.maxRowsQueuedForOrdering|The maximum number of rows returned when time ordering is used|An integer in [0, 2147483647]|100000|
|druid.query.scan.maxSegmentPartitionsOrderedInMemory|The maximum number of segments scanned per historical when time ordering is used|An integer in [0, 2147483647]|50|
-|druid.query.scan.legacy|Whether legacy mode should be turned on for Scan queries|true or false|false|
\ No newline at end of file
+|druid.query.scan.legacy|Whether legacy mode should be turned on for Scan queries|true or false|false|
+
+
+## Query Context Properties
+
+|property|description|values|default|
+|--------|-----------|------|-------|
+|maxRowsQueuedForOrdering|The maximum number of rows returned when time ordering is used. Overrides the identically named config.|An integer in [0, 2147483647]|100000|
Review comment:
The default here would be the configured value of `druid.query.scan.maxSegmentPartitionsOrderedInMemory` instead of 100000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org