You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/28 02:31:04 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #6219: docs: optimizing api-breaker documentation

spacewander commented on a change in pull request #6219:
URL: https://github.com/apache/apisix/pull/6219#discussion_r794159919



##########
File path: docs/en/latest/plugins/api-breaker.md
##########
@@ -90,7 +95,7 @@ curl "http://127.0.0.1:9080/apisix/admin/routes/1" -H 'X-API-KEY: edd1c9f034335f
 Then. Like the configuration above, if your upstream service returns 500. 3 times in a row. The client will receive a 502 (break_response_code) response.
 
 ```shell
-$ curl -i -X POST "http://127.0.0.1:9080/get"
+$ curl -i -X POST "http://127.0.0.1:9080/hello"

Review comment:
       Yes. Maybe we can change the status code.
   
   Most of the documentation is using the 1980 port as a fake upstream. So we can assume people can get used to it.
   
   We can't use 9080 port as it may cause a loop.
   `httpbin.org` is another option, but it can't be accessed in the China mainland, and it only supports `http`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org