You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/17 21:05:15 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #18077: [fix][test] Fix flaky test: PrometheusMetricsTest.testDuplicateMetricTypeDefinitions
nicoloboschi opened a new pull request, #18077:
URL: https://github.com/apache/pulsar/pull/18077
### Motivation
Fix #17921
The test may fails if a previous test in the same fork started the transactions and therefore the transactions metrics are published. In the PulsarService shutdown hooks the metrics are never unregistered.
### Modifications
* Unregister transactions metrics in the PulsarService shutdown
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #18077: [fix][test] Fix flaky test: PrometheusMetricsTest.testDuplicateMetricTypeDefinitions
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #18077:
URL: https://github.com/apache/pulsar/pull/18077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18077: [fix][test] Fix flaky test: PrometheusMetricsTest.testDuplicateMetricTypeDefinitions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18077:
URL: https://github.com/apache/pulsar/pull/18077#issuecomment-1281702925
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18077?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@92b4708`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/18077?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18077 +/- ##
=========================================
Coverage ? 70.74%
Complexity ? 437
=========================================
Files ? 26
Lines ? 2246
Branches ? 245
=========================================
Hits ? 1589
Misses ? 484
Partials ? 173
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.74% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #18077: [fix][test] Fix flaky test: PrometheusMetricsTest.testDuplicateMetricTypeDefinitions
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #18077: [fix][test] Fix flaky test: PrometheusMetricsTest.testDuplicateMetricTypeDefinitions
URL: https://github.com/apache/pulsar/pull/18077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org