You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/28 05:42:47 UTC
[GitHub] dongjoon-hyun commented on a change in pull request #23914:
[SPARK-27009][TEST] Add Standard Deviation to benchmark results
dongjoon-hyun commented on a change in pull request #23914: [SPARK-27009][TEST] Add Standard Deviation to benchmark results
URL: https://github.com/apache/spark/pull/23914#discussion_r261052778
##########
File path: core/src/test/scala/org/apache/spark/benchmark/Benchmark.scala
##########
@@ -111,16 +111,17 @@ private[spark] class Benchmark(
// The results are going to be processor specific so it is useful to include that.
out.println(Benchmark.getJVMOSInfo())
out.println(Benchmark.getProcessorName())
- out.printf("%-40s %16s %12s %13s %10s\n", name + ":", "Best/Avg Time(ms)", "Rate(M/s)",
- "Per Row(ns)", "Relative")
- out.println("-" * 96)
+ out.printf("%-40s %16s %12s %13s %10s %13s\n", name + ":", "Best/Avg Time(ms)", "Rate(M/s)",
+ "Per Row(ns)", "Relative", "Stdev (ms)")
Review comment:
Currently, this adds the new value at the end. Can we move this to `Best/Avg Time(ms)` group? For example, `Best/Avg/Stdev Time(ms)`?
```
Limiting: Best/Avg Time(ms) Rate(M/s) Per Row(ns) Relative Stdev (ms)
--------------------------------------------------------------------------------------------------
Top-level column 231 / 240 4.3 230.7 1.0X 11
Nested column 1833 / 1957 0.5 1833.1 0.1X 68
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org