[jira] [Commented] (HIVE-21313) Use faster function to point to instead of copy immutable byte arrays

["Zoltan Haindrich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776275#comment-16776275 ] 

Zoltan Haindrich commented on HIVE-21313:
-----------------------------------------

[~ZhangxinJson]: please press "submit patch" button to have hive qa test your patch

> Use faster function to point to instead of copy immutable byte arrays
> ---------------------------------------------------------------------
>
>                 Key: HIVE-21313
>                 URL: https://issues.apache.org/jira/browse/HIVE-21313
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: ZhangXin
>            Assignee: ZhangXin
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HIVE-21313.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In file ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAssignRow.java
> We may find code like this:
> ```
> Text text = (Text) convertTargetWritable;
>  if (text == null)
> {     text = new Text(); }
> text.set(string);
>  ((BytesColumnVector) columnVector).setVal(
>      batchIndex, text.getBytes(), 0, text.getLength());
> ```
>  
> Using `setVal` method can copy the bytes array generated by `text.getBytes()`. This is totally unnecessary at all. Since the bytes array is immutable, we can just use `setRef` method to point to the specific  byte array, which will also lower the memory usage.
>  
> Pull request on Github:  https://github.com/apache/hive/pull/548
>  
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)