You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/08 07:06:19 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #31775: [SPARK-34660][TESTS] Don't use ParVector with `withExistingConf` which is not thread-safe
dongjoon-hyun opened a new pull request #31775:
URL: https://github.com/apache/spark/pull/31775
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792560959
late lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kiszk commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792531482
Great analysis!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31775: [SPARK-34660][TESTS] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792529201
cc @leanken , @cloud-fan , @rednaxelafx , @maropu , @kiszk , @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792687219
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135857/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792861047
Thank you, @maropu , @cloud-fan , @viirya .
BTW, @maropu . Could you make a follow-up if needed, please?
> nit: It looks like we don't need to wrap SQLConf.withExistingConf now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792533499
Thank you, @kiszk !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792548773
late LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792687219
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135857/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792861047
Thank you, @maropu , @cloud-fan , @viirya .
BTW, @maropu . Could you make a follow-up, please?
> nit: It looks like we don't need to wrap SQLConf.withExistingConf now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792527967
**[Test build #135857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135857/testReport)** for PR 31775 at commit [`6bfb870`](https://github.com/apache/spark/commit/6bfb870b9c1bb446c20ac5ae306efdf10a1ddb7a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31775:
URL: https://github.com/apache/spark/pull/31775#discussion_r589225142
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -962,7 +962,7 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
test("ANSI mode: cast string to timestamp with parse error") {
val activeConf = conf
- new ParVector(ALL_TIMEZONES.toVector).foreach { zid =>
+ ALL_TIMEZONES.foreach { zid =>
Review comment:
nit: It looks like we don't need to wrap `SQLConf.withExistingConf` now.
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -962,7 +962,7 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
test("ANSI mode: cast string to timestamp with parse error") {
val activeConf = conf
- new ParVector(ALL_TIMEZONES.toVector).foreach { zid =>
+ ALL_TIMEZONES.foreach { zid =>
def checkCastWithParseError(str: String): Unit = {
Review comment:
nit: It looks like we don't need to wrap `SQLConf.withExistingConf` now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792561640
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40439/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-793216531
Yea, I'll do it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31775: [SPARK-34660][TESTS] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792527967
**[Test build #135857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135857/testReport)** for PR 31775 at commit [`6bfb870`](https://github.com/apache/spark/commit/6bfb870b9c1bb446c20ac5ae306efdf10a1ddb7a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792561640
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40439/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792544591
This is a test-only PR and I tested this manually. Merged to branch-3.1 to recover the branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31775:
URL: https://github.com/apache/spark/pull/31775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792546605
late lgtm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31775:
URL: https://github.com/apache/spark/pull/31775#issuecomment-792685835
**[Test build #135857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135857/testReport)** for PR 31775 at commit [`6bfb870`](https://github.com/apache/spark/commit/6bfb870b9c1bb446c20ac5ae306efdf10a1ddb7a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org