You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/03 15:41:57 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1388: HDDS-4204. upgrade docker environment does not work with KEEP_RUNNING=true
adoroszlai opened a new pull request #1388:
URL: https://github.com/apache/hadoop-ozone/pull/1388
## What changes were proposed in this pull request?
Ozone `upgrade` Docker Compose environment fails if run with `KEEP_RUNNING=true`. The variable is applied to both runs (pre- and post-upgrade), but pre-upgrade containers should be stopped regardless, since they will be replaced by the new ones.
Also remove leftover `debug` directory creation.
https://issues.apache.org/jira/browse/HDDS-4204
## How was this patch tested?
Tested locally:
```
$ cd hadoop-ozone/dist/target/ozone-1.1.0-SNAPSHOT/compose/upgrade
$ KEEP_RUNNING=true ./test.sh
...
Stopping upgrade_om_1 ...
...
Readdata :: Smoketest ozone cluster startup | PASS |
...
```
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/runs/1067273739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1388: HDDS-4204. upgrade docker environment does not work with KEEP_RUNNING=true
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1388:
URL: https://github.com/apache/hadoop-ozone/pull/1388#discussion_r483225127
##########
File path: hadoop-ozone/dist/src/main/compose/upgrade/test.sh
##########
@@ -26,7 +26,6 @@ export COMPOSE_DIR
export OZONE_VOLUME
mkdir -p "${OZONE_VOLUME}"/{dn1,dn2,dn3,om,recon,s3g,scm}
-mkdir -p "${OZONE_VOLUME}/debug"
Review comment:
Yes. I had added it for a `debug` container while trying to find out the cause of permission problems in GitHub Actions (it was working fine locally). I [removed the container](https://github.com/apache/hadoop-ozone/pull/1142/commits/9dbbcbb7e1719a5bba94533e49674556d4b1e362) in the final version, but forgot about the directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1388: HDDS-4204. upgrade docker environment does not work with KEEP_RUNNING=true
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1388:
URL: https://github.com/apache/hadoop-ozone/pull/1388#issuecomment-689206320
Thanks @amaliujia for the review, and @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1388: HDDS-4204. upgrade docker environment does not work with KEEP_RUNNING=true
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1388:
URL: https://github.com/apache/hadoop-ozone/pull/1388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on a change in pull request #1388: HDDS-4204. upgrade docker environment does not work with KEEP_RUNNING=true
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1388:
URL: https://github.com/apache/hadoop-ozone/pull/1388#discussion_r483144989
##########
File path: hadoop-ozone/dist/src/main/compose/upgrade/test.sh
##########
@@ -26,7 +26,6 @@ export COMPOSE_DIR
export OZONE_VOLUME
mkdir -p "${OZONE_VOLUME}"/{dn1,dn2,dn3,om,recon,s3g,scm}
-mkdir -p "${OZONE_VOLUME}/debug"
Review comment:
`/debug` is leftover means it is unused now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org