You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DrIgor <gi...@git.apache.org> on 2017/06/02 09:33:37 UTC

[GitHub] zeppelin pull request #2389: [MINOR] Remove duplicates from ZeppelinConfigur...

GitHub user DrIgor opened a pull request:

    https://github.com/apache/zeppelin/pull/2389

    [MINOR] Remove duplicates from ZeppelinConfiguration

    ### What is this PR for?
    Remove duplicated code from `ZeppelinConfiguration` and make proper use of commons-configuraion
    
    And I propose using interpolation instead of `getRelativeDir` (Not in this PR).
    For example,
    ```
    ZEPPELIN_INTERPRETER_DIR("zeppelin.interpreter.dir", "${zeppelin.home}/interpreter")
    ```
    
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin configuration-refactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2389
    
----
commit 32b5e091ceff544aa61aa9522a1d81a8f37ba8c5
Author: Igor Drozdov <ig...@epam.com>
Date:   2017-06-01T07:09:31Z

    Remove duplicates from `ZeppelinConfiguration`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2389: [MINOR] Remove duplicates from ZeppelinConfiguration

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2389
  
    @DrIgor This is not a trivial change, please create a ticket and describe the purpose. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2389: [ZEPPELIN-2612] Remove duplicates from Zeppelin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2389


---