You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/20 19:23:32 UTC

[GitHub] [trafficcontrol] rawlinp commented on pull request #4704: Fix OptionsDeleter audit log keys

rawlinp commented on pull request #4704:
URL: https://github.com/apache/trafficcontrol/pull/4704#issuecomment-631675758


   Oh, maybe it wasn't clear, it would be either the ID or the name, depending on what the PK of the resource is. So regions uses IDs for deletion whereas Topologies uses the name, but I do agree that when deleting things we should probably always include the name (if it has one). I imagine that is a problem we have with a lot of our APIs currently. But for this PR, it fixes the regions audit log entry to include at least the ID and the topologies log entry to include the name. I think we should address the ID vs name thing separately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org