[jira] [Commented] (ZOOKEEPER-575) remove System.exit calls to make the server more container friendly

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533670#comment-13533670 ] 

Hadoop QA commented on ZOOKEEPER-575:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12561245/ZOOKEEPER-575_4.patch
  against trunk revision 1422473.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1304//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1304//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1304//console

This message is automatically generated.
                
> remove System.exit calls to make the server more container friendly
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-575
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-575
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Andrew Finnell
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-575-2.patch, ZOOKEEPER-575-3.patch, ZOOKEEPER-575_4.patch, ZOOKEEPER-575.patch
>
>
> There are a handful of places left in the code that still use System.exit, we should remove these to make the server
> more container friendly.
> There are some legitimate places for the exits - in *Main.java for example should be fine - these are the command
> line main routines. Containers should be embedding code that runs just below this layer (or we should refactor
> so that it would).
> The tricky bit is ensuring the server shuts down in case of an unrecoverable error occurring, afaik these are the
> locations where we still have sys exit calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira