You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "KatalKavya96 (via GitHub)" <gi...@apache.org> on 2026/10/11 19:57:15 UTC
[PR] docs(sandbox-lint): declare Grok harness support [magpie]
KatalKavya96 opened a new pull request, #1598:
URL: https://github.com/apache/magpie/pull/1598
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
## Summary
- Declare Grok as supported by `tools/sandbox-lint` through the existing harness-neutral `--any-harness` posture check.
- Update sandbox-lint documentation and CLI/help wording so Grok is explicitly identified alongside other runtimes without a dedicated sandbox config profile.
- Regenerate vendor-neutrality metadata so the declared harness support matches the existing implementation.
## Type of change
<!-- Tick all that apply. -->
- [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
- [x] Tool / bridge contract (`tools/<system>/*.md`)
- [ ] Python package (`tools/*/` with `pyproject.toml`)
- [ ] Groovy reference impl
- [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
- [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
- [ ] Project template (`projects/_template/`)
- [ ] CI / dev loop (`prek`, workflows, validators)
- [x] Other: harness metadata / sandbox-lint posture documentation alignment
## Test plan
<!--
How you verified the change. Be specific. The reviewer reads this to
decide what to spot-check vs trust. Empty "ran the tests" doesn't help.
-->
- [x] `prek run --all-files` passes
- [ ] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
- [ ] For Groovy bridges touched: command-line invocation tested end-to-end
- [ ] For skill changes: eval suite passes for the affected skill
(`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/`)
- [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
- [x] Other:
- `uv run --project tools/sandbox-lint --group dev pytest tools/sandbox-lint/tests/test_posture.py`
- existing `--any-harness` coverage verifies complete, incomplete, missing, and auto-detected framework posture cases
- vendor-neutrality metadata regenerated successfully
## RFC-AI-0004 compliance
<!--
Tick the principles the change touches. Skip rows that don't apply.
RFC-AI-0004 is the framework's constitution — see
docs/rfcs/RFC-AI-0004.md.
-->
- [ ] **HITL** — any new mutation is gated on explicit user confirmation
- [x] **Sandbox** — no new sandbox behavior or unrestricted host access is introduced; Grok uses the existing harness-neutral `--any-harness` posture check
- [x] **Vendor neutrality** — Grok is represented through the existing generic harness-neutral path rather than a vendor-specific sandbox implementation
- [ ] **Conversational + correctable** — agentic-override path documented if behaviour is adopter-tunable
- [ ] **Write-access discipline** — no autonomous outbound messages; drafts only, sent on confirmation
- [ ] **Privacy LLM** — private content does not reach a non-approved LLM; redactor invoked where needed
## Linked issues
Refs #1416
## Notes for reviewers (optional)
This PR does not add a Grok-specific sandbox parser or new security logic.
`sandbox-lint` already supports runtimes without a dedicated config profile through `--any-harness`, which verifies the presence of the shared harness-neutral enforcement components:
- `tools/agent-isolation/agent-iso.sh`
- `tools/agent-guard/` dispatch core
Grok already relies on that same external OS-level posture, so this change makes the existing support explicit in the harness declaration, documentation, CLI/help wording, and generated vendor-neutrality metadata.
No Grok-specific regression test was added because the generic `--any-harness` behavior is already covered directly by the existing posture test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(sandbox-lint): declare Grok harness support [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1598:
URL: https://github.com/apache/magpie/pull/1598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(sandbox-lint): declare Grok harness support [magpie]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on code in PR #1598:
URL: https://github.com/apache/magpie/pull/1598#discussion_r4288151039
##########
tools/sandbox-lint/README.md:
##########
@@ -23,7 +23,7 @@
**Capability:** substrate:sandbox
-**Harness:** Claude Code, Codex, Cursor, Gemini CLI, OpenCode, Kiro
+**Harness:** Claude Code, Codex, Cursor, Gemini CLI, OpenCode, Kiro, Grok
Review Comment:
@Kaap10 Thanks for the suggestion. I checked the repository conventions: the existing multi-harness **Harness:** declarations are not consistently alphabetical, and spec-loop already uses this same ordering. The vendor-neutrality generator sorts the parsed harness set independently before rendering, so the generated table’s order does not impose an ordering requirement on the source declaration. I’d prefer to keep this as-is rather than introduce an ordering convention only in sandbox-lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(sandbox-lint): declare Grok harness support [magpie]
Posted by "Kaap10 (via GitHub)" <gi...@apache.org>.
Kaap10 commented on code in PR #1598:
URL: https://github.com/apache/magpie/pull/1598#discussion_r4244438914
##########
tools/sandbox-lint/README.md:
##########
@@ -23,7 +23,7 @@
**Capability:** substrate:sandbox
-**Harness:** Claude Code, Codex, Cursor, Gemini CLI, OpenCode, Kiro
+**Harness:** Claude Code, Codex, Cursor, Gemini CLI, OpenCode, Kiro, Grok
Review Comment:
```suggestion
**Harness:** Claude Code, Codex, Cursor, Gemini CLI, Grok, Kiro, OpenCode
```
(Nit, non-blocking): Kept in alphabetical order to match the generated table in `docs/vendor-neutrality.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(sandbox-lint): declare Grok harness support [magpie]
Posted by "KatalKavya96 (via GitHub)" <gi...@apache.org>.
KatalKavya96 commented on PR #1598:
URL: https://github.com/apache/magpie/pull/1598#issuecomment-6113126018
@potiuk This should be the final cleanup slice for #1416.
Grok support is now covered across the issue’s planned integration points:
- #1488 — universal skill loading / setup support
- #1516 — Grok PreToolUse action-guard integration
- #1593 — Grok headless spec-loop profile
- #1446 — Grok adversarial-review backend + privacy-LLM opt-in documentation
- this PR — final sandbox-lint harness declaration and --any-harness posture documentation alignment
This PR does not add new sandbox logic; it just makes Grok’s use of the existing harness-neutral posture path explicit and keeps vendor-neutrality metadata in sync.
Full prek run --all-files passes locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org