You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2011/06/25 11:24:47 UTC

[jira] [Created] (HBASE-4035) Fix local-master-backup.sh - parameter order wrong

Fix local-master-backup.sh - parameter order wrong
--------------------------------------------------

                 Key: HBASE-4035
                 URL: https://issues.apache.org/jira/browse/HBASE-4035
             Project: HBase
          Issue Type: Bug
          Components: scripts
    Affects Versions: 0.92.0
            Reporter: Lars George
            Priority: Minor
             Fix For: 0.92.0


I think this is a regression from HBASE-3895 (if so, my bad!). The local-master-backup.sh needs the parameters adjusted to work.

{noformat}
$ bin/local-master-backup.sh start 1          
starting master, logging to /var/lib/hbase/logs/hbase-larsgeorge-1-master-de1-app-mbp-2.out
Usage: Master [opts] start|stop
 start  Start Master. If local mode, start Master and RegionServer in same JVM
 stop   Start cluster shutdown; Master signals RegionServer shutdown
 where [opts] are:
   --minServers=<servers>    Minimum RegionServers needed to host user tables.
   --backup                  Master should start in backup mode
{noformat}

The log has

{noformat}
2011-06-25 10:26:34,864 ERROR org.apache.hadoop.hbase.master.HMasterCommandLine: Could not parse: 
org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -D
        at org.apache.commons.cli.Parser.processOption(Parser.java:363)
        at org.apache.commons.cli.Parser.parse(Parser.java:199)
        at org.apache.commons.cli.Parser.parse(Parser.java:85)
        at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:73)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
        at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:76)
        at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:1346)
{noformat}

Fix:

{noformat}
Index: bin/local-master-backup.sh
===================================================================
--- bin/local-master-backup.sh  (revision 1139502)
+++ bin/local-master-backup.sh  (working copy)
@@ -21,9 +21,9 @@
   DN=$2
   export HBASE_IDENT_STRING="$USER-$DN"
   HBASE_MASTER_ARGS="\
-    --backup \
     -D hbase.master.port=`expr 60000 + $DN` \
-    -D hbase.master.info.port=`expr 60010 + $DN`"
+    -D hbase.master.info.port=`expr 60010 + $DN` \
+    --backup"
   "$bin"/hbase-daemon.sh $1 master $HBASE_MASTER_ARGS
 }
{noformat}


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4035) Fix local-master-backup.sh - parameter order wrong

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056836#comment-13056836 ] 

Hudson commented on HBASE-4035:
-------------------------------

Integrated in HBase-TRUNK #1995 (See [https://builds.apache.org/job/HBase-TRUNK/1995/])
    

> Fix local-master-backup.sh - parameter order wrong
> --------------------------------------------------
>
>                 Key: HBASE-4035
>                 URL: https://issues.apache.org/jira/browse/HBASE-4035
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.0
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Minor
>             Fix For: 0.92.0
>
>
> I think this is a regression from HBASE-3895 (if so, my bad!). The local-master-backup.sh needs the parameters adjusted to work.
> {noformat}
> $ bin/local-master-backup.sh start 1          
> starting master, logging to /var/lib/hbase/logs/hbase-larsgeorge-1-master-de1-app-mbp-2.out
> Usage: Master [opts] start|stop
>  start  Start Master. If local mode, start Master and RegionServer in same JVM
>  stop   Start cluster shutdown; Master signals RegionServer shutdown
>  where [opts] are:
>    --minServers=<servers>    Minimum RegionServers needed to host user tables.
>    --backup                  Master should start in backup mode
> {noformat}
> The log has
> {noformat}
> 2011-06-25 10:26:34,864 ERROR org.apache.hadoop.hbase.master.HMasterCommandLine: Could not parse: 
> org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -D
>         at org.apache.commons.cli.Parser.processOption(Parser.java:363)
>         at org.apache.commons.cli.Parser.parse(Parser.java:199)
>         at org.apache.commons.cli.Parser.parse(Parser.java:85)
>         at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:73)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
>         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:76)
>         at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:1346)
> {noformat}
> Fix:
> {noformat}
> Index: bin/local-master-backup.sh
> ===================================================================
> --- bin/local-master-backup.sh  (revision 1139502)
> +++ bin/local-master-backup.sh  (working copy)
> @@ -21,9 +21,9 @@
>    DN=$2
>    export HBASE_IDENT_STRING="$USER-$DN"
>    HBASE_MASTER_ARGS="\
> -    --backup \
>      -D hbase.master.port=`expr 60000 + $DN` \
> -    -D hbase.master.info.port=`expr 60010 + $DN`"
> +    -D hbase.master.info.port=`expr 60010 + $DN` \
> +    --backup"
>    "$bin"/hbase-daemon.sh $1 master $HBASE_MASTER_ARGS
>  }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-4035) Fix local-master-backup.sh - parameter order wrong

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu reassigned HBASE-4035:
-----------------------------

    Assignee: Lars George

> Fix local-master-backup.sh - parameter order wrong
> --------------------------------------------------
>
>                 Key: HBASE-4035
>                 URL: https://issues.apache.org/jira/browse/HBASE-4035
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.0
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Minor
>             Fix For: 0.92.0
>
>
> I think this is a regression from HBASE-3895 (if so, my bad!). The local-master-backup.sh needs the parameters adjusted to work.
> {noformat}
> $ bin/local-master-backup.sh start 1          
> starting master, logging to /var/lib/hbase/logs/hbase-larsgeorge-1-master-de1-app-mbp-2.out
> Usage: Master [opts] start|stop
>  start  Start Master. If local mode, start Master and RegionServer in same JVM
>  stop   Start cluster shutdown; Master signals RegionServer shutdown
>  where [opts] are:
>    --minServers=<servers>    Minimum RegionServers needed to host user tables.
>    --backup                  Master should start in backup mode
> {noformat}
> The log has
> {noformat}
> 2011-06-25 10:26:34,864 ERROR org.apache.hadoop.hbase.master.HMasterCommandLine: Could not parse: 
> org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -D
>         at org.apache.commons.cli.Parser.processOption(Parser.java:363)
>         at org.apache.commons.cli.Parser.parse(Parser.java:199)
>         at org.apache.commons.cli.Parser.parse(Parser.java:85)
>         at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:73)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
>         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:76)
>         at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:1346)
> {noformat}
> Fix:
> {noformat}
> Index: bin/local-master-backup.sh
> ===================================================================
> --- bin/local-master-backup.sh  (revision 1139502)
> +++ bin/local-master-backup.sh  (working copy)
> @@ -21,9 +21,9 @@
>    DN=$2
>    export HBASE_IDENT_STRING="$USER-$DN"
>    HBASE_MASTER_ARGS="\
> -    --backup \
>      -D hbase.master.port=`expr 60000 + $DN` \
> -    -D hbase.master.info.port=`expr 60010 + $DN`"
> +    -D hbase.master.info.port=`expr 60010 + $DN` \
> +    --backup"
>    "$bin"/hbase-daemon.sh $1 master $HBASE_MASTER_ARGS
>  }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4035) Fix local-master-backup.sh - parameter order wrong

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054996#comment-13054996 ] 

Ted Yu commented on HBASE-4035:
-------------------------------

Integrated to branch and TRUNK.

Thanks for the patch Lars.

> Fix local-master-backup.sh - parameter order wrong
> --------------------------------------------------
>
>                 Key: HBASE-4035
>                 URL: https://issues.apache.org/jira/browse/HBASE-4035
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.0
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Minor
>             Fix For: 0.92.0
>
>
> I think this is a regression from HBASE-3895 (if so, my bad!). The local-master-backup.sh needs the parameters adjusted to work.
> {noformat}
> $ bin/local-master-backup.sh start 1          
> starting master, logging to /var/lib/hbase/logs/hbase-larsgeorge-1-master-de1-app-mbp-2.out
> Usage: Master [opts] start|stop
>  start  Start Master. If local mode, start Master and RegionServer in same JVM
>  stop   Start cluster shutdown; Master signals RegionServer shutdown
>  where [opts] are:
>    --minServers=<servers>    Minimum RegionServers needed to host user tables.
>    --backup                  Master should start in backup mode
> {noformat}
> The log has
> {noformat}
> 2011-06-25 10:26:34,864 ERROR org.apache.hadoop.hbase.master.HMasterCommandLine: Could not parse: 
> org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -D
>         at org.apache.commons.cli.Parser.processOption(Parser.java:363)
>         at org.apache.commons.cli.Parser.parse(Parser.java:199)
>         at org.apache.commons.cli.Parser.parse(Parser.java:85)
>         at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:73)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
>         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:76)
>         at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:1346)
> {noformat}
> Fix:
> {noformat}
> Index: bin/local-master-backup.sh
> ===================================================================
> --- bin/local-master-backup.sh  (revision 1139502)
> +++ bin/local-master-backup.sh  (working copy)
> @@ -21,9 +21,9 @@
>    DN=$2
>    export HBASE_IDENT_STRING="$USER-$DN"
>    HBASE_MASTER_ARGS="\
> -    --backup \
>      -D hbase.master.port=`expr 60000 + $DN` \
> -    -D hbase.master.info.port=`expr 60010 + $DN`"
> +    -D hbase.master.info.port=`expr 60010 + $DN` \
> +    --backup"
>    "$bin"/hbase-daemon.sh $1 master $HBASE_MASTER_ARGS
>  }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-4035) Fix local-master-backup.sh - parameter order wrong

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu resolved HBASE-4035.
---------------------------

    Resolution: Fixed

> Fix local-master-backup.sh - parameter order wrong
> --------------------------------------------------
>
>                 Key: HBASE-4035
>                 URL: https://issues.apache.org/jira/browse/HBASE-4035
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.92.0
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Minor
>             Fix For: 0.92.0
>
>
> I think this is a regression from HBASE-3895 (if so, my bad!). The local-master-backup.sh needs the parameters adjusted to work.
> {noformat}
> $ bin/local-master-backup.sh start 1          
> starting master, logging to /var/lib/hbase/logs/hbase-larsgeorge-1-master-de1-app-mbp-2.out
> Usage: Master [opts] start|stop
>  start  Start Master. If local mode, start Master and RegionServer in same JVM
>  stop   Start cluster shutdown; Master signals RegionServer shutdown
>  where [opts] are:
>    --minServers=<servers>    Minimum RegionServers needed to host user tables.
>    --backup                  Master should start in backup mode
> {noformat}
> The log has
> {noformat}
> 2011-06-25 10:26:34,864 ERROR org.apache.hadoop.hbase.master.HMasterCommandLine: Could not parse: 
> org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -D
>         at org.apache.commons.cli.Parser.processOption(Parser.java:363)
>         at org.apache.commons.cli.Parser.parse(Parser.java:199)
>         at org.apache.commons.cli.Parser.parse(Parser.java:85)
>         at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:73)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
>         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:76)
>         at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:1346)
> {noformat}
> Fix:
> {noformat}
> Index: bin/local-master-backup.sh
> ===================================================================
> --- bin/local-master-backup.sh  (revision 1139502)
> +++ bin/local-master-backup.sh  (working copy)
> @@ -21,9 +21,9 @@
>    DN=$2
>    export HBASE_IDENT_STRING="$USER-$DN"
>    HBASE_MASTER_ARGS="\
> -    --backup \
>      -D hbase.master.port=`expr 60000 + $DN` \
> -    -D hbase.master.info.port=`expr 60010 + $DN`"
> +    -D hbase.master.info.port=`expr 60010 + $DN` \
> +    --backup"
>    "$bin"/hbase-daemon.sh $1 master $HBASE_MASTER_ARGS
>  }
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira