You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/03/31 21:52:21 UTC
[GitHub] brooklyn-library pull request: ControlledDynamicWebAppCluster: imp...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/29
ControlledDynamicWebAppCluster: improve synchronization
Synchronising on these getters is not necessary, because the values are set in `init()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-library fix/BROOKLYN-245-deadlock
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 0e2f28cc41a0dd8bee6b5b8d74e98f5d12961231
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-31T19:48:53Z
ControlledDynamicWebAppCluster: improve synchronization
Synchronising on these getters is not necessary, because the
values are set in init().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: ControlledDynamicWebAppCluster: imp...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-library/pull/29#issuecomment-204354362
btw build failure fixed in https://github.com/apache/brooklyn-library/pull/28 (similar PRs for dist & library) - fails only on certain machines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: ControlledDynamicWebAppCluster: imp...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-library/pull/29#issuecomment-204353539
Build failure is unrelated. Is that because the apache builds hadn't yet built 0.10.0-SNAPSHOT of brooklyn-parent, to make that available in the snapshot repo? Closing and re-opening to force another build.
```
ERROR: Failed to parse POMs
java.io.IOException: remote file operation failed: /home/jenkins/jenkins-slave/workspace/brooklyn-library-pull-requests at hudson.remoting.Channel@5b16c63d:ubuntu-1: hudson.remoting.ProxyException: hudson.maven.MavenModuleSetBuild$MavenExecutionException: org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM: Could not find artifact org.apache.brooklyn:brooklyn-parent:pom:0.10.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 24, column 13
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: ControlledDynamicWebAppCluster: imp...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/brooklyn-library/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: ControlledDynamicWebAppCluster: imp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: ControlledDynamicWebAppCluster: imp...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/brooklyn-library/pull/29
ControlledDynamicWebAppCluster: improve synchronization
Synchronising on these getters is not necessary, because the values are set in `init()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-library fix/BROOKLYN-245-deadlock
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 0e2f28cc41a0dd8bee6b5b8d74e98f5d12961231
Author: Aled Sage <al...@gmail.com>
Date: 2016-03-31T19:48:53Z
ControlledDynamicWebAppCluster: improve synchronization
Synchronising on these getters is not necessary, because the
values are set in init().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---