You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "0xMudit (via GitHub)" <gi...@apache.org> on 2026/08/26 09:08:38 UTC
[I] test(desktop): expand a11y coverage audit to chat, tool results, and error states [maka]
0xMudit opened a new issue, #3893:
URL: https://github.com/apache/maka/issues/3893
## Summary
The accessibility coverage test (pps/desktop/e2e/accessibility-coverage.spec.ts) only covers settings pages, module pages, composer/workbar entry points, keyboard-help dialog, and command palette. Major interactive surfaces are not audited.
## Current Coverage
- Settings pages (navigation loop)
- Module pages (extensions/skills/MCP, automations)
- Composer/workbar entry points
- Keyboard-help dialog
- Command palette
## Missing Coverage
- [ ] Chat message rendering and streaming output
- [ ] Tool call results and expandable tool output
- [ ] Model picker / provider selection
- [ ] Error states and toast notifications
- [ ] File diff viewer / change panel
- [ ] Terminal panel
- [ ] Browser panel
- [ ] Task management panel
- [ ] Daily review surface
- [ ] Agent graph visualization
## Additional Gap
No keyboard navigation test exists for the primary conversation flow (navigating between messages, expanding tool calls, reaching send button).
## Proposed Solution
1. Extend ccessibility-coverage.spec.ts to cover the surfaces listed above
2. Add a dedicated keyboard-navigability audit for the conversation/chat surface
3. Ensure all interactive elements have proper ARIA labels and roles
## Acceptance Criteria
- [ ] A11y audit covers all major interactive surfaces
- [ ] Keyboard navigation audit for conversation flow passes
- [ ] No axe-core violations in new coverage areas
## Labels
bug, help wanted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] test(desktop): expand a11y coverage audit to chat, tool results, and error states [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #3893:
URL: https://github.com/apache/maka/issues/3893#issuecomment-5464249688
same as #3944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] test(desktop): expand a11y coverage audit to chat, tool results, and error states [maka]
Posted by "1625567290 (via GitHub)" <gi...@apache.org>.
1625567290 commented on issue #3893:
URL: https://github.com/apache/maka/issues/3893#issuecomment-5463473978
I'd like to take this issue. I will extend the existing behavioral accessibility E2E coverage across the missing primary surfaces and add a dedicated keyboard-navigation contract for the conversation flow. I will keep the work isolated from the open Storybook failure-state PRs (#4162, #4167, and #4169): this change will target the accessibility E2E/fixture path rather than their story files, and I will validate the complete accessibility spec plus the affected Desktop E2E surfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] test(desktop): expand a11y coverage audit to chat, tool results, and error states [maka]
Posted by "1625567290 (via GitHub)" <gi...@apache.org>.
1625567290 commented on issue #3893:
URL: https://github.com/apache/maka/issues/3893#issuecomment-5466909751
Thanks. There is overlap in the named surfaces, but the acceptance paths are different:
- #3944 is the Storybook breadth effort: one surface per PR, adding fixed failure/edge-state stories.
- #3893 is the live Desktop accessibility audit: exercise the real Electron transcript/tool/task/Graph/workbar paths, inspect the runtime accessibility tree, and prove keyboard reachability through Tab/Enter.
PR #4202 does not add or modify story files. It complements the #3944 story coverage by extending the behavioral E2E audit, adding deterministic runtime fixture data, and correcting the nested WorkHub landmark from a second `main` to a named `region`. The latest revision also removes direct focus shortcuts and records the complete keyboard path requested in review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] test(desktop): expand a11y coverage audit to chat, tool results, and error states [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #3893: test(desktop): expand a11y coverage audit to chat, tool results, and error states
URL: https://github.com/apache/maka/issues/3893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org