You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "KKopyscinski (via GitHub)" <gi...@apache.org> on 2023/08/01 11:43:35 UTC
[GitHub] [mynewt-nimble] KKopyscinski opened a new pull request, #1580: host/ble_att_svr.c: do not read own characteristics without read perm…
KKopyscinski opened a new pull request, #1580:
URL: https://github.com/apache/mynewt-nimble/pull/1580
…ission
Characteristics without read permission most likely do not expect being read by their access callback. This especially relates to control point characteristics, that do not hold any particular value, but are used to access procedures, like GATT_PROXY_DATA_IN characteristic in Mesh. Reading them will lead to triggering procedures resulting with undefined behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #1580: host/ble_att_svr.c: do not read own characteristics without read perm…
Posted by "KKopyscinski (via GitHub)" <gi...@apache.org>.
KKopyscinski commented on PR #1580:
URL: https://github.com/apache/mynewt-nimble/pull/1580#issuecomment-1660230071
So this breaks unittests as it is expected that permission is not checked for internal access by att server to it's own characteristics. Imo either unittest expectation should be changed (but not checking permission of own database makes sense) or other method of verifying what operation is supported on given attribute must be developed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] host/ble_att_svr.c: do not read own characteristics without read perm… [mynewt-nimble]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1580:
URL: https://github.com/apache/mynewt-nimble/pull/1580#issuecomment-6336232375
This pull request had no activity for 12 months and is marked as stale. If it is still valid, please rebase it on current base branch. Stale pull requests are not closed automatically, the label is removed on any update or comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org