You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/23 06:48:50 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #8557: fix: define destroy() to close protos

spacewander commented on code in PR #8557:
URL: https://github.com/apache/apisix/pull/8557#discussion_r1056083134


##########
apisix/plugins/grpc-transcode/proto.lua:
##########
@@ -270,5 +270,10 @@ function _M.init()
     end
 end
 
+function _M.destroy()
+    if protos then
+        protos:close()

Review Comment:
   Could we add a test to ensure the `close` is called? For instance, via injecting some code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org