You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/02/20 09:32:25 UTC
Review Request 56843: AMBARI-20077. Server Error when trying to save
and not overwrite
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56843/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20077
https://issues.apache.org/jira/browse/AMBARI-20077
Repository: ambari
Description
-------
Saving recent workflow has been changed to make it per user and also draft file save will be overwritten automatically. This solves the server errors in the bug described.
Diffs
-----
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java a119a7e
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java 9791c47
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 61d878e
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java 24c263b
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java fc08b80
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java 7513107
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 1fc0c5f
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js db7a180
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 369481f
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 29c9dd2
contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 75cdaf9
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 26e72d5
Diff: https://reviews.apache.org/r/56843/diff/
Testing
-------
Manual
Thanks,
Madhan Reddy
Re: Review Request 56843: AMBARI-20077. Server Error when trying to
save and not overwrite
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56843/#review166070
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 20, 2017, 9:32 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56843/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 9:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20077
> https://issues.apache.org/jira/browse/AMBARI-20077
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Saving recent workflow has been changed to make it per user and also draft file save will be overwritten automatically. This solves the server errors in the bug described.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java a119a7e
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java 9791c47
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 61d878e
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java 24c263b
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java fc08b80
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java 7513107
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 1fc0c5f
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js db7a180
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 369481f
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 29c9dd2
> contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 75cdaf9
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 26e72d5
>
> Diff: https://reviews.apache.org/r/56843/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 56843: AMBARI-20077. Server Error when trying to
save and not overwrite
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56843/#review166077
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 20, 2017, 9:32 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56843/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 9:32 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20077
> https://issues.apache.org/jira/browse/AMBARI-20077
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Saving recent workflow has been changed to make it per user and also draft file save will be overwritten automatically. This solves the server errors in the bug described.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java a119a7e
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java 9791c47
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 61d878e
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java 24c263b
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java fc08b80
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java 7513107
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 1fc0c5f
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js db7a180
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 369481f
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 29c9dd2
> contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 75cdaf9
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 26e72d5
>
> Diff: https://reviews.apache.org/r/56843/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Madhan Reddy
>
>