[GitHub] lresende edited a comment on issue #43: BAHIR-193: facilitate scala version change

[GitBox <gi...@apache.org>]

lresende edited a comment on issue #43: BAHIR-193: facilitate scala version change
URL: https://github.com/apache/bahir-flink/pull/43#issuecomment-462211901
 
 
   Flink seems to use something similar, but most of the other projects I have worked before (e.g. Apache Spark) use the current approach used in Bahir. Also, it seems scala best practices to have all artifacts published with the version as part of the artifact name (e.g. _2.11 or _2.12).
   
   Now, back to the build, my understanding is that, when you have the parent pom released, it becomes a static file, and the pre-defined scala.version is also static. So, when a project add a dependency on `<flink-connector-kudu_2.12>` it will have a transient dependency to `<flink_parent>` that has a `scala.binary.version` defined as 2.11, unless it provides the same infrastructure of profiles in their build to override the property, no? 
   
   Please let me know what you think, and in the meantime, I will play with it a little more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services