[GitHub] [spark] viirya commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #37879:
URL: https://github.com/apache/spark/pull/37879#discussion_r1170527110


##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -216,19 +216,23 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
         c
       }
 
-    case DropTable(ResolvedV1TableIdentifier(ident), ifExists, purge) =>
+    case DropTable(ResolvedV1Identifier(ident), ifExists, purge) =>

Review Comment:
   I checked the difference between `ResolvedV1TableIdentifier` and `ResolvedV1Identifier`. So do you mean `ResolvedV1Identifier` could wrongly apply on a V2 table? I.e.,
   
   > case ResolvedIdentifier(catalog, ident) if isSessionCatalog(catalog)
   
   If `catalog` is a custom session catalog which is capable for V1 and V2 tables?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org