You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mike-tutkowski <gi...@git.apache.org> on 2016/03/16 05:57:50 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1441
CLOUDSTACK-9297: delete snapshot without id is failing with Unable to…
… determine the storage pool of the snapshot
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-tutkowski/cloudstack 4.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1441
----
commit 87079c56e4cc11b2a1bed817bd8c9b14c9bd3d29
Author: Mike Tutkowski <mi...@solidfire.com>
Date: 2016-03-16T04:56:51Z
CLOUDSTACK-9297: delete snapshot without id is failing with Unable to determine the storage pool of the snapshot
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1441
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197929660
Hi @rafaelweingartner Thanks for the comments.
Just wanted to point out that if the revertSnapshot method is invoked, then that is actually a failure of the canHandle method to inform the calling code to not call the revertSnapshot method, so that's why the decision was made to throw an exception.
I see returning true as your revert was successful and returning false as it failed (but it was OK for you to ask us to revert because canHandle properly told you that you could do so).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206925982
## CI RESULTS
### 84/85 TESTS PASSED
The only failed test is a test that often fails in my environment and is unrelated to this change.
**Associated Uploads**
**`test_network_2NUDW1`:**
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1441/test_network_2NUDW1/results.txt)
**`test_vpc_routers_CHF744`:**
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1441/test_vpc_routers_CHF744/results.txt)
Uploads will be available until `2016-06-07 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/swill/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197952462
Maybe we're looking at different code?
I see the canHandle method being used from StorageStrategyFactoryImpl.getSnapshotStrategy.
It has a method, bestMatch, that it makes use of to pick a snapshot strategy with the ordinal value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197992182
got it @mike-tutkowski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197948544
I understand that your point that some other classes can overwrite that method and may return other elements of the enum. However, I do not see anything else in the code that used the “canHandle” method return that uses the returned value. I mean, it is used in the “revertSnapshot” method at line 285, but it only checks if the return is equal to “StrategyPriority.CANT_HANDLE” and then throws an exception if it is. To me, that is the same as if the method were returning a boolean value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1441#discussion_r56880597
--- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
@Override
public boolean revertSnapshot(SnapshotInfo snapshot) {
- throw new CloudRuntimeException("revert Snapshot is not supported");
+ if (canHandle(snapshot,SnapshotOperation.REVERT) == StrategyPriority.CANT_HANDLE) {
--- End diff --
Hi @DaanHoogland, this was only my first doubt (question). After that, @mike-tutkowski and I exchanged some other messages and then I understood the method. I see why a boolean return would not suffice all of its needs.
I was misled by the name of the method. Every time I see a method name that starts with "can/has/is", I think that it will return a boolean value.
The code of this PR is OK for me; I would only suggest a name change on that "canHandle" method to a more descriptive one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197942848
The canHandle method is used by CloudStack's snapshot infrastructure to determine which snapshot strategy to use.
For example, StorageSystemSnapshotStrategy returns either StrategyPriority.HIGHEST or StrategyPriority.CANT_HANDLE whereas XenserverSnapshotStrategy returns StrategyPriority.DEFAULT or StrategyPriority.CANT_HANDLE.
That being the case, there are at least three options in play (and other people can write custom snapshot strategies that they don't even check into the CloudStack repo, so we can't easily just change the interface where canHandle is declared).
As for this sentence:
“I see returning true as your revert was successful and returning false as it failed (but it was OK for you to ask us to revert because canHandle properly told you that you could do so)”
That was in regards to the revertSnapshot method. It sounds like you agree with the exception being thrown there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-207452373
It's all set to go. :-)
On Apr 8, 2016, at 7:09 AM, Rafael Weing?rtner <no...@github.com>> wrote:
@swill<https://github.com/swill> no final comments ;)
-
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub<https://github.com/apache/cloudstack/pull/1441#issuecomment-207425226>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206932399
I think this is ready pending a code review. Can someone who has spent some time reviewing this PR with Mike please give me the go ahead on this PR. @rafaelweingartner, you have been the most active reviewing this PR, are you happy with the state of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197376318
Perhaps I'll rename it in 4.9 (probably not a good idea to do so in 4.7 and then move the name change up to 4.8 and 4.9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197892051
@mike-tutkowski could you fix the PR title and improve its description (a brief description of the problem and solution would do)?
Additionally, what about some unit tests to "canHandle" method? I also recommend to change that method return, a boolean return is more intuitive in my opinion; I also believe that a Java doc to that method would be appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197164602
tested on KVM, it is good.
so XenserverSnapshotStrategy LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by alexandrelimassantana <gi...@git.apache.org>.
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1441#discussion_r56768712
--- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java ---
@@ -440,41 +400,28 @@ private void markAsBackedUp(SnapshotObject snapshotObj) {
@Override
public StrategyPriority canHandle(Snapshot snapshot, SnapshotOperation op) {
- long volumeId = snapshot.getVolumeId();
- VolumeVO volumeVO = _volumeDao.findById(volumeId);
if (SnapshotOperation.REVERT.equals(op)) {
- if (volumeVO != null && ImageFormat.QCOW2.equals(volumeVO.getFormat()))
- return StrategyPriority.DEFAULT;
- else
- return StrategyPriority.CANT_HANDLE;
+ return StrategyPriority.CANT_HANDLE;
}
--- End diff --
Good work on rewritting the logic to a slimmer state.
Wouldn't be it more readable if you turn lines 407-422 into a boolean function which would return true if "supportsStorageSystemSnapshots". Snap this chunk of code could prove useful on creating unit tests and documentation as this segment clearly aims to check this condition solely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197970382
Ok @mike-tutkowski, now I believe I understand a little bit more of the code.
You are reusing a method that already exist and returns the StrategyPriority (you did not create that method to suffice your code). I was misled by the name of the method, when I first saw it, I thought that the method was used solely to check if it can or cannot proceed with the snapshot when in fact it is used to do much more.
I believe "getSnapshotStrategy" would be a more suitable name.
Now that I understand what we have there, I am ok with that conditional as it
is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-207031227
Thanks for the comments @rafaelweingartner and @ustcweizhou.
Since canHandle is part of the infrastructure, we decided this particular PR isn't the place to change such a thing. Perhaps a future PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197975991
CloudStack iterates over all known snapshot strategies and asks each if it can handle a particular situation (take, delete, revert) for a volume or volume snapshot.
One with a priority higher than the others is selected.
If you can't handle the particular use case, you return CANT_HANDLE.
On Mar 17, 2016, at 12:49 PM, Rafael Weing?rtner <no...@github.com>> wrote:
Ok @mike-tutkowski<https://github.com/mike-tutkowski>, now I believe I understand a little bit more of the code.
You are reusing a method that already exist and returns the StrategyPriority (you did not create that method to suffice your code). I was misled by the name of the method, when I first saw it, I thought that the method was used solely to check if it can or cannot proceed with the snapshot when in fact it is used to do much more.
I believe "getSnapshotStrategy" would be a more suitable name.
Now that I understand what we have there, I am ok with that conditional as it
is.
-
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub<https://github.com/apache/cloudstack/pull/1441#issuecomment-197970382>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1441#discussion_r56801490
--- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
@Override
public boolean revertSnapshot(SnapshotInfo snapshot) {
- throw new CloudRuntimeException("revert Snapshot is not supported");
+ if (canHandle(snapshot,SnapshotOperation.REVERT) == StrategyPriority.CANT_HANDLE) {
--- End diff --
@rafaelweingartner if you consider changing a canHandle() method take care. These are called over all types of resources and should not break contract as to not confuse any Orchestrators in the system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-207424478
It looks like I have two LGTM on this PR and the tests are passing. This one is ready? Any final comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206978195
@swill you have a failure, why do you want an LGTM, seems to me it didn't pass the tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-205937640
I will get CI run against this PR as soon as I have my CI reinstalled. Thanks @mike-tutkowski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197935023
@mike-tutkowski thanks for the improvements on PR title and description.
I understand the point of throwing an exception and I really like that approach.
About the suggested change on “canHandle” method, I still did not see the need to use the enum. If you were using more than 2 values as its returns, it would be something I would understand; but you only use two values that could be represented as a “true” or “false”.
Could you elaborate a little bit more?
I also did not understand this sentence:
“I see returning true as your revert was successful and returning false as it failed (but it was OK for you to ask us to revert because canHandle properly told you that you could do so)”
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206981924
@swill, all of my enquiries here were answered. My only complaint was about the method name "canHandle"; it misled me during my first and second look at this PR.I would prefer something like "getStorageStrategyPriority".
The code looks good to me though. LGTM ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-207031562
@mike-tutkowski, @swill I am ok with that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-207425226
@swill no final comments ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-205949475
Thanks, Will!
On Apr 5, 2016, at 12:35 PM, Will Stevens <no...@github.com>> wrote:
I will get CI run against this PR as soon as I have my CI reinstalled. Thanks @mike-tutkowski<https://github.com/mike-tutkowski>
-
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub<https://github.com/apache/cloudstack/pull/1441#issuecomment-205937640>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197375867
Ideally, at some point in the future, we should rename XenserverSnapshotStrategy to something more generic (maybe DefaultSnapshotStrategy or something).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1441#discussion_r56507303
--- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java ---
@@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
@Override
public boolean revertSnapshot(SnapshotInfo snapshot) {
- throw new CloudRuntimeException("revert Snapshot is not supported");
+ if (canHandle(snapshot,SnapshotOperation.REVERT) == StrategyPriority.CANT_HANDLE) {
--- End diff --
What about changing this "canHandle" method to return a boolean if the snapshot can be handled, instead of a enum value?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206981349
@DaanHoogland I have some issues with networking when using redundant VRs in my environment. I consistently have this type of issue, and it is unrelated to the actual code. If it is not clear if the issue is the environment or the PR, I rerun the CI to validate again. In this case I am confident it is my environment. I was experimenting with running 3 stacks all in parallel and have found that is not realistic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9297: delete snapshot without ...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197375495
Thanks, @ustcweizhou!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---