You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/03/07 12:42:43 UTC

[GitHub] [zookeeper] TisonKun opened a new pull request #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org

TisonKun opened a new pull request #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org
URL: https://github.com/apache/zookeeper/pull/1279
 
 
   Change the links to archive.apache.org page to direct links to downloads.apache.org. Also adjust words.
   
   Please help on review :-)
   
   cc @eolivelli 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli merged pull request #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org

Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org
URL: https://github.com/apache/zookeeper/pull/1279
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] eolivelli commented on issue #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org
URL: https://github.com/apache/zookeeper/pull/1279#issuecomment-596087773
 
 
   @TisonKun  the patch looks great.
   The precommit job is failing because we did not configure "spotbugs" plugin in the pom.xml of website build.
   
   Do you mind adding a dummy plugin configuration, with hardcoded "skip" option ? this way the precommit will pass.
   
   It looks like you are the first one who sends a PR against the website !! 
   Thank you so much.
   
   I will be happy to commit this fix soon. I feel there is no need for a double +1 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] TisonKun commented on issue #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #1279: ZOOKEEPER-3746. Move the download page to downloads.apache.org
URL: https://github.com/apache/zookeeper/pull/1279#issuecomment-596089048
 
 
   @eolivelli Thanks for your information! I've pushed a commit and it seems precommit job works.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services