You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jdferreira (via GitHub)" <gi...@apache.org> on 2023/03/13 12:12:05 UTC
[GitHub] [spark] jdferreira opened a new pull request, #40398: Update `translate` docblock
jdferreira opened a new pull request, #40398:
URL: https://github.com/apache/spark/pull/40398
### What changes were proposed in this pull request?
The documentation for the `translate` SQL function is a bit difficult to parse and understand. I propose the new texting.
### Why are the changes needed?
To improve documentation
### Does this PR introduce _any_ user-facing change?
I'm not sure, and I don't quite understand if I need to do something to make this documentation change become visible in the online documentation. I'd appreciate help here to improve the PR, if needed.
### How was this patch tested?
No tests added or executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40398: [MINOR][DOCS] Update `translate` docblock
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40398:
URL: https://github.com/apache/spark/pull/40398#issuecomment-1474601033
Can you push an empty commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #40398: [MINOR][DOCS] Update `translate` docblock
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #40398: [MINOR][DOCS] Update `translate` docblock
URL: https://github.com/apache/spark/pull/40398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jdferreira commented on pull request #40398: [MINOR][DOCS] Update `translate` docblock
Posted by "jdferreira (via GitHub)" <gi...@apache.org>.
jdferreira commented on PR #40398:
URL: https://github.com/apache/spark/pull/40398#issuecomment-1470420003
@srowen I haev enabled it, but now I don't know how to progress. Is there a "re-run" button to re-trigger the build? Or do I push an empty commit into this branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40398: [MINOR][DOCS] Update `translate` docblock
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40398:
URL: https://github.com/apache/spark/pull/40398#issuecomment-1468116741
It's fine. Can you enable the tests to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org