You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/26 09:41:24 UTC
[GitHub] flink pull request #3996: [FLINK-6728] Activate strict checkstyle for flink-...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3996
[FLINK-6728] Activate strict checkstyle for flink-quickstart
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6728_cs_qs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3996.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3996
----
commit 214165e56378e62496993b6f431db9a7ddc95db9
Author: zentol <ch...@apache.org>
Date: 2017-05-26T07:47:11Z
[FLINK-6728] Activate strict checkstyle for flink-quickstart
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3996: [FLINK-6728] Activate strict checkstyle for flink-...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3996#discussion_r118713891
--- Diff: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/SocketTextStreamWordCount.java ---
@@ -27,26 +27,23 @@
* This example shows an implementation of WordCount with data from a text
* socket. To run the example make sure that the service providing the text data
* is already up and running.
- *
- * <p>
- * To start an example socket text stream on your local machine run netcat from
+ *
+ * <p>To start an example socket text stream on your local machine run netcat from
* a command line: <code>nc -lk 9999</code>, where the parameter specifies the
* port number.
- *
- *
- * <p>
- * Usage:
+ *
+ *
--- End diff --
Extra line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3996: [FLINK-6728] Activate strict checkstyle for flink-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3996
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3996: [FLINK-6728] Activate strict checkstyle for flink-quickst...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3996
hmm...doesn't appear like i can easily include the resource folder in the checkstyle plugin, without also including all scala files :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---