You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/04 23:04:40 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #24668: added component specific labels

jedcunningham commented on code in PR #24668:
URL: https://github.com/apache/airflow/pull/24668#discussion_r938307622


##########
chart/templates/cleanup/cleanup-cronjob.yaml:
##########
@@ -38,9 +38,9 @@ metadata:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
-{{- with .Values.labels }}
-{{ toYaml . | indent 4 }}
-{{- end }}
+  {{- if or (.Values.labels) (.Values.cleanup.labels) }}
+  {{- mustMerge .Values.cleanup.labels .Values.labels | toYaml | nindent 4 }}
+  {{- end }}

Review Comment:
   No, thinking again merging is just fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org