You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by "Jamie G." <ja...@gmail.com> on 2012/06/20 22:05:29 UTC
[VOTE] Release Apache Karaf 2.2.8
Hi,
We resolved 28 issues in this release (web page will be published post
RC promotion):
https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
Staging repository:
https://repository.apache.org/content/repositories/orgapachekaraf-255/
Release tags:
https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
Please vote to approve this release:
[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)
This vote will be open for 72 hours.
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Dan Tran <da...@gmail.com>.
this is odd, I dont see this behavior in 2.0.7 with custom deployer
which also KarArtifactInstaller service to do the work
-D
On Wed, Jun 20, 2012 at 11:03 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> FYI:
>
> https://issues.apache.org/jira/browse/KARAF-999
>
> So the change to not use local-repo date from Karaf 2.2.6, so it should be
> already the case in 2.2.7.
>
>
> Regards
> JB
>
> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>
>> Hello Karaf devs,
>>
>> regresion in KarArtifactInstaller service?
>>
>> in karaf-2.2.7,
>>
>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>> 'myfeature.jar' under local-repo
>>
>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>> local-repo/myfeature.kar?
>>
>> is it expected? This changes breaks my custom deployment.
>>
>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>> like to continue upgrading to latest 2.2.x code without changing my
>> code.
>>
>> Thanks
>>
>> -Dan
>>
>>
>>
>>
>> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com>
>> wrote:
>>>
>>> +1
>>>
>>> Thanks a lot.
>>>
>>> Romain
>>>
>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>
>>>> +1 (binding)
>>>>
>>>> First tests passed without problem, I will test with Cellar, etc
>>>> tomorrow
>>>> morning, but it looks good to me.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> We resolved 28 issues in this release (web page will be published post
>>>>> RC promotion):
>>>>>
>>>>>
>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>
>>>>> Staging repository:
>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>
>>>>> Release tags:
>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>
>>>>> Please vote to approve this release:
>>>>>
>>>>> [ ] +1 Approve the release
>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>
>>>>> This vote will be open for 72 hours.
>>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
FYI:
https://issues.apache.org/jira/browse/KARAF-999
So the change to not use local-repo date from Karaf 2.2.6, so it should
be already the case in 2.2.7.
Regards
JB
On 06/21/2012 12:13 AM, Dan Tran wrote:
> Hello Karaf devs,
>
> regresion in KarArtifactInstaller service?
>
> in karaf-2.2.7,
>
> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
> 'myfeature.jar' under local-repo
>
> in karaf-2.2.8, the call, expect that I put myfeature.kar under
> local-repo/myfeature.kar?
>
> is it expected? This changes breaks my custom deployment.
>
> Can we have this new behavior in 3.0, or 2.3 instead? since I would
> like to continue upgrading to latest 2.2.x code without changing my
> code.
>
> Thanks
>
> -Dan
>
>
>
>
> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com> wrote:
>> +1
>>
>> Thanks a lot.
>>
>> Romain
>>
>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>
>>> +1 (binding)
>>>
>>> First tests passed without problem, I will test with Cellar, etc tomorrow
>>> morning, but it looks good to me.
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>
>>>> Hi,
>>>>
>>>> We resolved 28 issues in this release (web page will be published post
>>>> RC promotion):
>>>>
>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>
>>>> Staging repository:
>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>
>>>> Release tags:
>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>
>>>> Please vote to approve this release:
>>>>
>>>> [ ] +1 Approve the release
>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>
>>>> This vote will be open for 72 hours.
>>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Dan,
Now the kar deployer doesn't use local-repo anymore, it uses system repo
directly.
It was considered as an issue by some users, that's why I changed it in
2.2.x.
As it changes the behavior, you are right that it should be done on new
branches.
Let me discuss with Jamie how we move around that.
Regards
JB
On 06/21/2012 12:13 AM, Dan Tran wrote:
> Hello Karaf devs,
>
> regresion in KarArtifactInstaller service?
>
> in karaf-2.2.7,
>
> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
> 'myfeature.jar' under local-repo
>
> in karaf-2.2.8, the call, expect that I put myfeature.kar under
> local-repo/myfeature.kar?
>
> is it expected? This changes breaks my custom deployment.
>
> Can we have this new behavior in 3.0, or 2.3 instead? since I would
> like to continue upgrading to latest 2.2.x code without changing my
> code.
>
> Thanks
>
> -Dan
>
>
>
>
> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com> wrote:
>> +1
>>
>> Thanks a lot.
>>
>> Romain
>>
>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>
>>> +1 (binding)
>>>
>>> First tests passed without problem, I will test with Cellar, etc tomorrow
>>> morning, but it looks good to me.
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>
>>>> Hi,
>>>>
>>>> We resolved 28 issues in this release (web page will be published post
>>>> RC promotion):
>>>>
>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>
>>>> Staging repository:
>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>
>>>> Release tags:
>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>
>>>> Please vote to approve this release:
>>>>
>>>> [ ] +1 Approve the release
>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>
>>>> This vote will be open for 72 hours.
>>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by "Jamie G." <ja...@gmail.com>.
Hi,
The vote has passed with the following result :
+1 (binding): Jean-Baptiste Onofré, Ioannis Canellos, Freeman Fang,
Guillaume Nodet, Achim Nierbeck, and Andreas Pieber.
+1 (non binding): Romain Gilles, Ulhas Bhole, Christian Schneider,
I will copy this release to the Karaf dist directory and promote the
artifacts to the central Maven repository.
Cheers,
Jamie
On Mon, Jun 25, 2012 at 4:37 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi Christian,
>
> AFAIR, we discussed about that last year, when dealing about starting Karaf
> 3.0.0 (I gonna looking for the thread in the archive).
>
> First we "decided" to have:
> - one maintenance branch (bug fixes) aka 2.2.x
> - one dev trunk aka 3.0.x
>
> 2.3.x should have been created after 3.0.0, but we decided to create it as a
> transition between 2.2.x and 2.3.x.
>
> I will document that in a developer guide with the following table of
> content:
> - branches definition
> - building
> - style convention
> - release guide
>
> If all are OK, I will start that in the plane tomorrow morning.
>
> Regards
> JB
>
>
> On 06/25/2012 08:53 PM, Christian Schneider wrote:
>>
>> Typically the number of parallel branches does not get too high anyway
>> if we do not release that often.
>> Still I think it makes sense to have at least an agreement to have for
>> example 3 parallel branches like you proposed.
>> So people know what to expect of us.
>>
>> Christian
>>
>> Am 25.06.2012 18:34, schrieb Andreas Pieber:
>>>
>>> @JB np, it's always quite a hard balance between bug/behavior change
>>>
>>> @christian: I wont see this that hard; we support the last minor
>>> release and done; this makes three branches we actively work on (e.g.
>>> 2.3.x, 2.4.x and 3.x). If ppl need longer support they need to buy it
>>> from one of the supporters (talend, fuse, ...) or provide the fixes
>>> themselves. We just need to keep the bar between minors as low as
>>> possible to make the upgrade quite easy. Keeping a detailed upgrade
>>> page will also help. But I think thats it.
>>>
>>> Kind regards,
>>> Andreas
>>>
>>> On Mon, Jun 25, 2012 at 6:05 PM, Jean-Baptiste Onofré
>>> <jb...@nanthrax.net> wrote:
>>>>
>>>> I'm also agree. The change was not a new feature or an enhancement,
>>>> it was a
>>>> bug fix (as users reported). That's why I applied on 2.2.x branch,
>>>> even if
>>>> it was not very "clear".
>>>>
>>>> My apologies for that guys.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 06/25/2012 03:49 PM, Andreas Pieber wrote:
>>>>>
>>>>> I'm the third one backing Guillaume here. I've a strong negative
>>>>> feeling about changing behavior in micro releases if it's not a VERY
>>>>> critical bug. PPL adapt to the behavior and will become "afraid" of
>>>>> upgrading micro releases, although they definitely should do so to
>>>>> become the latest bug-fixes and get the security holes stuffed. But,
>>>>> since we've messed up this "concept" about 1k times for the 2.2.x
>>>>> branch anyhow I don't consider it a show stopper now; nevertheless we
>>>>> really should learn from this and do better for 2.3.x; I think this
>>>>> also includes opening 2.4.x the moment 2.3.0 is released to make sure
>>>>> that ppl have a place to include features/improvements and are not
>>>>> tempted to include them into micros; but this is a different story :-)
>>>>>
>>>>> Independently I've tested the latest release (src builds, notice
>>>>> checks, my applications, ...) and it looks really good to me.
>>>>>
>>>>> --> all in all +1 (binding) for the release.
>>>>>
>>>>> Kind regards,
>>>>> Andreas
>>>>>
>>>>> On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck
>>>>> <bc...@googlemail.com>
>>>>> wrote:
>>>>>>
>>>>>> I second Guillaume here, we should be real careful not to add so much
>>>>>> behavioral changes.
>>>>>>
>>>>>> regarding the release: +1
>>>>>>
>>>>>> regards, Achim
>>>>>>
>>>>>> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>>>>>>>
>>>>>>> Same feeling here, though I think we should learn from that and be
>>>>>>> more vigilant about not introducing new features or behavioral
>>>>>>> changes
>>>>>>> in micro releases, that should have been done in 2.3.
>>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> Ideally, a micro release should guarantee forward and backward
>>>>>>>> compatibility.
>>>>>>>>
>>>>>>>> I'd say though that the particular issue doesn't sound like a show
>>>>>>>> stopper
>>>>>>>> to me.
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Ioannis Canellos*
>>>>>>>> *
>>>>>>>> FuseSource <http://fusesource.com>
>>>>>>>>
>>>>>>>> **
>>>>>>>> Blog: http://iocanel.blogspot.com
>>>>>>>> **
>>>>>>>> Twitter: iocanel
>>>>>>>> *
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> ------------------------
>>>>>>> Guillaume Nodet
>>>>>>> ------------------------
>>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>>> ------------------------
>>>>>>> FuseSource, Integration everywhere
>>>>>>> http://fusesource.com
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>>>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
>>>>>> Committer & Project Lead
>>>>>> OPS4J Pax for Vaadin
>>>>>> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
>>>>>> Lead
>>>>>> blog <http://notizblog.nierbeck.de/>
>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>>>>
>>
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
>
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Christian Schneider <ch...@die-schneider.net>.
Sounds all good.
Like Dan wrote some time ago we still can have bugfix releases for older
branches if someone steps in and does them.
That we as a community only maintain one stable branch with fixes sounds
good.
Christian
Am 25.06.2012 21:07, schrieb Jean-Baptiste Onofré:
> Hi Christian,
>
> AFAIR, we discussed about that last year, when dealing about starting
> Karaf 3.0.0 (I gonna looking for the thread in the archive).
>
> First we "decided" to have:
> - one maintenance branch (bug fixes) aka 2.2.x
> - one dev trunk aka 3.0.x
>
> 2.3.x should have been created after 3.0.0, but we decided to create
> it as a transition between 2.2.x and 2.3.x.
>
> I will document that in a developer guide with the following table of
> content:
> - branches definition
> - building
> - style convention
> - release guide
>
> If all are OK, I will start that in the plane tomorrow morning.
>
> Regards
> JB
>
> On 06/25/2012 08:53 PM, Christian Schneider wrote:
>> Typically the number of parallel branches does not get too high anyway
>> if we do not release that often.
>> Still I think it makes sense to have at least an agreement to have for
>> example 3 parallel branches like you proposed.
>> So people know what to expect of us.
>>
>> Christian
>>
>> Am 25.06.2012 18:34, schrieb Andreas Pieber:
>>> @JB np, it's always quite a hard balance between bug/behavior change
>>>
>>> @christian: I wont see this that hard; we support the last minor
>>> release and done; this makes three branches we actively work on (e.g.
>>> 2.3.x, 2.4.x and 3.x). If ppl need longer support they need to buy it
>>> from one of the supporters (talend, fuse, ...) or provide the fixes
>>> themselves. We just need to keep the bar between minors as low as
>>> possible to make the upgrade quite easy. Keeping a detailed upgrade
>>> page will also help. But I think thats it.
>>>
>>> Kind regards,
>>> Andreas
>>>
>>> On Mon, Jun 25, 2012 at 6:05 PM, Jean-Baptiste Onofré
>>> <jb...@nanthrax.net> wrote:
>>>> I'm also agree. The change was not a new feature or an enhancement,
>>>> it was a
>>>> bug fix (as users reported). That's why I applied on 2.2.x branch,
>>>> even if
>>>> it was not very "clear".
>>>>
>>>> My apologies for that guys.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 06/25/2012 03:49 PM, Andreas Pieber wrote:
>>>>> I'm the third one backing Guillaume here. I've a strong negative
>>>>> feeling about changing behavior in micro releases if it's not a VERY
>>>>> critical bug. PPL adapt to the behavior and will become "afraid" of
>>>>> upgrading micro releases, although they definitely should do so to
>>>>> become the latest bug-fixes and get the security holes stuffed. But,
>>>>> since we've messed up this "concept" about 1k times for the 2.2.x
>>>>> branch anyhow I don't consider it a show stopper now; nevertheless we
>>>>> really should learn from this and do better for 2.3.x; I think this
>>>>> also includes opening 2.4.x the moment 2.3.0 is released to make sure
>>>>> that ppl have a place to include features/improvements and are not
>>>>> tempted to include them into micros; but this is a different story
>>>>> :-)
>>>>>
>>>>> Independently I've tested the latest release (src builds, notice
>>>>> checks, my applications, ...) and it looks really good to me.
>>>>>
>>>>> --> all in all +1 (binding) for the release.
>>>>>
>>>>> Kind regards,
>>>>> Andreas
>>>>>
>>>>> On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck
>>>>> <bc...@googlemail.com>
>>>>> wrote:
>>>>>> I second Guillaume here, we should be real careful not to add so
>>>>>> much
>>>>>> behavioral changes.
>>>>>>
>>>>>> regarding the release: +1
>>>>>>
>>>>>> regards, Achim
>>>>>>
>>>>>> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>>>>>>> Same feeling here, though I think we should learn from that and be
>>>>>>> more vigilant about not introducing new features or behavioral
>>>>>>> changes
>>>>>>> in micro releases, that should have been done in 2.3.
>>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos
>>>>>>> <io...@gmail.com>
>>>>>>> wrote:
>>>>>>>> Ideally, a micro release should guarantee forward and backward
>>>>>>>> compatibility.
>>>>>>>>
>>>>>>>> I'd say though that the particular issue doesn't sound like a show
>>>>>>>> stopper
>>>>>>>> to me.
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Ioannis Canellos*
>>>>>>>> *
>>>>>>>> FuseSource <http://fusesource.com>
>>>>>>>>
>>>>>>>> **
>>>>>>>> Blog: http://iocanel.blogspot.com
>>>>>>>> **
>>>>>>>> Twitter: iocanel
>>>>>>>> *
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> ------------------------
>>>>>>> Guillaume Nodet
>>>>>>> ------------------------
>>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>>> ------------------------
>>>>>>> FuseSource, Integration everywhere
>>>>>>> http://fusesource.com
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>>>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
>>>>>> Committer & Project Lead
>>>>>> OPS4J Pax for Vaadin
>>>>>> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter &
>>>>>> Project
>>>>>> Lead
>>>>>> blog <http://notizblog.nierbeck.de/>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>>>>
>>
>>
>
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Christian,
AFAIR, we discussed about that last year, when dealing about starting
Karaf 3.0.0 (I gonna looking for the thread in the archive).
First we "decided" to have:
- one maintenance branch (bug fixes) aka 2.2.x
- one dev trunk aka 3.0.x
2.3.x should have been created after 3.0.0, but we decided to create it
as a transition between 2.2.x and 2.3.x.
I will document that in a developer guide with the following table of
content:
- branches definition
- building
- style convention
- release guide
If all are OK, I will start that in the plane tomorrow morning.
Regards
JB
On 06/25/2012 08:53 PM, Christian Schneider wrote:
> Typically the number of parallel branches does not get too high anyway
> if we do not release that often.
> Still I think it makes sense to have at least an agreement to have for
> example 3 parallel branches like you proposed.
> So people know what to expect of us.
>
> Christian
>
> Am 25.06.2012 18:34, schrieb Andreas Pieber:
>> @JB np, it's always quite a hard balance between bug/behavior change
>>
>> @christian: I wont see this that hard; we support the last minor
>> release and done; this makes three branches we actively work on (e.g.
>> 2.3.x, 2.4.x and 3.x). If ppl need longer support they need to buy it
>> from one of the supporters (talend, fuse, ...) or provide the fixes
>> themselves. We just need to keep the bar between minors as low as
>> possible to make the upgrade quite easy. Keeping a detailed upgrade
>> page will also help. But I think thats it.
>>
>> Kind regards,
>> Andreas
>>
>> On Mon, Jun 25, 2012 at 6:05 PM, Jean-Baptiste Onofré
>> <jb...@nanthrax.net> wrote:
>>> I'm also agree. The change was not a new feature or an enhancement,
>>> it was a
>>> bug fix (as users reported). That's why I applied on 2.2.x branch,
>>> even if
>>> it was not very "clear".
>>>
>>> My apologies for that guys.
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 06/25/2012 03:49 PM, Andreas Pieber wrote:
>>>> I'm the third one backing Guillaume here. I've a strong negative
>>>> feeling about changing behavior in micro releases if it's not a VERY
>>>> critical bug. PPL adapt to the behavior and will become "afraid" of
>>>> upgrading micro releases, although they definitely should do so to
>>>> become the latest bug-fixes and get the security holes stuffed. But,
>>>> since we've messed up this "concept" about 1k times for the 2.2.x
>>>> branch anyhow I don't consider it a show stopper now; nevertheless we
>>>> really should learn from this and do better for 2.3.x; I think this
>>>> also includes opening 2.4.x the moment 2.3.0 is released to make sure
>>>> that ppl have a place to include features/improvements and are not
>>>> tempted to include them into micros; but this is a different story :-)
>>>>
>>>> Independently I've tested the latest release (src builds, notice
>>>> checks, my applications, ...) and it looks really good to me.
>>>>
>>>> --> all in all +1 (binding) for the release.
>>>>
>>>> Kind regards,
>>>> Andreas
>>>>
>>>> On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck
>>>> <bc...@googlemail.com>
>>>> wrote:
>>>>> I second Guillaume here, we should be real careful not to add so much
>>>>> behavioral changes.
>>>>>
>>>>> regarding the release: +1
>>>>>
>>>>> regards, Achim
>>>>>
>>>>> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>>>>>> Same feeling here, though I think we should learn from that and be
>>>>>> more vigilant about not introducing new features or behavioral
>>>>>> changes
>>>>>> in micro releases, that should have been done in 2.3.
>>>>>>
>>>>>> +1
>>>>>>
>>>>>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com>
>>>>>> wrote:
>>>>>>> Ideally, a micro release should guarantee forward and backward
>>>>>>> compatibility.
>>>>>>>
>>>>>>> I'd say though that the particular issue doesn't sound like a show
>>>>>>> stopper
>>>>>>> to me.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Ioannis Canellos*
>>>>>>> *
>>>>>>> FuseSource <http://fusesource.com>
>>>>>>>
>>>>>>> **
>>>>>>> Blog: http://iocanel.blogspot.com
>>>>>>> **
>>>>>>> Twitter: iocanel
>>>>>>> *
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> ------------------------
>>>>>> Guillaume Nodet
>>>>>> ------------------------
>>>>>> Blog: http://gnodet.blogspot.com/
>>>>>> ------------------------
>>>>>> FuseSource, Integration everywhere
>>>>>> http://fusesource.com
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
>>>>> Committer & Project Lead
>>>>> OPS4J Pax for Vaadin
>>>>> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
>>>>> Lead
>>>>> blog <http://notizblog.nierbeck.de/>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
>>>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Christian Schneider <ch...@die-schneider.net>.
Typically the number of parallel branches does not get too high anyway
if we do not release that often.
Still I think it makes sense to have at least an agreement to have for
example 3 parallel branches like you proposed.
So people know what to expect of us.
Christian
Am 25.06.2012 18:34, schrieb Andreas Pieber:
> @JB np, it's always quite a hard balance between bug/behavior change
>
> @christian: I wont see this that hard; we support the last minor
> release and done; this makes three branches we actively work on (e.g.
> 2.3.x, 2.4.x and 3.x). If ppl need longer support they need to buy it
> from one of the supporters (talend, fuse, ...) or provide the fixes
> themselves. We just need to keep the bar between minors as low as
> possible to make the upgrade quite easy. Keeping a detailed upgrade
> page will also help. But I think thats it.
>
> Kind regards,
> Andreas
>
> On Mon, Jun 25, 2012 at 6:05 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>> I'm also agree. The change was not a new feature or an enhancement, it was a
>> bug fix (as users reported). That's why I applied on 2.2.x branch, even if
>> it was not very "clear".
>>
>> My apologies for that guys.
>>
>> Regards
>> JB
>>
>>
>> On 06/25/2012 03:49 PM, Andreas Pieber wrote:
>>> I'm the third one backing Guillaume here. I've a strong negative
>>> feeling about changing behavior in micro releases if it's not a VERY
>>> critical bug. PPL adapt to the behavior and will become "afraid" of
>>> upgrading micro releases, although they definitely should do so to
>>> become the latest bug-fixes and get the security holes stuffed. But,
>>> since we've messed up this "concept" about 1k times for the 2.2.x
>>> branch anyhow I don't consider it a show stopper now; nevertheless we
>>> really should learn from this and do better for 2.3.x; I think this
>>> also includes opening 2.4.x the moment 2.3.0 is released to make sure
>>> that ppl have a place to include features/improvements and are not
>>> tempted to include them into micros; but this is a different story :-)
>>>
>>> Independently I've tested the latest release (src builds, notice
>>> checks, my applications, ...) and it looks really good to me.
>>>
>>> --> all in all +1 (binding) for the release.
>>>
>>> Kind regards,
>>> Andreas
>>>
>>> On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck <bc...@googlemail.com>
>>> wrote:
>>>> I second Guillaume here, we should be real careful not to add so much
>>>> behavioral changes.
>>>>
>>>> regarding the release: +1
>>>>
>>>> regards, Achim
>>>>
>>>> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>>>>> Same feeling here, though I think we should learn from that and be
>>>>> more vigilant about not introducing new features or behavioral changes
>>>>> in micro releases, that should have been done in 2.3.
>>>>>
>>>>> +1
>>>>>
>>>>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com>
>>>>> wrote:
>>>>>> Ideally, a micro release should guarantee forward and backward
>>>>>> compatibility.
>>>>>>
>>>>>> I'd say though that the particular issue doesn't sound like a show
>>>>>> stopper
>>>>>> to me.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Ioannis Canellos*
>>>>>> *
>>>>>> FuseSource <http://fusesource.com>
>>>>>>
>>>>>> **
>>>>>> Blog: http://iocanel.blogspot.com
>>>>>> **
>>>>>> Twitter: iocanel
>>>>>> *
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> ------------------------
>>>>> Guillaume Nodet
>>>>> ------------------------
>>>>> Blog: http://gnodet.blogspot.com/
>>>>> ------------------------
>>>>> FuseSource, Integration everywhere
>>>>> http://fusesource.com
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
>>>> Committer & Project Lead
>>>> OPS4J Pax for Vaadin
>>>> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
>>>> Lead
>>>> blog <http://notizblog.nierbeck.de/>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>>
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Andreas Pieber <an...@gmail.com>.
@JB np, it's always quite a hard balance between bug/behavior change
@christian: I wont see this that hard; we support the last minor
release and done; this makes three branches we actively work on (e.g.
2.3.x, 2.4.x and 3.x). If ppl need longer support they need to buy it
from one of the supporters (talend, fuse, ...) or provide the fixes
themselves. We just need to keep the bar between minors as low as
possible to make the upgrade quite easy. Keeping a detailed upgrade
page will also help. But I think thats it.
Kind regards,
Andreas
On Mon, Jun 25, 2012 at 6:05 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> I'm also agree. The change was not a new feature or an enhancement, it was a
> bug fix (as users reported). That's why I applied on 2.2.x branch, even if
> it was not very "clear".
>
> My apologies for that guys.
>
> Regards
> JB
>
>
> On 06/25/2012 03:49 PM, Andreas Pieber wrote:
>>
>> I'm the third one backing Guillaume here. I've a strong negative
>> feeling about changing behavior in micro releases if it's not a VERY
>> critical bug. PPL adapt to the behavior and will become "afraid" of
>> upgrading micro releases, although they definitely should do so to
>> become the latest bug-fixes and get the security holes stuffed. But,
>> since we've messed up this "concept" about 1k times for the 2.2.x
>> branch anyhow I don't consider it a show stopper now; nevertheless we
>> really should learn from this and do better for 2.3.x; I think this
>> also includes opening 2.4.x the moment 2.3.0 is released to make sure
>> that ppl have a place to include features/improvements and are not
>> tempted to include them into micros; but this is a different story :-)
>>
>> Independently I've tested the latest release (src builds, notice
>> checks, my applications, ...) and it looks really good to me.
>>
>> --> all in all +1 (binding) for the release.
>>
>> Kind regards,
>> Andreas
>>
>> On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck <bc...@googlemail.com>
>> wrote:
>>>
>>> I second Guillaume here, we should be real careful not to add so much
>>> behavioral changes.
>>>
>>> regarding the release: +1
>>>
>>> regards, Achim
>>>
>>> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>>>>
>>>> Same feeling here, though I think we should learn from that and be
>>>> more vigilant about not introducing new features or behavioral changes
>>>> in micro releases, that should have been done in 2.3.
>>>>
>>>> +1
>>>>
>>>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Ideally, a micro release should guarantee forward and backward
>>>>> compatibility.
>>>>>
>>>>> I'd say though that the particular issue doesn't sound like a show
>>>>> stopper
>>>>> to me.
>>>>>
>>>>>
>>>>> --
>>>>> *Ioannis Canellos*
>>>>> *
>>>>> FuseSource <http://fusesource.com>
>>>>>
>>>>> **
>>>>> Blog: http://iocanel.blogspot.com
>>>>> **
>>>>> Twitter: iocanel
>>>>> *
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> ------------------------
>>>> Guillaume Nodet
>>>> ------------------------
>>>> Blog: http://gnodet.blogspot.com/
>>>> ------------------------
>>>> FuseSource, Integration everywhere
>>>> http://fusesource.com
>>>
>>>
>>>
>>>
>>> --
>>>
>>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
>>> Committer & Project Lead
>>> OPS4J Pax for Vaadin
>>> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
>>> Lead
>>> blog <http://notizblog.nierbeck.de/>
>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
>
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
I'm also agree. The change was not a new feature or an enhancement, it
was a bug fix (as users reported). That's why I applied on 2.2.x branch,
even if it was not very "clear".
My apologies for that guys.
Regards
JB
On 06/25/2012 03:49 PM, Andreas Pieber wrote:
> I'm the third one backing Guillaume here. I've a strong negative
> feeling about changing behavior in micro releases if it's not a VERY
> critical bug. PPL adapt to the behavior and will become "afraid" of
> upgrading micro releases, although they definitely should do so to
> become the latest bug-fixes and get the security holes stuffed. But,
> since we've messed up this "concept" about 1k times for the 2.2.x
> branch anyhow I don't consider it a show stopper now; nevertheless we
> really should learn from this and do better for 2.3.x; I think this
> also includes opening 2.4.x the moment 2.3.0 is released to make sure
> that ppl have a place to include features/improvements and are not
> tempted to include them into micros; but this is a different story :-)
>
> Independently I've tested the latest release (src builds, notice
> checks, my applications, ...) and it looks really good to me.
>
> --> all in all +1 (binding) for the release.
>
> Kind regards,
> Andreas
>
> On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck <bc...@googlemail.com> wrote:
>> I second Guillaume here, we should be real careful not to add so much
>> behavioral changes.
>>
>> regarding the release: +1
>>
>> regards, Achim
>>
>> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>>> Same feeling here, though I think we should learn from that and be
>>> more vigilant about not introducing new features or behavioral changes
>>> in micro releases, that should have been done in 2.3.
>>>
>>> +1
>>>
>>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com> wrote:
>>>> Ideally, a micro release should guarantee forward and backward
>>>> compatibility.
>>>>
>>>> I'd say though that the particular issue doesn't sound like a show stopper
>>>> to me.
>>>>
>>>>
>>>> --
>>>> *Ioannis Canellos*
>>>> *
>>>> FuseSource <http://fusesource.com>
>>>>
>>>> **
>>>> Blog: http://iocanel.blogspot.com
>>>> **
>>>> Twitter: iocanel
>>>> *
>>>
>>>
>>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> FuseSource, Integration everywhere
>>> http://fusesource.com
>>
>>
>>
>> --
>>
>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
>> Committer & Project Lead
>> OPS4J Pax for Vaadin
>> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
>> Lead
>> blog <http://notizblog.nierbeck.de/>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Christian Schneider <ch...@die-schneider.net>.
+1 For making Micro Releases pure bug fix releases.
We should keep in mind though that each Minor release will then mean we
have to support one more branch.
So we should make sure we support only a certain number of branches at
the same time and support each branch for a minimum time like e.g. one
year. If these numbers were not already decided we should discuss and
decide them in a separate thread.
Christian
Am 25.06.2012 09:14, schrieb Guillaume Nodet:
> Same feeling here, though I think we should learn from that and be
> more vigilant about not introducing new features or behavioral changes
> in micro releases, that should have been done in 2.3.
>
> +1
>
> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com> wrote:
>> Ideally, a micro release should guarantee forward and backward
>> compatibility.
>>
>> I'd say though that the particular issue doesn't sound like a show stopper
>> to me.
>>
>>
>> --
>> *Ioannis Canellos*
>> *
>> FuseSource <http://fusesource.com>
>>
>> **
>> Blog: http://iocanel.blogspot.com
>> **
>> Twitter: iocanel
>> *
>
>
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by "Jamie G." <ja...@gmail.com>.
+1 on the 2.4.x comment - we really should make creating branches a
more common event than it's been on the 2.2.x series.
Cheers,
Jamie
On Mon, Jun 25, 2012 at 11:19 AM, Andreas Pieber <an...@gmail.com> wrote:
> I'm the third one backing Guillaume here. I've a strong negative
> feeling about changing behavior in micro releases if it's not a VERY
> critical bug. PPL adapt to the behavior and will become "afraid" of
> upgrading micro releases, although they definitely should do so to
> become the latest bug-fixes and get the security holes stuffed. But,
> since we've messed up this "concept" about 1k times for the 2.2.x
> branch anyhow I don't consider it a show stopper now; nevertheless we
> really should learn from this and do better for 2.3.x; I think this
> also includes opening 2.4.x the moment 2.3.0 is released to make sure
> that ppl have a place to include features/improvements and are not
> tempted to include them into micros; but this is a different story :-)
>
> Independently I've tested the latest release (src builds, notice
> checks, my applications, ...) and it looks really good to me.
>
> --> all in all +1 (binding) for the release.
>
> Kind regards,
> Andreas
>
> On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck <bc...@googlemail.com> wrote:
>> I second Guillaume here, we should be real careful not to add so much
>> behavioral changes.
>>
>> regarding the release: +1
>>
>> regards, Achim
>>
>> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>>> Same feeling here, though I think we should learn from that and be
>>> more vigilant about not introducing new features or behavioral changes
>>> in micro releases, that should have been done in 2.3.
>>>
>>> +1
>>>
>>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com> wrote:
>>>> Ideally, a micro release should guarantee forward and backward
>>>> compatibility.
>>>>
>>>> I'd say though that the particular issue doesn't sound like a show stopper
>>>> to me.
>>>>
>>>>
>>>> --
>>>> *Ioannis Canellos*
>>>> *
>>>> FuseSource <http://fusesource.com>
>>>>
>>>> **
>>>> Blog: http://iocanel.blogspot.com
>>>> **
>>>> Twitter: iocanel
>>>> *
>>>
>>>
>>>
>>> --
>>> ------------------------
>>> Guillaume Nodet
>>> ------------------------
>>> Blog: http://gnodet.blogspot.com/
>>> ------------------------
>>> FuseSource, Integration everywhere
>>> http://fusesource.com
>>
>>
>>
>> --
>>
>> Apache Karaf <http://karaf.apache.org/> Committer & PMC
>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
>> Committer & Project Lead
>> OPS4J Pax for Vaadin
>> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
>> Lead
>> blog <http://notizblog.nierbeck.de/>
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Andreas Pieber <an...@gmail.com>.
I'm the third one backing Guillaume here. I've a strong negative
feeling about changing behavior in micro releases if it's not a VERY
critical bug. PPL adapt to the behavior and will become "afraid" of
upgrading micro releases, although they definitely should do so to
become the latest bug-fixes and get the security holes stuffed. But,
since we've messed up this "concept" about 1k times for the 2.2.x
branch anyhow I don't consider it a show stopper now; nevertheless we
really should learn from this and do better for 2.3.x; I think this
also includes opening 2.4.x the moment 2.3.0 is released to make sure
that ppl have a place to include features/improvements and are not
tempted to include them into micros; but this is a different story :-)
Independently I've tested the latest release (src builds, notice
checks, my applications, ...) and it looks really good to me.
--> all in all +1 (binding) for the release.
Kind regards,
Andreas
On Mon, Jun 25, 2012 at 3:36 PM, Achim Nierbeck <bc...@googlemail.com> wrote:
> I second Guillaume here, we should be real careful not to add so much
> behavioral changes.
>
> regarding the release: +1
>
> regards, Achim
>
> 2012/6/25 Guillaume Nodet <gn...@gmail.com>:
>> Same feeling here, though I think we should learn from that and be
>> more vigilant about not introducing new features or behavioral changes
>> in micro releases, that should have been done in 2.3.
>>
>> +1
>>
>> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com> wrote:
>>> Ideally, a micro release should guarantee forward and backward
>>> compatibility.
>>>
>>> I'd say though that the particular issue doesn't sound like a show stopper
>>> to me.
>>>
>>>
>>> --
>>> *Ioannis Canellos*
>>> *
>>> FuseSource <http://fusesource.com>
>>>
>>> **
>>> Blog: http://iocanel.blogspot.com
>>> **
>>> Twitter: iocanel
>>> *
>>
>>
>>
>> --
>> ------------------------
>> Guillaume Nodet
>> ------------------------
>> Blog: http://gnodet.blogspot.com/
>> ------------------------
>> FuseSource, Integration everywhere
>> http://fusesource.com
>
>
>
> --
>
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
> Committer & Project Lead
> OPS4J Pax for Vaadin
> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
> Lead
> blog <http://notizblog.nierbeck.de/>
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Achim Nierbeck <bc...@googlemail.com>.
I second Guillaume here, we should be real careful not to add so much
behavioral changes.
regarding the release: +1
regards, Achim
2012/6/25 Guillaume Nodet <gn...@gmail.com>:
> Same feeling here, though I think we should learn from that and be
> more vigilant about not introducing new features or behavioral changes
> in micro releases, that should have been done in 2.3.
>
> +1
>
> On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com> wrote:
>> Ideally, a micro release should guarantee forward and backward
>> compatibility.
>>
>> I'd say though that the particular issue doesn't sound like a show stopper
>> to me.
>>
>>
>> --
>> *Ioannis Canellos*
>> *
>> FuseSource <http://fusesource.com>
>>
>> **
>> Blog: http://iocanel.blogspot.com
>> **
>> Twitter: iocanel
>> *
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> FuseSource, Integration everywhere
> http://fusesource.com
--
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
OPS4J Pax for Vaadin
<http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
Lead
blog <http://notizblog.nierbeck.de/>
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Guillaume Nodet <gn...@gmail.com>.
Same feeling here, though I think we should learn from that and be
more vigilant about not introducing new features or behavioral changes
in micro releases, that should have been done in 2.3.
+1
On Sun, Jun 24, 2012 at 3:14 PM, Ioannis Canellos <io...@gmail.com> wrote:
> Ideally, a micro release should guarantee forward and backward
> compatibility.
>
> I'd say though that the particular issue doesn't sound like a show stopper
> to me.
>
>
> --
> *Ioannis Canellos*
> *
> FuseSource <http://fusesource.com>
>
> **
> Blog: http://iocanel.blogspot.com
> **
> Twitter: iocanel
> *
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Freeman Fang <fr...@gmail.com>.
Not a show stopper for me.
Here is my +1
Freeman
On 2012-6-25, at 上午2:46, Jamie G. wrote:
> I'm going to extend this vote by 24 hours so that more people may have
> a chance to respond to it (considering this is the weekend and all).
>
> Cheers,
> Jamie
>
> On Sun, Jun 24, 2012 at 7:14 AM, Ioannis Canellos
> <io...@gmail.com> wrote:
>> Ideally, a micro release should guarantee forward and backward
>> compatibility.
>>
>> I'd say though that the particular issue doesn't sound like a show
>> stopper
>> to me.
>>
>>
>> --
>> *Ioannis Canellos*
>> *
>> FuseSource <http://fusesource.com>
>>
>> **
>> Blog: http://iocanel.blogspot.com
>> **
>> Twitter: iocanel
>> *
---------------------------------------------
Freeman Fang
FuseSource
Email:ffang@fusesource.com
Web: fusesource.com
Twitter: freemanfang
Blog: http://freemanfang.blogspot.com
http://blog.sina.com.cn/u/1473905042
weibo: http://weibo.com/u/1473905042
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by "Jamie G." <ja...@gmail.com>.
I'm going to extend this vote by 24 hours so that more people may have
a chance to respond to it (considering this is the weekend and all).
Cheers,
Jamie
On Sun, Jun 24, 2012 at 7:14 AM, Ioannis Canellos <io...@gmail.com> wrote:
> Ideally, a micro release should guarantee forward and backward
> compatibility.
>
> I'd say though that the particular issue doesn't sound like a show stopper
> to me.
>
>
> --
> *Ioannis Canellos*
> *
> FuseSource <http://fusesource.com>
>
> **
> Blog: http://iocanel.blogspot.com
> **
> Twitter: iocanel
> *
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Ioannis Canellos <io...@gmail.com>.
Ideally, a micro release should guarantee forward and backward
compatibility.
I'd say though that the particular issue doesn't sound like a show stopper
to me.
--
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>
**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by "Jamie G." <ja...@gmail.com>.
I'm in agreement with JB. I'd like to hear some other opinions on the
matter though before I bring this voting period to an end.
My +1.
Cheers,
Jamie
On Thu, Jun 21, 2012 at 10:56 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> As you use KarArtifactInstaller directly in your code, I think it makes
> sense that you have to adapt your code.
>
> For instance, upgrading from sshd 0.6.0 to 0.7.0 required some changes in
> the code (as we use "low level" layer).
>
> IMHO, it's not blocker for 2.2.8 release.
>
> Let see what the others think.
>
> Regards
> JB
>
>
> On 06/21/2012 11:20 PM, Dan Tran wrote:
>>
>> I would be nice to revert KARAF-1392, where the install's behavior has
>> changed. and move it to 2.3+ branch
>>
>> However it is up for debate from dev team
>>
>> Since I am directly invoke the karInstaller and heavily depends on its
>> internal behavior, so I guess it is my responsibility to adapt to the
>> changes
>>
>> At this moment, i dont have anything to change for KarArtifactInstaller
>> yet.
>>
>> Thank you
>>
>> -Dan
>>
>>
>>
>> On Thu, Jun 21, 2012 at 1:57 PM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>>
>>> Hi Dan,
>>>
>>> Do you consider that something has to be change in the
>>> KarArtifactInstaller
>>> (or so do you think we should cancel this release) ?
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 06/21/2012 10:54 PM, Dan Tran wrote:
>>>>
>>>>
>>>> I will go ahead to fix this at my end to call 'install()' first to
>>>> copy kar file to where karaf expected, any perhaps use the
>>>> karinstaller service directly since it is exposed a a service.
>>>>
>>>> Thanks
>>>>
>>>>
>>>>
>>>> On Thu, Jun 21, 2012 at 9:12 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>> wrote:
>>>>>
>>>>>
>>>>> OK got it.
>>>>>
>>>>> Just background: before 2.2.8, the KarArtifactInstaller only install
>>>>> kar
>>>>> (install(File) method), and doesn't nothing during uninstall().
>>>>>
>>>>> As the kar artifact installer installs all features contained in the
>>>>> kar,
>>>>> lot of users mentionned that it appears as a bug that the kar artifact
>>>>> install doesn't uninstall the features removing the kar file.
>>>>>
>>>>> So to uninstall all features from a kar file, I can work (looking for
>>>>> the
>>>>> features XML in the zip file) on the "original" kar file during
>>>>> uninstall(File) as the file is already removed.
>>>>> So we copy the kar file into the local repo during install:
>>>>>
>>>>> File karFile = new File(localRepoPath, file.getName());
>>>>> copy(file.toURI(), karFile);
>>>>>
>>>>> Like this, at uninstall, we can get back the original kar to looking
>>>>> for
>>>>> features:
>>>>>
>>>>> File karFile = new File(localRepoPath, file.getName());
>>>>>
>>>>> So, that's why the kar file is in localRepo.
>>>>>
>>>>> So it doesn't assume that you place the kar file in localRepo, during
>>>>> the
>>>>> install method, the karArtifactInstaller should copy the file from the
>>>>> location in argument into the localRepo.
>>>>>
>>>>> Could you provide a quick test case to reproduce your issue ?
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>>
>>>>> On 06/21/2012 05:51 PM, Dan Tran wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> No, infact under karaf2.2.7, it behaves correctly and unpacks my kar
>>>>>> file where I ask it to ( ie localRepoPath )
>>>>>>
>>>>>> in 2.2.8, it still behaves correctly by unpack under localRepoPath,
>>>>>> but looks for the kar file at the wrong place. It assumes I must
>>>>>> place my karFile under localRepoPath, and ignore the full path i pass
>>>>>> into the 'update' method
>>>>>>
>>>>>> -Dan
>>>>>>
>>>>>> On Thu, Jun 21, 2012 at 8:42 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> You mean that your karArtifactInstaller ignores the basePath and
>>>>>>> localRepoPath ?
>>>>>>>
>>>>>>> Regards
>>>>>>> JB
>>>>>>>
>>>>>>>
>>>>>>> On 06/21/2012 05:08 PM, Dan Tran wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> I think I found the root cause, we spin our own KarArtifactInstaller
>>>>>>>> since karaf 2.0.x does not expose it as a service
>>>>>>>>
>>>>>>>> <bean id="karArtifactInstaller"
>>>>>>>> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
>>>>>>>> init-method="init" destroy-method="destroy" activation="lazy">
>>>>>>>> <property name="basePath" value="$[karaf.base]" />
>>>>>>>> <property name="localRepoPath" value="$[karaf.base]/local-repo"
>>>>>>>> />
>>>>>>>> <property name="featuresService">
>>>>>>>> <reference
>>>>>>>> interface="org.apache.karaf.features.FeaturesService"
>>>>>>>> />
>>>>>>>> </property>
>>>>>>>> </bean>
>>>>>>>>
>>>>>>>> Here is reference to karaf team on why we spin our own service bean
>>>>>>>>
>>>>>>>> https://issues.apache.org/jira/browse/KARAF-656
>>>>>>>>
>>>>>>>> However I still it is a bug since I ask the service to look for my
>>>>>>>> file at a certain location, but the it looks somewhere else.
>>>>>>>>
>>>>>>>> Big thanks
>>>>>>>>
>>>>>>>> -Dan
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste
>>>>>>>> Onofré<jb...@nanthrax.net>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi Dan,
>>>>>>>>>
>>>>>>>>> Just to clearly understand.
>>>>>>>>>
>>>>>>>>> The update() method calls install(). So it means that:
>>>>>>>>>
>>>>>>>>> - you should see the feature.kar in the repo. This repo is set by
>>>>>>>>> the
>>>>>>>>> localRepoPath attribute (target/local-repo in the class, injected
>>>>>>>>> to
>>>>>>>>> ${karaf.base}/system by the blueprint descriptor). So, could you
>>>>>>>>> check
>>>>>>>>> if
>>>>>>>>> you have the feature.kar in system ?
>>>>>>>>> - FeaturesService.install() is not necessary as the
>>>>>>>>> KarArtifactInstaller
>>>>>>>>> install all features contained in kar files automatically.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> JB
>>>>>>>>>
>>>>>>>>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> long story,
>>>>>>>>>>
>>>>>>>>>> We have our own custom kar deployer where we directly use
>>>>>>>>>> KarArtifactInstaller as a service to deploy our feature kar file
>>>>>>>>>> and
>>>>>>>>>> we dont place our kar file under karaf's deploy directory )
>>>>>>>>>>
>>>>>>>>>> Here is pseudo code
>>>>>>>>>>
>>>>>>>>>> // Call kar deployer to unpack in karaf local-repo
>>>>>>>>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>>>>>>>>
>>>>>>>>>> //use featureService to deploy the feature
>>>>>>>>>> FeaturesService.install (... )
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> As I have stated before, the first call throws
>>>>>>>>>> FileNotFoundException
>>>>>>>>>> since it could not find my 'feature.kar' under
>>>>>>>>>> karaf.base/local-repo.
>>>>>>>>>> Strange??
>>>>>>>>>>
>>>>>>>>>> how er if I also place another copy of my 'feature.kar' file
>>>>>>>>>> under
>>>>>>>>>> karaf's local-repo directory, the same
>>>>>>>>>> KarArtifactInstaller.update(
>>>>>>>>>> File path/to/our/feature.kar ) is happy and unpack under
>>>>>>>>>> local-repo.
>>>>>>>>>> Strange??
>>>>>>>>>>
>>>>>>>>>> Thanks for looking into this
>>>>>>>>>>
>>>>>>>>>> -D
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste
>>>>>>>>>> Onofré<jb...@nanthrax.net>
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Just to understand your issue, the kar deployer behavior is quite
>>>>>>>>>>> the
>>>>>>>>>>> same:
>>>>>>>>>>> - you put the kar file in the deploy folder
>>>>>>>>>>> - the kar is uncompress (previously it was uncompress in
>>>>>>>>>>> local-repo,
>>>>>>>>>>> now
>>>>>>>>>>> it's uncompress in system repo)
>>>>>>>>>>> - all features contained in the kar are automatically installed
>>>>>>>>>>> - now, if you remove the kar file, the kar deployer is able to
>>>>>>>>>>> uninstall
>>>>>>>>>>> all
>>>>>>>>>>> features and remove the kar file
>>>>>>>>>>>
>>>>>>>>>>> So, even if the storage changed from local-repo to system, the
>>>>>>>>>>> behavior
>>>>>>>>>>> is
>>>>>>>>>>> the same.
>>>>>>>>>>>
>>>>>>>>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>> JB
>>>>>>>>>>>
>>>>>>>>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Hello Karaf devs,
>>>>>>>>>>>>
>>>>>>>>>>>> regresion in KarArtifactInstaller service?
>>>>>>>>>>>>
>>>>>>>>>>>> in karaf-2.2.7,
>>>>>>>>>>>>
>>>>>>>>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks
>>>>>>>>>>>> my
>>>>>>>>>>>> 'myfeature.jar' under local-repo
>>>>>>>>>>>>
>>>>>>>>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>>>>>>>>> local-repo/myfeature.kar?
>>>>>>>>>>>>
>>>>>>>>>>>> is it expected? This changes breaks my custom deployment.
>>>>>>>>>>>>
>>>>>>>>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I
>>>>>>>>>>>> would
>>>>>>>>>>>> like to continue upgrading to latest 2.2.x code without changing
>>>>>>>>>>>> my
>>>>>>>>>>>> code.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks
>>>>>>>>>>>>
>>>>>>>>>>>> -Dan
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain
>>>>>>>>>>>> Gilles<ro...@gmail.com>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> +1
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks a lot.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Romain
>>>>>>>>>>>>>
>>>>>>>>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> +1 (binding)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> First tests passed without problem, I will test with Cellar,
>>>>>>>>>>>>>> etc
>>>>>>>>>>>>>> tomorrow
>>>>>>>>>>>>>> morning, but it looks good to me.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Regards
>>>>>>>>>>>>>> JB
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> We resolved 28 issues in this release (web page will be
>>>>>>>>>>>>>>> published
>>>>>>>>>>>>>>> post
>>>>>>>>>>>>>>> RC promotion):
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Staging repository:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Release tags:
>>>>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Please vote to approve this release:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> [ ] +1 Approve the release
>>>>>>>>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>>>>>> jbonofre@apache.org
>>>>>>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>>> jbonofre@apache.org
>>>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>> jbonofre@apache.org
>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>> Talend - http://www.talend.com
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Jean-Baptiste Onofré
>>>>>>> jbonofre@apache.org
>>>>>>> http://blog.nanthrax.net
>>>>>>> Talend - http://www.talend.com
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Jean-Baptiste Onofré
>>>>> jbonofre@apache.org
>>>>> http://blog.nanthrax.net
>>>>> Talend - http://www.talend.com
>>>
>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
As you use KarArtifactInstaller directly in your code, I think it makes
sense that you have to adapt your code.
For instance, upgrading from sshd 0.6.0 to 0.7.0 required some changes
in the code (as we use "low level" layer).
IMHO, it's not blocker for 2.2.8 release.
Let see what the others think.
Regards
JB
On 06/21/2012 11:20 PM, Dan Tran wrote:
> I would be nice to revert KARAF-1392, where the install's behavior has
> changed. and move it to 2.3+ branch
>
> However it is up for debate from dev team
>
> Since I am directly invoke the karInstaller and heavily depends on its
> internal behavior, so I guess it is my responsibility to adapt to the
> changes
>
> At this moment, i dont have anything to change for KarArtifactInstaller yet.
>
> Thank you
>
> -Dan
>
>
>
> On Thu, Jun 21, 2012 at 1:57 PM, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>> Hi Dan,
>>
>> Do you consider that something has to be change in the KarArtifactInstaller
>> (or so do you think we should cancel this release) ?
>>
>> Regards
>> JB
>>
>>
>> On 06/21/2012 10:54 PM, Dan Tran wrote:
>>>
>>> I will go ahead to fix this at my end to call 'install()' first to
>>> copy kar file to where karaf expected, any perhaps use the
>>> karinstaller service directly since it is exposed a a service.
>>>
>>> Thanks
>>>
>>>
>>>
>>> On Thu, Jun 21, 2012 at 9:12 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>> wrote:
>>>>
>>>> OK got it.
>>>>
>>>> Just background: before 2.2.8, the KarArtifactInstaller only install kar
>>>> (install(File) method), and doesn't nothing during uninstall().
>>>>
>>>> As the kar artifact installer installs all features contained in the kar,
>>>> lot of users mentionned that it appears as a bug that the kar artifact
>>>> install doesn't uninstall the features removing the kar file.
>>>>
>>>> So to uninstall all features from a kar file, I can work (looking for the
>>>> features XML in the zip file) on the "original" kar file during
>>>> uninstall(File) as the file is already removed.
>>>> So we copy the kar file into the local repo during install:
>>>>
>>>> File karFile = new File(localRepoPath, file.getName());
>>>> copy(file.toURI(), karFile);
>>>>
>>>> Like this, at uninstall, we can get back the original kar to looking for
>>>> features:
>>>>
>>>> File karFile = new File(localRepoPath, file.getName());
>>>>
>>>> So, that's why the kar file is in localRepo.
>>>>
>>>> So it doesn't assume that you place the kar file in localRepo, during the
>>>> install method, the karArtifactInstaller should copy the file from the
>>>> location in argument into the localRepo.
>>>>
>>>> Could you provide a quick test case to reproduce your issue ?
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 06/21/2012 05:51 PM, Dan Tran wrote:
>>>>>
>>>>>
>>>>> No, infact under karaf2.2.7, it behaves correctly and unpacks my kar
>>>>> file where I ask it to ( ie localRepoPath )
>>>>>
>>>>> in 2.2.8, it still behaves correctly by unpack under localRepoPath,
>>>>> but looks for the kar file at the wrong place. It assumes I must
>>>>> place my karFile under localRepoPath, and ignore the full path i pass
>>>>> into the 'update' method
>>>>>
>>>>> -Dan
>>>>>
>>>>> On Thu, Jun 21, 2012 at 8:42 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> You mean that your karArtifactInstaller ignores the basePath and
>>>>>> localRepoPath ?
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>>
>>>>>> On 06/21/2012 05:08 PM, Dan Tran wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> I think I found the root cause, we spin our own KarArtifactInstaller
>>>>>>> since karaf 2.0.x does not expose it as a service
>>>>>>>
>>>>>>> <bean id="karArtifactInstaller"
>>>>>>> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
>>>>>>> init-method="init" destroy-method="destroy" activation="lazy">
>>>>>>> <property name="basePath" value="$[karaf.base]" />
>>>>>>> <property name="localRepoPath" value="$[karaf.base]/local-repo" />
>>>>>>> <property name="featuresService">
>>>>>>> <reference interface="org.apache.karaf.features.FeaturesService"
>>>>>>> />
>>>>>>> </property>
>>>>>>> </bean>
>>>>>>>
>>>>>>> Here is reference to karaf team on why we spin our own service bean
>>>>>>>
>>>>>>> https://issues.apache.org/jira/browse/KARAF-656
>>>>>>>
>>>>>>> However I still it is a bug since I ask the service to look for my
>>>>>>> file at a certain location, but the it looks somewhere else.
>>>>>>>
>>>>>>> Big thanks
>>>>>>>
>>>>>>> -Dan
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Hi Dan,
>>>>>>>>
>>>>>>>> Just to clearly understand.
>>>>>>>>
>>>>>>>> The update() method calls install(). So it means that:
>>>>>>>>
>>>>>>>> - you should see the feature.kar in the repo. This repo is set by the
>>>>>>>> localRepoPath attribute (target/local-repo in the class, injected to
>>>>>>>> ${karaf.base}/system by the blueprint descriptor). So, could you
>>>>>>>> check
>>>>>>>> if
>>>>>>>> you have the feature.kar in system ?
>>>>>>>> - FeaturesService.install() is not necessary as the
>>>>>>>> KarArtifactInstaller
>>>>>>>> install all features contained in kar files automatically.
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> JB
>>>>>>>>
>>>>>>>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> long story,
>>>>>>>>>
>>>>>>>>> We have our own custom kar deployer where we directly use
>>>>>>>>> KarArtifactInstaller as a service to deploy our feature kar file and
>>>>>>>>> we dont place our kar file under karaf's deploy directory )
>>>>>>>>>
>>>>>>>>> Here is pseudo code
>>>>>>>>>
>>>>>>>>> // Call kar deployer to unpack in karaf local-repo
>>>>>>>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>>>>>>>
>>>>>>>>> //use featureService to deploy the feature
>>>>>>>>> FeaturesService.install (... )
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> As I have stated before, the first call throws FileNotFoundException
>>>>>>>>> since it could not find my 'feature.kar' under
>>>>>>>>> karaf.base/local-repo.
>>>>>>>>> Strange??
>>>>>>>>>
>>>>>>>>> how er if I also place another copy of my 'feature.kar' file under
>>>>>>>>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>>>>>>>>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>>>>>>>>> Strange??
>>>>>>>>>
>>>>>>>>> Thanks for looking into this
>>>>>>>>>
>>>>>>>>> -D
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste
>>>>>>>>> Onofré<jb...@nanthrax.net>
>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Just to understand your issue, the kar deployer behavior is quite
>>>>>>>>>> the
>>>>>>>>>> same:
>>>>>>>>>> - you put the kar file in the deploy folder
>>>>>>>>>> - the kar is uncompress (previously it was uncompress in
>>>>>>>>>> local-repo,
>>>>>>>>>> now
>>>>>>>>>> it's uncompress in system repo)
>>>>>>>>>> - all features contained in the kar are automatically installed
>>>>>>>>>> - now, if you remove the kar file, the kar deployer is able to
>>>>>>>>>> uninstall
>>>>>>>>>> all
>>>>>>>>>> features and remove the kar file
>>>>>>>>>>
>>>>>>>>>> So, even if the storage changed from local-repo to system, the
>>>>>>>>>> behavior
>>>>>>>>>> is
>>>>>>>>>> the same.
>>>>>>>>>>
>>>>>>>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>> JB
>>>>>>>>>>
>>>>>>>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Hello Karaf devs,
>>>>>>>>>>>
>>>>>>>>>>> regresion in KarArtifactInstaller service?
>>>>>>>>>>>
>>>>>>>>>>> in karaf-2.2.7,
>>>>>>>>>>>
>>>>>>>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>>>>>>>>> 'myfeature.jar' under local-repo
>>>>>>>>>>>
>>>>>>>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>>>>>>>> local-repo/myfeature.kar?
>>>>>>>>>>>
>>>>>>>>>>> is it expected? This changes breaks my custom deployment.
>>>>>>>>>>>
>>>>>>>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I
>>>>>>>>>>> would
>>>>>>>>>>> like to continue upgrading to latest 2.2.x code without changing
>>>>>>>>>>> my
>>>>>>>>>>> code.
>>>>>>>>>>>
>>>>>>>>>>> Thanks
>>>>>>>>>>>
>>>>>>>>>>> -Dan
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain
>>>>>>>>>>> Gilles<ro...@gmail.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> +1
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks a lot.
>>>>>>>>>>>>
>>>>>>>>>>>> Romain
>>>>>>>>>>>>
>>>>>>>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>>>>>>>
>>>>>>>>>>>>> +1 (binding)
>>>>>>>>>>>>>
>>>>>>>>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>>>>>>>>> tomorrow
>>>>>>>>>>>>> morning, but it looks good to me.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards
>>>>>>>>>>>>> JB
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> We resolved 28 issues in this release (web page will be
>>>>>>>>>>>>>> published
>>>>>>>>>>>>>> post
>>>>>>>>>>>>>> RC promotion):
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Staging repository:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Release tags:
>>>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Please vote to approve this release:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> [ ] +1 Approve the release
>>>>>>>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>>>>> jbonofre@apache.org
>>>>>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>> jbonofre@apache.org
>>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Jean-Baptiste Onofré
>>>>>>>> jbonofre@apache.org
>>>>>>>> http://blog.nanthrax.net
>>>>>>>> Talend - http://www.talend.com
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Jean-Baptiste Onofré
>>>>>> jbonofre@apache.org
>>>>>> http://blog.nanthrax.net
>>>>>> Talend - http://www.talend.com
>>>>
>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Dan Tran <da...@gmail.com>.
I would be nice to revert KARAF-1392, where the install's behavior has
changed. and move it to 2.3+ branch
However it is up for debate from dev team
Since I am directly invoke the karInstaller and heavily depends on its
internal behavior, so I guess it is my responsibility to adapt to the
changes
At this moment, i dont have anything to change for KarArtifactInstaller yet.
Thank you
-Dan
On Thu, Jun 21, 2012 at 1:57 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi Dan,
>
> Do you consider that something has to be change in the KarArtifactInstaller
> (or so do you think we should cancel this release) ?
>
> Regards
> JB
>
>
> On 06/21/2012 10:54 PM, Dan Tran wrote:
>>
>> I will go ahead to fix this at my end to call 'install()' first to
>> copy kar file to where karaf expected, any perhaps use the
>> karinstaller service directly since it is exposed a a service.
>>
>> Thanks
>>
>>
>>
>> On Thu, Jun 21, 2012 at 9:12 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>>
>>> OK got it.
>>>
>>> Just background: before 2.2.8, the KarArtifactInstaller only install kar
>>> (install(File) method), and doesn't nothing during uninstall().
>>>
>>> As the kar artifact installer installs all features contained in the kar,
>>> lot of users mentionned that it appears as a bug that the kar artifact
>>> install doesn't uninstall the features removing the kar file.
>>>
>>> So to uninstall all features from a kar file, I can work (looking for the
>>> features XML in the zip file) on the "original" kar file during
>>> uninstall(File) as the file is already removed.
>>> So we copy the kar file into the local repo during install:
>>>
>>> File karFile = new File(localRepoPath, file.getName());
>>> copy(file.toURI(), karFile);
>>>
>>> Like this, at uninstall, we can get back the original kar to looking for
>>> features:
>>>
>>> File karFile = new File(localRepoPath, file.getName());
>>>
>>> So, that's why the kar file is in localRepo.
>>>
>>> So it doesn't assume that you place the kar file in localRepo, during the
>>> install method, the karArtifactInstaller should copy the file from the
>>> location in argument into the localRepo.
>>>
>>> Could you provide a quick test case to reproduce your issue ?
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 06/21/2012 05:51 PM, Dan Tran wrote:
>>>>
>>>>
>>>> No, infact under karaf2.2.7, it behaves correctly and unpacks my kar
>>>> file where I ask it to ( ie localRepoPath )
>>>>
>>>> in 2.2.8, it still behaves correctly by unpack under localRepoPath,
>>>> but looks for the kar file at the wrong place. It assumes I must
>>>> place my karFile under localRepoPath, and ignore the full path i pass
>>>> into the 'update' method
>>>>
>>>> -Dan
>>>>
>>>> On Thu, Jun 21, 2012 at 8:42 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>> wrote:
>>>>>
>>>>>
>>>>> You mean that your karArtifactInstaller ignores the basePath and
>>>>> localRepoPath ?
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>>
>>>>> On 06/21/2012 05:08 PM, Dan Tran wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> I think I found the root cause, we spin our own KarArtifactInstaller
>>>>>> since karaf 2.0.x does not expose it as a service
>>>>>>
>>>>>> <bean id="karArtifactInstaller"
>>>>>> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
>>>>>> init-method="init" destroy-method="destroy" activation="lazy">
>>>>>> <property name="basePath" value="$[karaf.base]" />
>>>>>> <property name="localRepoPath" value="$[karaf.base]/local-repo" />
>>>>>> <property name="featuresService">
>>>>>> <reference interface="org.apache.karaf.features.FeaturesService"
>>>>>> />
>>>>>> </property>
>>>>>> </bean>
>>>>>>
>>>>>> Here is reference to karaf team on why we spin our own service bean
>>>>>>
>>>>>> https://issues.apache.org/jira/browse/KARAF-656
>>>>>>
>>>>>> However I still it is a bug since I ask the service to look for my
>>>>>> file at a certain location, but the it looks somewhere else.
>>>>>>
>>>>>> Big thanks
>>>>>>
>>>>>> -Dan
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Hi Dan,
>>>>>>>
>>>>>>> Just to clearly understand.
>>>>>>>
>>>>>>> The update() method calls install(). So it means that:
>>>>>>>
>>>>>>> - you should see the feature.kar in the repo. This repo is set by the
>>>>>>> localRepoPath attribute (target/local-repo in the class, injected to
>>>>>>> ${karaf.base}/system by the blueprint descriptor). So, could you
>>>>>>> check
>>>>>>> if
>>>>>>> you have the feature.kar in system ?
>>>>>>> - FeaturesService.install() is not necessary as the
>>>>>>> KarArtifactInstaller
>>>>>>> install all features contained in kar files automatically.
>>>>>>>
>>>>>>>
>>>>>>> Regards
>>>>>>> JB
>>>>>>>
>>>>>>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> long story,
>>>>>>>>
>>>>>>>> We have our own custom kar deployer where we directly use
>>>>>>>> KarArtifactInstaller as a service to deploy our feature kar file and
>>>>>>>> we dont place our kar file under karaf's deploy directory )
>>>>>>>>
>>>>>>>> Here is pseudo code
>>>>>>>>
>>>>>>>> // Call kar deployer to unpack in karaf local-repo
>>>>>>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>>>>>>
>>>>>>>> //use featureService to deploy the feature
>>>>>>>> FeaturesService.install (... )
>>>>>>>>
>>>>>>>>
>>>>>>>> As I have stated before, the first call throws FileNotFoundException
>>>>>>>> since it could not find my 'feature.kar' under
>>>>>>>> karaf.base/local-repo.
>>>>>>>> Strange??
>>>>>>>>
>>>>>>>> how er if I also place another copy of my 'feature.kar' file under
>>>>>>>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>>>>>>>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>>>>>>>> Strange??
>>>>>>>>
>>>>>>>> Thanks for looking into this
>>>>>>>>
>>>>>>>> -D
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste
>>>>>>>> Onofré<jb...@nanthrax.net>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Just to understand your issue, the kar deployer behavior is quite
>>>>>>>>> the
>>>>>>>>> same:
>>>>>>>>> - you put the kar file in the deploy folder
>>>>>>>>> - the kar is uncompress (previously it was uncompress in
>>>>>>>>> local-repo,
>>>>>>>>> now
>>>>>>>>> it's uncompress in system repo)
>>>>>>>>> - all features contained in the kar are automatically installed
>>>>>>>>> - now, if you remove the kar file, the kar deployer is able to
>>>>>>>>> uninstall
>>>>>>>>> all
>>>>>>>>> features and remove the kar file
>>>>>>>>>
>>>>>>>>> So, even if the storage changed from local-repo to system, the
>>>>>>>>> behavior
>>>>>>>>> is
>>>>>>>>> the same.
>>>>>>>>>
>>>>>>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> JB
>>>>>>>>>
>>>>>>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Hello Karaf devs,
>>>>>>>>>>
>>>>>>>>>> regresion in KarArtifactInstaller service?
>>>>>>>>>>
>>>>>>>>>> in karaf-2.2.7,
>>>>>>>>>>
>>>>>>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>>>>>>>> 'myfeature.jar' under local-repo
>>>>>>>>>>
>>>>>>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>>>>>>> local-repo/myfeature.kar?
>>>>>>>>>>
>>>>>>>>>> is it expected? This changes breaks my custom deployment.
>>>>>>>>>>
>>>>>>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I
>>>>>>>>>> would
>>>>>>>>>> like to continue upgrading to latest 2.2.x code without changing
>>>>>>>>>> my
>>>>>>>>>> code.
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>>
>>>>>>>>>> -Dan
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain
>>>>>>>>>> Gilles<ro...@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> +1
>>>>>>>>>>>
>>>>>>>>>>> Thanks a lot.
>>>>>>>>>>>
>>>>>>>>>>> Romain
>>>>>>>>>>>
>>>>>>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>>>>>>
>>>>>>>>>>>> +1 (binding)
>>>>>>>>>>>>
>>>>>>>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>>>>>>>> tomorrow
>>>>>>>>>>>> morning, but it looks good to me.
>>>>>>>>>>>>
>>>>>>>>>>>> Regards
>>>>>>>>>>>> JB
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> We resolved 28 issues in this release (web page will be
>>>>>>>>>>>>> published
>>>>>>>>>>>>> post
>>>>>>>>>>>>> RC promotion):
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>>>>>>
>>>>>>>>>>>>> Staging repository:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>>>>>>
>>>>>>>>>>>>> Release tags:
>>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>>>>>>
>>>>>>>>>>>>> Please vote to approve this release:
>>>>>>>>>>>>>
>>>>>>>>>>>>> [ ] +1 Approve the release
>>>>>>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>>>>>>
>>>>>>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>>>> jbonofre@apache.org
>>>>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>> jbonofre@apache.org
>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>> Talend - http://www.talend.com
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Jean-Baptiste Onofré
>>>>>>> jbonofre@apache.org
>>>>>>> http://blog.nanthrax.net
>>>>>>> Talend - http://www.talend.com
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Jean-Baptiste Onofré
>>>>> jbonofre@apache.org
>>>>> http://blog.nanthrax.net
>>>>> Talend - http://www.talend.com
>>>
>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Dan,
Do you consider that something has to be change in the
KarArtifactInstaller (or so do you think we should cancel this release) ?
Regards
JB
On 06/21/2012 10:54 PM, Dan Tran wrote:
> I will go ahead to fix this at my end to call 'install()' first to
> copy kar file to where karaf expected, any perhaps use the
> karinstaller service directly since it is exposed a a service.
>
> Thanks
>
>
>
> On Thu, Jun 21, 2012 at 9:12 AM, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>> OK got it.
>>
>> Just background: before 2.2.8, the KarArtifactInstaller only install kar
>> (install(File) method), and doesn't nothing during uninstall().
>>
>> As the kar artifact installer installs all features contained in the kar,
>> lot of users mentionned that it appears as a bug that the kar artifact
>> install doesn't uninstall the features removing the kar file.
>>
>> So to uninstall all features from a kar file, I can work (looking for the
>> features XML in the zip file) on the "original" kar file during
>> uninstall(File) as the file is already removed.
>> So we copy the kar file into the local repo during install:
>>
>> File karFile = new File(localRepoPath, file.getName());
>> copy(file.toURI(), karFile);
>>
>> Like this, at uninstall, we can get back the original kar to looking for
>> features:
>>
>> File karFile = new File(localRepoPath, file.getName());
>>
>> So, that's why the kar file is in localRepo.
>>
>> So it doesn't assume that you place the kar file in localRepo, during the
>> install method, the karArtifactInstaller should copy the file from the
>> location in argument into the localRepo.
>>
>> Could you provide a quick test case to reproduce your issue ?
>>
>> Regards
>> JB
>>
>>
>> On 06/21/2012 05:51 PM, Dan Tran wrote:
>>>
>>> No, infact under karaf2.2.7, it behaves correctly and unpacks my kar
>>> file where I ask it to ( ie localRepoPath )
>>>
>>> in 2.2.8, it still behaves correctly by unpack under localRepoPath,
>>> but looks for the kar file at the wrong place. It assumes I must
>>> place my karFile under localRepoPath, and ignore the full path i pass
>>> into the 'update' method
>>>
>>> -Dan
>>>
>>> On Thu, Jun 21, 2012 at 8:42 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>> wrote:
>>>>
>>>> You mean that your karArtifactInstaller ignores the basePath and
>>>> localRepoPath ?
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 06/21/2012 05:08 PM, Dan Tran wrote:
>>>>>
>>>>>
>>>>> I think I found the root cause, we spin our own KarArtifactInstaller
>>>>> since karaf 2.0.x does not expose it as a service
>>>>>
>>>>> <bean id="karArtifactInstaller"
>>>>> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
>>>>> init-method="init" destroy-method="destroy" activation="lazy">
>>>>> <property name="basePath" value="$[karaf.base]" />
>>>>> <property name="localRepoPath" value="$[karaf.base]/local-repo" />
>>>>> <property name="featuresService">
>>>>> <reference interface="org.apache.karaf.features.FeaturesService"
>>>>> />
>>>>> </property>
>>>>> </bean>
>>>>>
>>>>> Here is reference to karaf team on why we spin our own service bean
>>>>>
>>>>> https://issues.apache.org/jira/browse/KARAF-656
>>>>>
>>>>> However I still it is a bug since I ask the service to look for my
>>>>> file at a certain location, but the it looks somewhere else.
>>>>>
>>>>> Big thanks
>>>>>
>>>>> -Dan
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> Hi Dan,
>>>>>>
>>>>>> Just to clearly understand.
>>>>>>
>>>>>> The update() method calls install(). So it means that:
>>>>>>
>>>>>> - you should see the feature.kar in the repo. This repo is set by the
>>>>>> localRepoPath attribute (target/local-repo in the class, injected to
>>>>>> ${karaf.base}/system by the blueprint descriptor). So, could you check
>>>>>> if
>>>>>> you have the feature.kar in system ?
>>>>>> - FeaturesService.install() is not necessary as the
>>>>>> KarArtifactInstaller
>>>>>> install all features contained in kar files automatically.
>>>>>>
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> long story,
>>>>>>>
>>>>>>> We have our own custom kar deployer where we directly use
>>>>>>> KarArtifactInstaller as a service to deploy our feature kar file and
>>>>>>> we dont place our kar file under karaf's deploy directory )
>>>>>>>
>>>>>>> Here is pseudo code
>>>>>>>
>>>>>>> // Call kar deployer to unpack in karaf local-repo
>>>>>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>>>>>
>>>>>>> //use featureService to deploy the feature
>>>>>>> FeaturesService.install (... )
>>>>>>>
>>>>>>>
>>>>>>> As I have stated before, the first call throws FileNotFoundException
>>>>>>> since it could not find my 'feature.kar' under karaf.base/local-repo.
>>>>>>> Strange??
>>>>>>>
>>>>>>> how er if I also place another copy of my 'feature.kar' file under
>>>>>>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>>>>>>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>>>>>>> Strange??
>>>>>>>
>>>>>>> Thanks for looking into this
>>>>>>>
>>>>>>> -D
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste
>>>>>>> Onofré<jb...@nanthrax.net>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Just to understand your issue, the kar deployer behavior is quite the
>>>>>>>> same:
>>>>>>>> - you put the kar file in the deploy folder
>>>>>>>> - the kar is uncompress (previously it was uncompress in local-repo,
>>>>>>>> now
>>>>>>>> it's uncompress in system repo)
>>>>>>>> - all features contained in the kar are automatically installed
>>>>>>>> - now, if you remove the kar file, the kar deployer is able to
>>>>>>>> uninstall
>>>>>>>> all
>>>>>>>> features and remove the kar file
>>>>>>>>
>>>>>>>> So, even if the storage changed from local-repo to system, the
>>>>>>>> behavior
>>>>>>>> is
>>>>>>>> the same.
>>>>>>>>
>>>>>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> JB
>>>>>>>>
>>>>>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hello Karaf devs,
>>>>>>>>>
>>>>>>>>> regresion in KarArtifactInstaller service?
>>>>>>>>>
>>>>>>>>> in karaf-2.2.7,
>>>>>>>>>
>>>>>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>>>>>>> 'myfeature.jar' under local-repo
>>>>>>>>>
>>>>>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>>>>>> local-repo/myfeature.kar?
>>>>>>>>>
>>>>>>>>> is it expected? This changes breaks my custom deployment.
>>>>>>>>>
>>>>>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>>>>>>>> like to continue upgrading to latest 2.2.x code without changing my
>>>>>>>>> code.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>> -Dan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain
>>>>>>>>> Gilles<ro...@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> +1
>>>>>>>>>>
>>>>>>>>>> Thanks a lot.
>>>>>>>>>>
>>>>>>>>>> Romain
>>>>>>>>>>
>>>>>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>>>>>
>>>>>>>>>>> +1 (binding)
>>>>>>>>>>>
>>>>>>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>>>>>>> tomorrow
>>>>>>>>>>> morning, but it looks good to me.
>>>>>>>>>>>
>>>>>>>>>>> Regards
>>>>>>>>>>> JB
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> We resolved 28 issues in this release (web page will be published
>>>>>>>>>>>> post
>>>>>>>>>>>> RC promotion):
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>>>>>
>>>>>>>>>>>> Staging repository:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>>>>>
>>>>>>>>>>>> Release tags:
>>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>>>>>
>>>>>>>>>>>> Please vote to approve this release:
>>>>>>>>>>>>
>>>>>>>>>>>> [ ] +1 Approve the release
>>>>>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>>>>>
>>>>>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>>> jbonofre@apache.org
>>>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Jean-Baptiste Onofré
>>>>>>>> jbonofre@apache.org
>>>>>>>> http://blog.nanthrax.net
>>>>>>>> Talend - http://www.talend.com
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Jean-Baptiste Onofré
>>>>>> jbonofre@apache.org
>>>>>> http://blog.nanthrax.net
>>>>>> Talend - http://www.talend.com
>>>>
>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Dan Tran <da...@gmail.com>.
I will go ahead to fix this at my end to call 'install()' first to
copy kar file to where karaf expected, any perhaps use the
karinstaller service directly since it is exposed a a service.
Thanks
On Thu, Jun 21, 2012 at 9:12 AM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> OK got it.
>
> Just background: before 2.2.8, the KarArtifactInstaller only install kar
> (install(File) method), and doesn't nothing during uninstall().
>
> As the kar artifact installer installs all features contained in the kar,
> lot of users mentionned that it appears as a bug that the kar artifact
> install doesn't uninstall the features removing the kar file.
>
> So to uninstall all features from a kar file, I can work (looking for the
> features XML in the zip file) on the "original" kar file during
> uninstall(File) as the file is already removed.
> So we copy the kar file into the local repo during install:
>
> File karFile = new File(localRepoPath, file.getName());
> copy(file.toURI(), karFile);
>
> Like this, at uninstall, we can get back the original kar to looking for
> features:
>
> File karFile = new File(localRepoPath, file.getName());
>
> So, that's why the kar file is in localRepo.
>
> So it doesn't assume that you place the kar file in localRepo, during the
> install method, the karArtifactInstaller should copy the file from the
> location in argument into the localRepo.
>
> Could you provide a quick test case to reproduce your issue ?
>
> Regards
> JB
>
>
> On 06/21/2012 05:51 PM, Dan Tran wrote:
>>
>> No, infact under karaf2.2.7, it behaves correctly and unpacks my kar
>> file where I ask it to ( ie localRepoPath )
>>
>> in 2.2.8, it still behaves correctly by unpack under localRepoPath,
>> but looks for the kar file at the wrong place. It assumes I must
>> place my karFile under localRepoPath, and ignore the full path i pass
>> into the 'update' method
>>
>> -Dan
>>
>> On Thu, Jun 21, 2012 at 8:42 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>>
>>> You mean that your karArtifactInstaller ignores the basePath and
>>> localRepoPath ?
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 06/21/2012 05:08 PM, Dan Tran wrote:
>>>>
>>>>
>>>> I think I found the root cause, we spin our own KarArtifactInstaller
>>>> since karaf 2.0.x does not expose it as a service
>>>>
>>>> <bean id="karArtifactInstaller"
>>>> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
>>>> init-method="init" destroy-method="destroy" activation="lazy">
>>>> <property name="basePath" value="$[karaf.base]" />
>>>> <property name="localRepoPath" value="$[karaf.base]/local-repo" />
>>>> <property name="featuresService">
>>>> <reference interface="org.apache.karaf.features.FeaturesService"
>>>> />
>>>> </property>
>>>> </bean>
>>>>
>>>> Here is reference to karaf team on why we spin our own service bean
>>>>
>>>> https://issues.apache.org/jira/browse/KARAF-656
>>>>
>>>> However I still it is a bug since I ask the service to look for my
>>>> file at a certain location, but the it looks somewhere else.
>>>>
>>>> Big thanks
>>>>
>>>> -Dan
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>> wrote:
>>>>>
>>>>>
>>>>> Hi Dan,
>>>>>
>>>>> Just to clearly understand.
>>>>>
>>>>> The update() method calls install(). So it means that:
>>>>>
>>>>> - you should see the feature.kar in the repo. This repo is set by the
>>>>> localRepoPath attribute (target/local-repo in the class, injected to
>>>>> ${karaf.base}/system by the blueprint descriptor). So, could you check
>>>>> if
>>>>> you have the feature.kar in system ?
>>>>> - FeaturesService.install() is not necessary as the
>>>>> KarArtifactInstaller
>>>>> install all features contained in kar files automatically.
>>>>>
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> long story,
>>>>>>
>>>>>> We have our own custom kar deployer where we directly use
>>>>>> KarArtifactInstaller as a service to deploy our feature kar file and
>>>>>> we dont place our kar file under karaf's deploy directory )
>>>>>>
>>>>>> Here is pseudo code
>>>>>>
>>>>>> // Call kar deployer to unpack in karaf local-repo
>>>>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>>>>
>>>>>> //use featureService to deploy the feature
>>>>>> FeaturesService.install (... )
>>>>>>
>>>>>>
>>>>>> As I have stated before, the first call throws FileNotFoundException
>>>>>> since it could not find my 'feature.kar' under karaf.base/local-repo.
>>>>>> Strange??
>>>>>>
>>>>>> how er if I also place another copy of my 'feature.kar' file under
>>>>>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>>>>>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>>>>>> Strange??
>>>>>>
>>>>>> Thanks for looking into this
>>>>>>
>>>>>> -D
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste
>>>>>> Onofré<jb...@nanthrax.net>
>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Just to understand your issue, the kar deployer behavior is quite the
>>>>>>> same:
>>>>>>> - you put the kar file in the deploy folder
>>>>>>> - the kar is uncompress (previously it was uncompress in local-repo,
>>>>>>> now
>>>>>>> it's uncompress in system repo)
>>>>>>> - all features contained in the kar are automatically installed
>>>>>>> - now, if you remove the kar file, the kar deployer is able to
>>>>>>> uninstall
>>>>>>> all
>>>>>>> features and remove the kar file
>>>>>>>
>>>>>>> So, even if the storage changed from local-repo to system, the
>>>>>>> behavior
>>>>>>> is
>>>>>>> the same.
>>>>>>>
>>>>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>>>>
>>>>>>>
>>>>>>> Regards
>>>>>>> JB
>>>>>>>
>>>>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Hello Karaf devs,
>>>>>>>>
>>>>>>>> regresion in KarArtifactInstaller service?
>>>>>>>>
>>>>>>>> in karaf-2.2.7,
>>>>>>>>
>>>>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>>>>>> 'myfeature.jar' under local-repo
>>>>>>>>
>>>>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>>>>> local-repo/myfeature.kar?
>>>>>>>>
>>>>>>>> is it expected? This changes breaks my custom deployment.
>>>>>>>>
>>>>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>>>>>>> like to continue upgrading to latest 2.2.x code without changing my
>>>>>>>> code.
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>>
>>>>>>>> -Dan
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain
>>>>>>>> Gilles<ro...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> +1
>>>>>>>>>
>>>>>>>>> Thanks a lot.
>>>>>>>>>
>>>>>>>>> Romain
>>>>>>>>>
>>>>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>>>>
>>>>>>>>>> +1 (binding)
>>>>>>>>>>
>>>>>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>>>>>> tomorrow
>>>>>>>>>> morning, but it looks good to me.
>>>>>>>>>>
>>>>>>>>>> Regards
>>>>>>>>>> JB
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> We resolved 28 issues in this release (web page will be published
>>>>>>>>>>> post
>>>>>>>>>>> RC promotion):
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>>>>
>>>>>>>>>>> Staging repository:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>>>>
>>>>>>>>>>> Release tags:
>>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>>>>
>>>>>>>>>>> Please vote to approve this release:
>>>>>>>>>>>
>>>>>>>>>>> [ ] +1 Approve the release
>>>>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>>>>
>>>>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>>> jbonofre@apache.org
>>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Jean-Baptiste Onofré
>>>>>>> jbonofre@apache.org
>>>>>>> http://blog.nanthrax.net
>>>>>>> Talend - http://www.talend.com
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Jean-Baptiste Onofré
>>>>> jbonofre@apache.org
>>>>> http://blog.nanthrax.net
>>>>> Talend - http://www.talend.com
>>>
>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
OK got it.
Just background: before 2.2.8, the KarArtifactInstaller only install kar
(install(File) method), and doesn't nothing during uninstall().
As the kar artifact installer installs all features contained in the
kar, lot of users mentionned that it appears as a bug that the kar
artifact install doesn't uninstall the features removing the kar file.
So to uninstall all features from a kar file, I can work (looking for
the features XML in the zip file) on the "original" kar file during
uninstall(File) as the file is already removed.
So we copy the kar file into the local repo during install:
File karFile = new File(localRepoPath, file.getName());
copy(file.toURI(), karFile);
Like this, at uninstall, we can get back the original kar to looking for
features:
File karFile = new File(localRepoPath, file.getName());
So, that's why the kar file is in localRepo.
So it doesn't assume that you place the kar file in localRepo, during
the install method, the karArtifactInstaller should copy the file from
the location in argument into the localRepo.
Could you provide a quick test case to reproduce your issue ?
Regards
JB
On 06/21/2012 05:51 PM, Dan Tran wrote:
> No, infact under karaf2.2.7, it behaves correctly and unpacks my kar
> file where I ask it to ( ie localRepoPath )
>
> in 2.2.8, it still behaves correctly by unpack under localRepoPath,
> but looks for the kar file at the wrong place. It assumes I must
> place my karFile under localRepoPath, and ignore the full path i pass
> into the 'update' method
>
> -Dan
>
> On Thu, Jun 21, 2012 at 8:42 AM, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>> You mean that your karArtifactInstaller ignores the basePath and
>> localRepoPath ?
>>
>> Regards
>> JB
>>
>>
>> On 06/21/2012 05:08 PM, Dan Tran wrote:
>>>
>>> I think I found the root cause, we spin our own KarArtifactInstaller
>>> since karaf 2.0.x does not expose it as a service
>>>
>>> <bean id="karArtifactInstaller"
>>> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
>>> init-method="init" destroy-method="destroy" activation="lazy">
>>> <property name="basePath" value="$[karaf.base]" />
>>> <property name="localRepoPath" value="$[karaf.base]/local-repo" />
>>> <property name="featuresService">
>>> <reference interface="org.apache.karaf.features.FeaturesService" />
>>> </property>
>>> </bean>
>>>
>>> Here is reference to karaf team on why we spin our own service bean
>>>
>>> https://issues.apache.org/jira/browse/KARAF-656
>>>
>>> However I still it is a bug since I ask the service to look for my
>>> file at a certain location, but the it looks somewhere else.
>>>
>>> Big thanks
>>>
>>> -Dan
>>>
>>>
>>>
>>>
>>>
>>> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>> wrote:
>>>>
>>>> Hi Dan,
>>>>
>>>> Just to clearly understand.
>>>>
>>>> The update() method calls install(). So it means that:
>>>>
>>>> - you should see the feature.kar in the repo. This repo is set by the
>>>> localRepoPath attribute (target/local-repo in the class, injected to
>>>> ${karaf.base}/system by the blueprint descriptor). So, could you check if
>>>> you have the feature.kar in system ?
>>>> - FeaturesService.install() is not necessary as the KarArtifactInstaller
>>>> install all features contained in kar files automatically.
>>>>
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>>>
>>>>>
>>>>> long story,
>>>>>
>>>>> We have our own custom kar deployer where we directly use
>>>>> KarArtifactInstaller as a service to deploy our feature kar file and
>>>>> we dont place our kar file under karaf's deploy directory )
>>>>>
>>>>> Here is pseudo code
>>>>>
>>>>> // Call kar deployer to unpack in karaf local-repo
>>>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>>>
>>>>> //use featureService to deploy the feature
>>>>> FeaturesService.install (... )
>>>>>
>>>>>
>>>>> As I have stated before, the first call throws FileNotFoundException
>>>>> since it could not find my 'feature.kar' under karaf.base/local-repo.
>>>>> Strange??
>>>>>
>>>>> how er if I also place another copy of my 'feature.kar' file under
>>>>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>>>>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>>>>> Strange??
>>>>>
>>>>> Thanks for looking into this
>>>>>
>>>>> -D
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> Just to understand your issue, the kar deployer behavior is quite the
>>>>>> same:
>>>>>> - you put the kar file in the deploy folder
>>>>>> - the kar is uncompress (previously it was uncompress in local-repo,
>>>>>> now
>>>>>> it's uncompress in system repo)
>>>>>> - all features contained in the kar are automatically installed
>>>>>> - now, if you remove the kar file, the kar deployer is able to
>>>>>> uninstall
>>>>>> all
>>>>>> features and remove the kar file
>>>>>>
>>>>>> So, even if the storage changed from local-repo to system, the behavior
>>>>>> is
>>>>>> the same.
>>>>>>
>>>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>>>
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Hello Karaf devs,
>>>>>>>
>>>>>>> regresion in KarArtifactInstaller service?
>>>>>>>
>>>>>>> in karaf-2.2.7,
>>>>>>>
>>>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>>>>> 'myfeature.jar' under local-repo
>>>>>>>
>>>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>>>> local-repo/myfeature.kar?
>>>>>>>
>>>>>>> is it expected? This changes breaks my custom deployment.
>>>>>>>
>>>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>>>>>> like to continue upgrading to latest 2.2.x code without changing my
>>>>>>> code.
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> -Dan
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain
>>>>>>> Gilles<ro...@gmail.com>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> +1
>>>>>>>>
>>>>>>>> Thanks a lot.
>>>>>>>>
>>>>>>>> Romain
>>>>>>>>
>>>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>>>
>>>>>>>>> +1 (binding)
>>>>>>>>>
>>>>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>>>>> tomorrow
>>>>>>>>> morning, but it looks good to me.
>>>>>>>>>
>>>>>>>>> Regards
>>>>>>>>> JB
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> We resolved 28 issues in this release (web page will be published
>>>>>>>>>> post
>>>>>>>>>> RC promotion):
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>>>
>>>>>>>>>> Staging repository:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>>>
>>>>>>>>>> Release tags:
>>>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>>>
>>>>>>>>>> Please vote to approve this release:
>>>>>>>>>>
>>>>>>>>>> [ ] +1 Approve the release
>>>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>>>
>>>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Jean-Baptiste Onofré
>>>>>>>>> jbonofre@apache.org
>>>>>>>>> http://blog.nanthrax.net
>>>>>>>>> Talend - http://www.talend.com
>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Jean-Baptiste Onofré
>>>>>> jbonofre@apache.org
>>>>>> http://blog.nanthrax.net
>>>>>> Talend - http://www.talend.com
>>>>
>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Dan Tran <da...@gmail.com>.
No, infact under karaf2.2.7, it behaves correctly and unpacks my kar
file where I ask it to ( ie localRepoPath )
in 2.2.8, it still behaves correctly by unpack under localRepoPath,
but looks for the kar file at the wrong place. It assumes I must
place my karFile under localRepoPath, and ignore the full path i pass
into the 'update' method
-Dan
On Thu, Jun 21, 2012 at 8:42 AM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> You mean that your karArtifactInstaller ignores the basePath and
> localRepoPath ?
>
> Regards
> JB
>
>
> On 06/21/2012 05:08 PM, Dan Tran wrote:
>>
>> I think I found the root cause, we spin our own KarArtifactInstaller
>> since karaf 2.0.x does not expose it as a service
>>
>> <bean id="karArtifactInstaller"
>> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
>> init-method="init" destroy-method="destroy" activation="lazy">
>> <property name="basePath" value="$[karaf.base]" />
>> <property name="localRepoPath" value="$[karaf.base]/local-repo" />
>> <property name="featuresService">
>> <reference interface="org.apache.karaf.features.FeaturesService" />
>> </property>
>> </bean>
>>
>> Here is reference to karaf team on why we spin our own service bean
>>
>> https://issues.apache.org/jira/browse/KARAF-656
>>
>> However I still it is a bug since I ask the service to look for my
>> file at a certain location, but the it looks somewhere else.
>>
>> Big thanks
>>
>> -Dan
>>
>>
>>
>>
>>
>> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>>
>>> Hi Dan,
>>>
>>> Just to clearly understand.
>>>
>>> The update() method calls install(). So it means that:
>>>
>>> - you should see the feature.kar in the repo. This repo is set by the
>>> localRepoPath attribute (target/local-repo in the class, injected to
>>> ${karaf.base}/system by the blueprint descriptor). So, could you check if
>>> you have the feature.kar in system ?
>>> - FeaturesService.install() is not necessary as the KarArtifactInstaller
>>> install all features contained in kar files automatically.
>>>
>>>
>>> Regards
>>> JB
>>>
>>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>>
>>>>
>>>> long story,
>>>>
>>>> We have our own custom kar deployer where we directly use
>>>> KarArtifactInstaller as a service to deploy our feature kar file and
>>>> we dont place our kar file under karaf's deploy directory )
>>>>
>>>> Here is pseudo code
>>>>
>>>> // Call kar deployer to unpack in karaf local-repo
>>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>>
>>>> //use featureService to deploy the feature
>>>> FeaturesService.install (... )
>>>>
>>>>
>>>> As I have stated before, the first call throws FileNotFoundException
>>>> since it could not find my 'feature.kar' under karaf.base/local-repo.
>>>> Strange??
>>>>
>>>> how er if I also place another copy of my 'feature.kar' file under
>>>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>>>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>>>> Strange??
>>>>
>>>> Thanks for looking into this
>>>>
>>>> -D
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>> wrote:
>>>>>
>>>>>
>>>>> Just to understand your issue, the kar deployer behavior is quite the
>>>>> same:
>>>>> - you put the kar file in the deploy folder
>>>>> - the kar is uncompress (previously it was uncompress in local-repo,
>>>>> now
>>>>> it's uncompress in system repo)
>>>>> - all features contained in the kar are automatically installed
>>>>> - now, if you remove the kar file, the kar deployer is able to
>>>>> uninstall
>>>>> all
>>>>> features and remove the kar file
>>>>>
>>>>> So, even if the storage changed from local-repo to system, the behavior
>>>>> is
>>>>> the same.
>>>>>
>>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>>
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> Hello Karaf devs,
>>>>>>
>>>>>> regresion in KarArtifactInstaller service?
>>>>>>
>>>>>> in karaf-2.2.7,
>>>>>>
>>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>>>> 'myfeature.jar' under local-repo
>>>>>>
>>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>>> local-repo/myfeature.kar?
>>>>>>
>>>>>> is it expected? This changes breaks my custom deployment.
>>>>>>
>>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>>>>> like to continue upgrading to latest 2.2.x code without changing my
>>>>>> code.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> -Dan
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain
>>>>>> Gilles<ro...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> +1
>>>>>>>
>>>>>>> Thanks a lot.
>>>>>>>
>>>>>>> Romain
>>>>>>>
>>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>>
>>>>>>>> +1 (binding)
>>>>>>>>
>>>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>>>> tomorrow
>>>>>>>> morning, but it looks good to me.
>>>>>>>>
>>>>>>>> Regards
>>>>>>>> JB
>>>>>>>>
>>>>>>>>
>>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> We resolved 28 issues in this release (web page will be published
>>>>>>>>> post
>>>>>>>>> RC promotion):
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>>
>>>>>>>>> Staging repository:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>>
>>>>>>>>> Release tags:
>>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>>
>>>>>>>>> Please vote to approve this release:
>>>>>>>>>
>>>>>>>>> [ ] +1 Approve the release
>>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>>
>>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Jean-Baptiste Onofré
>>>>>>>> jbonofre@apache.org
>>>>>>>> http://blog.nanthrax.net
>>>>>>>> Talend - http://www.talend.com
>>>>>>>>
>>>>>
>>>>> --
>>>>> Jean-Baptiste Onofré
>>>>> jbonofre@apache.org
>>>>> http://blog.nanthrax.net
>>>>> Talend - http://www.talend.com
>>>
>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
You mean that your karArtifactInstaller ignores the basePath and
localRepoPath ?
Regards
JB
On 06/21/2012 05:08 PM, Dan Tran wrote:
> I think I found the root cause, we spin our own KarArtifactInstaller
> since karaf 2.0.x does not expose it as a service
>
> <bean id="karArtifactInstaller"
> class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
> init-method="init" destroy-method="destroy" activation="lazy">
> <property name="basePath" value="$[karaf.base]" />
> <property name="localRepoPath" value="$[karaf.base]/local-repo" />
> <property name="featuresService">
> <reference interface="org.apache.karaf.features.FeaturesService" />
> </property>
> </bean>
>
> Here is reference to karaf team on why we spin our own service bean
>
> https://issues.apache.org/jira/browse/KARAF-656
>
> However I still it is a bug since I ask the service to look for my
> file at a certain location, but the it looks somewhere else.
>
> Big thanks
>
> -Dan
>
>
>
>
>
> On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>> Hi Dan,
>>
>> Just to clearly understand.
>>
>> The update() method calls install(). So it means that:
>>
>> - you should see the feature.kar in the repo. This repo is set by the
>> localRepoPath attribute (target/local-repo in the class, injected to
>> ${karaf.base}/system by the blueprint descriptor). So, could you check if
>> you have the feature.kar in system ?
>> - FeaturesService.install() is not necessary as the KarArtifactInstaller
>> install all features contained in kar files automatically.
>>
>>
>> Regards
>> JB
>>
>> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>>
>>> long story,
>>>
>>> We have our own custom kar deployer where we directly use
>>> KarArtifactInstaller as a service to deploy our feature kar file and
>>> we dont place our kar file under karaf's deploy directory )
>>>
>>> Here is pseudo code
>>>
>>> // Call kar deployer to unpack in karaf local-repo
>>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>>
>>> //use featureService to deploy the feature
>>> FeaturesService.install (... )
>>>
>>>
>>> As I have stated before, the first call throws FileNotFoundException
>>> since it could not find my 'feature.kar' under karaf.base/local-repo.
>>> Strange??
>>>
>>> how er if I also place another copy of my 'feature.kar' file under
>>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>>> Strange??
>>>
>>> Thanks for looking into this
>>>
>>> -D
>>>
>>>
>>>
>>>
>>>
>>>
>>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>> wrote:
>>>>
>>>> Just to understand your issue, the kar deployer behavior is quite the
>>>> same:
>>>> - you put the kar file in the deploy folder
>>>> - the kar is uncompress (previously it was uncompress in local-repo, now
>>>> it's uncompress in system repo)
>>>> - all features contained in the kar are automatically installed
>>>> - now, if you remove the kar file, the kar deployer is able to uninstall
>>>> all
>>>> features and remove the kar file
>>>>
>>>> So, even if the storage changed from local-repo to system, the behavior
>>>> is
>>>> the same.
>>>>
>>>> Do you use directly the kar deployer (by code I mean) ?
>>>>
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>>
>>>>>
>>>>> Hello Karaf devs,
>>>>>
>>>>> regresion in KarArtifactInstaller service?
>>>>>
>>>>> in karaf-2.2.7,
>>>>>
>>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>>> 'myfeature.jar' under local-repo
>>>>>
>>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>>> local-repo/myfeature.kar?
>>>>>
>>>>> is it expected? This changes breaks my custom deployment.
>>>>>
>>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>>>> like to continue upgrading to latest 2.2.x code without changing my
>>>>> code.
>>>>>
>>>>> Thanks
>>>>>
>>>>> -Dan
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com>
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> +1
>>>>>>
>>>>>> Thanks a lot.
>>>>>>
>>>>>> Romain
>>>>>>
>>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>>
>>>>>>> +1 (binding)
>>>>>>>
>>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>>> tomorrow
>>>>>>> morning, but it looks good to me.
>>>>>>>
>>>>>>> Regards
>>>>>>> JB
>>>>>>>
>>>>>>>
>>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> We resolved 28 issues in this release (web page will be published
>>>>>>>> post
>>>>>>>> RC promotion):
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>>
>>>>>>>> Staging repository:
>>>>>>>>
>>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>>
>>>>>>>> Release tags:
>>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>>
>>>>>>>> Please vote to approve this release:
>>>>>>>>
>>>>>>>> [ ] +1 Approve the release
>>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>>
>>>>>>>> This vote will be open for 72 hours.
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Jean-Baptiste Onofré
>>>>>>> jbonofre@apache.org
>>>>>>> http://blog.nanthrax.net
>>>>>>> Talend - http://www.talend.com
>>>>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Dan Tran <da...@gmail.com>.
I think I found the root cause, we spin our own KarArtifactInstaller
since karaf 2.0.x does not expose it as a service
<bean id="karArtifactInstaller"
class="org.apache.karaf.deployer.kar.KarArtifactInstaller"
init-method="init" destroy-method="destroy" activation="lazy">
<property name="basePath" value="$[karaf.base]" />
<property name="localRepoPath" value="$[karaf.base]/local-repo" />
<property name="featuresService">
<reference interface="org.apache.karaf.features.FeaturesService" />
</property>
</bean>
Here is reference to karaf team on why we spin our own service bean
https://issues.apache.org/jira/browse/KARAF-656
However I still it is a bug since I ask the service to look for my
file at a certain location, but the it looks somewhere else.
Big thanks
-Dan
On Thu, Jun 21, 2012 at 3:56 AM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi Dan,
>
> Just to clearly understand.
>
> The update() method calls install(). So it means that:
>
> - you should see the feature.kar in the repo. This repo is set by the
> localRepoPath attribute (target/local-repo in the class, injected to
> ${karaf.base}/system by the blueprint descriptor). So, could you check if
> you have the feature.kar in system ?
> - FeaturesService.install() is not necessary as the KarArtifactInstaller
> install all features contained in kar files automatically.
>
>
> Regards
> JB
>
> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>
>> long story,
>>
>> We have our own custom kar deployer where we directly use
>> KarArtifactInstaller as a service to deploy our feature kar file and
>> we dont place our kar file under karaf's deploy directory )
>>
>> Here is pseudo code
>>
>> // Call kar deployer to unpack in karaf local-repo
>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>
>> //use featureService to deploy the feature
>> FeaturesService.install (... )
>>
>>
>> As I have stated before, the first call throws FileNotFoundException
>> since it could not find my 'feature.kar' under karaf.base/local-repo.
>> Strange??
>>
>> how er if I also place another copy of my 'feature.kar' file under
>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>> Strange??
>>
>> Thanks for looking into this
>>
>> -D
>>
>>
>>
>>
>>
>>
>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>>
>>> Just to understand your issue, the kar deployer behavior is quite the
>>> same:
>>> - you put the kar file in the deploy folder
>>> - the kar is uncompress (previously it was uncompress in local-repo, now
>>> it's uncompress in system repo)
>>> - all features contained in the kar are automatically installed
>>> - now, if you remove the kar file, the kar deployer is able to uninstall
>>> all
>>> features and remove the kar file
>>>
>>> So, even if the storage changed from local-repo to system, the behavior
>>> is
>>> the same.
>>>
>>> Do you use directly the kar deployer (by code I mean) ?
>>>
>>>
>>> Regards
>>> JB
>>>
>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>
>>>>
>>>> Hello Karaf devs,
>>>>
>>>> regresion in KarArtifactInstaller service?
>>>>
>>>> in karaf-2.2.7,
>>>>
>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>> 'myfeature.jar' under local-repo
>>>>
>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>> local-repo/myfeature.kar?
>>>>
>>>> is it expected? This changes breaks my custom deployment.
>>>>
>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>>> like to continue upgrading to latest 2.2.x code without changing my
>>>> code.
>>>>
>>>> Thanks
>>>>
>>>> -Dan
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com>
>>>> wrote:
>>>>>
>>>>>
>>>>> +1
>>>>>
>>>>> Thanks a lot.
>>>>>
>>>>> Romain
>>>>>
>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>> tomorrow
>>>>>> morning, but it looks good to me.
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>>
>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> We resolved 28 issues in this release (web page will be published
>>>>>>> post
>>>>>>> RC promotion):
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>
>>>>>>> Staging repository:
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>
>>>>>>> Release tags:
>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>
>>>>>>> Please vote to approve this release:
>>>>>>>
>>>>>>> [ ] +1 Approve the release
>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>
>>>>>>> This vote will be open for 72 hours.
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Jean-Baptiste Onofré
>>>>>> jbonofre@apache.org
>>>>>> http://blog.nanthrax.net
>>>>>> Talend - http://www.talend.com
>>>>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Dan,
Just to clearly understand.
The update() method calls install(). So it means that:
- you should see the feature.kar in the repo. This repo is set by the
localRepoPath attribute (target/local-repo in the class, injected to
${karaf.base}/system by the blueprint descriptor). So, could you check
if you have the feature.kar in system ?
- FeaturesService.install() is not necessary as the KarArtifactInstaller
install all features contained in kar files automatically.
Regards
JB
On 06/21/2012 08:14 AM, Dan Tran wrote:
> long story,
>
> We have our own custom kar deployer where we directly use
> KarArtifactInstaller as a service to deploy our feature kar file and
> we dont place our kar file under karaf's deploy directory )
>
> Here is pseudo code
>
> // Call kar deployer to unpack in karaf local-repo
> KarArtifactInstaller.update( File path/to/our/feature.kar )
>
> //use featureService to deploy the feature
> FeaturesService.install (... )
>
>
> As I have stated before, the first call throws FileNotFoundException
> since it could not find my 'feature.kar' under karaf.base/local-repo.
> Strange??
>
> how er if I also place another copy of my 'feature.kar' file under
> karaf's local-repo directory, the same KarArtifactInstaller.update(
> File path/to/our/feature.kar ) is happy and unpack under local-repo.
> Strange??
>
> Thanks for looking into this
>
> -D
>
>
>
>
>
>
> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>> Just to understand your issue, the kar deployer behavior is quite the same:
>> - you put the kar file in the deploy folder
>> - the kar is uncompress (previously it was uncompress in local-repo, now
>> it's uncompress in system repo)
>> - all features contained in the kar are automatically installed
>> - now, if you remove the kar file, the kar deployer is able to uninstall all
>> features and remove the kar file
>>
>> So, even if the storage changed from local-repo to system, the behavior is
>> the same.
>>
>> Do you use directly the kar deployer (by code I mean) ?
>>
>>
>> Regards
>> JB
>>
>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>
>>> Hello Karaf devs,
>>>
>>> regresion in KarArtifactInstaller service?
>>>
>>> in karaf-2.2.7,
>>>
>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>> 'myfeature.jar' under local-repo
>>>
>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>> local-repo/myfeature.kar?
>>>
>>> is it expected? This changes breaks my custom deployment.
>>>
>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>> like to continue upgrading to latest 2.2.x code without changing my
>>> code.
>>>
>>> Thanks
>>>
>>> -Dan
>>>
>>>
>>>
>>>
>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com>
>>> wrote:
>>>>
>>>> +1
>>>>
>>>> Thanks a lot.
>>>>
>>>> Romain
>>>>
>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>
>>>>> +1 (binding)
>>>>>
>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>> tomorrow
>>>>> morning, but it looks good to me.
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>>
>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> We resolved 28 issues in this release (web page will be published post
>>>>>> RC promotion):
>>>>>>
>>>>>>
>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>
>>>>>> Staging repository:
>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>
>>>>>> Release tags:
>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>
>>>>>> Please vote to approve this release:
>>>>>>
>>>>>> [ ] +1 Approve the release
>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>
>>>>>> This vote will be open for 72 hours.
>>>>>>
>>>>>
>>>>> --
>>>>> Jean-Baptiste Onofré
>>>>> jbonofre@apache.org
>>>>> http://blog.nanthrax.net
>>>>> Talend - http://www.talend.com
>>>>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by "Jamie G." <ja...@gmail.com>.
I'm going to await JB's investigation result - but this doesn't sounds
like a new regression to 2.2.8.
-Jamie
On Wed, Jun 20, 2012 at 11:40 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> OK, it should not have changed between 2.2.7 and 2.2.8, the only difference
> is that now KarArtifactInstaller supports uninstall (and update) aka
> uninstall the kar features before removing the file.
>
> Let me try to reproduce your issue.
>
> Regards
> JB
>
>
> On 06/21/2012 08:14 AM, Dan Tran wrote:
>>
>> long story,
>>
>> We have our own custom kar deployer where we directly use
>> KarArtifactInstaller as a service to deploy our feature kar file and
>> we dont place our kar file under karaf's deploy directory )
>>
>> Here is pseudo code
>>
>> // Call kar deployer to unpack in karaf local-repo
>> KarArtifactInstaller.update( File path/to/our/feature.kar )
>>
>> //use featureService to deploy the feature
>> FeaturesService.install (... )
>>
>>
>> As I have stated before, the first call throws FileNotFoundException
>> since it could not find my 'feature.kar' under karaf.base/local-repo.
>> Strange??
>>
>> how er if I also place another copy of my 'feature.kar' file under
>> karaf's local-repo directory, the same KarArtifactInstaller.update(
>> File path/to/our/feature.kar ) is happy and unpack under local-repo.
>> Strange??
>>
>> Thanks for looking into this
>>
>> -D
>>
>>
>>
>>
>>
>>
>> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>>
>>> Just to understand your issue, the kar deployer behavior is quite the
>>> same:
>>> - you put the kar file in the deploy folder
>>> - the kar is uncompress (previously it was uncompress in local-repo, now
>>> it's uncompress in system repo)
>>> - all features contained in the kar are automatically installed
>>> - now, if you remove the kar file, the kar deployer is able to uninstall
>>> all
>>> features and remove the kar file
>>>
>>> So, even if the storage changed from local-repo to system, the behavior
>>> is
>>> the same.
>>>
>>> Do you use directly the kar deployer (by code I mean) ?
>>>
>>>
>>> Regards
>>> JB
>>>
>>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>>
>>>>
>>>> Hello Karaf devs,
>>>>
>>>> regresion in KarArtifactInstaller service?
>>>>
>>>> in karaf-2.2.7,
>>>>
>>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>>> 'myfeature.jar' under local-repo
>>>>
>>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>>> local-repo/myfeature.kar?
>>>>
>>>> is it expected? This changes breaks my custom deployment.
>>>>
>>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>>> like to continue upgrading to latest 2.2.x code without changing my
>>>> code.
>>>>
>>>> Thanks
>>>>
>>>> -Dan
>>>>
>>>>
>>>>
>>>>
>>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com>
>>>> wrote:
>>>>>
>>>>>
>>>>> +1
>>>>>
>>>>> Thanks a lot.
>>>>>
>>>>> Romain
>>>>>
>>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>>> tomorrow
>>>>>> morning, but it looks good to me.
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>>
>>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> We resolved 28 issues in this release (web page will be published
>>>>>>> post
>>>>>>> RC promotion):
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>>
>>>>>>> Staging repository:
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>>
>>>>>>> Release tags:
>>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>>
>>>>>>> Please vote to approve this release:
>>>>>>>
>>>>>>> [ ] +1 Approve the release
>>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>>
>>>>>>> This vote will be open for 72 hours.
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Jean-Baptiste Onofré
>>>>>> jbonofre@apache.org
>>>>>> http://blog.nanthrax.net
>>>>>> Talend - http://www.talend.com
>>>>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
OK, it should not have changed between 2.2.7 and 2.2.8, the only
difference is that now KarArtifactInstaller supports uninstall (and
update) aka uninstall the kar features before removing the file.
Let me try to reproduce your issue.
Regards
JB
On 06/21/2012 08:14 AM, Dan Tran wrote:
> long story,
>
> We have our own custom kar deployer where we directly use
> KarArtifactInstaller as a service to deploy our feature kar file and
> we dont place our kar file under karaf's deploy directory )
>
> Here is pseudo code
>
> // Call kar deployer to unpack in karaf local-repo
> KarArtifactInstaller.update( File path/to/our/feature.kar )
>
> //use featureService to deploy the feature
> FeaturesService.install (... )
>
>
> As I have stated before, the first call throws FileNotFoundException
> since it could not find my 'feature.kar' under karaf.base/local-repo.
> Strange??
>
> how er if I also place another copy of my 'feature.kar' file under
> karaf's local-repo directory, the same KarArtifactInstaller.update(
> File path/to/our/feature.kar ) is happy and unpack under local-repo.
> Strange??
>
> Thanks for looking into this
>
> -D
>
>
>
>
>
>
> On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>> Just to understand your issue, the kar deployer behavior is quite the same:
>> - you put the kar file in the deploy folder
>> - the kar is uncompress (previously it was uncompress in local-repo, now
>> it's uncompress in system repo)
>> - all features contained in the kar are automatically installed
>> - now, if you remove the kar file, the kar deployer is able to uninstall all
>> features and remove the kar file
>>
>> So, even if the storage changed from local-repo to system, the behavior is
>> the same.
>>
>> Do you use directly the kar deployer (by code I mean) ?
>>
>>
>> Regards
>> JB
>>
>> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>>
>>> Hello Karaf devs,
>>>
>>> regresion in KarArtifactInstaller service?
>>>
>>> in karaf-2.2.7,
>>>
>>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>>> 'myfeature.jar' under local-repo
>>>
>>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>>> local-repo/myfeature.kar?
>>>
>>> is it expected? This changes breaks my custom deployment.
>>>
>>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>>> like to continue upgrading to latest 2.2.x code without changing my
>>> code.
>>>
>>> Thanks
>>>
>>> -Dan
>>>
>>>
>>>
>>>
>>> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com>
>>> wrote:
>>>>
>>>> +1
>>>>
>>>> Thanks a lot.
>>>>
>>>> Romain
>>>>
>>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>
>>>>> +1 (binding)
>>>>>
>>>>> First tests passed without problem, I will test with Cellar, etc
>>>>> tomorrow
>>>>> morning, but it looks good to me.
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>>
>>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> We resolved 28 issues in this release (web page will be published post
>>>>>> RC promotion):
>>>>>>
>>>>>>
>>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>>
>>>>>> Staging repository:
>>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>>
>>>>>> Release tags:
>>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>>
>>>>>> Please vote to approve this release:
>>>>>>
>>>>>> [ ] +1 Approve the release
>>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>>
>>>>>> This vote will be open for 72 hours.
>>>>>>
>>>>>
>>>>> --
>>>>> Jean-Baptiste Onofré
>>>>> jbonofre@apache.org
>>>>> http://blog.nanthrax.net
>>>>> Talend - http://www.talend.com
>>>>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Dan Tran <da...@gmail.com>.
long story,
We have our own custom kar deployer where we directly use
KarArtifactInstaller as a service to deploy our feature kar file and
we dont place our kar file under karaf's deploy directory )
Here is pseudo code
// Call kar deployer to unpack in karaf local-repo
KarArtifactInstaller.update( File path/to/our/feature.kar )
//use featureService to deploy the feature
FeaturesService.install (... )
As I have stated before, the first call throws FileNotFoundException
since it could not find my 'feature.kar' under karaf.base/local-repo.
Strange??
how er if I also place another copy of my 'feature.kar' file under
karaf's local-repo directory, the same KarArtifactInstaller.update(
File path/to/our/feature.kar ) is happy and unpack under local-repo.
Strange??
Thanks for looking into this
-D
On Wed, Jun 20, 2012 at 10:20 PM, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Just to understand your issue, the kar deployer behavior is quite the same:
> - you put the kar file in the deploy folder
> - the kar is uncompress (previously it was uncompress in local-repo, now
> it's uncompress in system repo)
> - all features contained in the kar are automatically installed
> - now, if you remove the kar file, the kar deployer is able to uninstall all
> features and remove the kar file
>
> So, even if the storage changed from local-repo to system, the behavior is
> the same.
>
> Do you use directly the kar deployer (by code I mean) ?
>
>
> Regards
> JB
>
> On 06/21/2012 12:13 AM, Dan Tran wrote:
>>
>> Hello Karaf devs,
>>
>> regresion in KarArtifactInstaller service?
>>
>> in karaf-2.2.7,
>>
>> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
>> 'myfeature.jar' under local-repo
>>
>> in karaf-2.2.8, the call, expect that I put myfeature.kar under
>> local-repo/myfeature.kar?
>>
>> is it expected? This changes breaks my custom deployment.
>>
>> Can we have this new behavior in 3.0, or 2.3 instead? since I would
>> like to continue upgrading to latest 2.2.x code without changing my
>> code.
>>
>> Thanks
>>
>> -Dan
>>
>>
>>
>>
>> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com>
>> wrote:
>>>
>>> +1
>>>
>>> Thanks a lot.
>>>
>>> Romain
>>>
>>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>
>>>> +1 (binding)
>>>>
>>>> First tests passed without problem, I will test with Cellar, etc
>>>> tomorrow
>>>> morning, but it looks good to me.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> We resolved 28 issues in this release (web page will be published post
>>>>> RC promotion):
>>>>>
>>>>>
>>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>>
>>>>> Staging repository:
>>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>>
>>>>> Release tags:
>>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>>
>>>>> Please vote to approve this release:
>>>>>
>>>>> [ ] +1 Approve the release
>>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>>
>>>>> This vote will be open for 72 hours.
>>>>>
>>>>
>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Just to understand your issue, the kar deployer behavior is quite the same:
- you put the kar file in the deploy folder
- the kar is uncompress (previously it was uncompress in local-repo, now
it's uncompress in system repo)
- all features contained in the kar are automatically installed
- now, if you remove the kar file, the kar deployer is able to uninstall
all features and remove the kar file
So, even if the storage changed from local-repo to system, the behavior
is the same.
Do you use directly the kar deployer (by code I mean) ?
Regards
JB
On 06/21/2012 12:13 AM, Dan Tran wrote:
> Hello Karaf devs,
>
> regresion in KarArtifactInstaller service?
>
> in karaf-2.2.7,
>
> karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
> 'myfeature.jar' under local-repo
>
> in karaf-2.2.8, the call, expect that I put myfeature.kar under
> local-repo/myfeature.kar?
>
> is it expected? This changes breaks my custom deployment.
>
> Can we have this new behavior in 3.0, or 2.3 instead? since I would
> like to continue upgrading to latest 2.2.x code without changing my
> code.
>
> Thanks
>
> -Dan
>
>
>
>
> On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles<ro...@gmail.com> wrote:
>> +1
>>
>> Thanks a lot.
>>
>> Romain
>>
>> 2012/6/20 Jean-Baptiste Onofré<jb...@nanthrax.net>
>>
>>> +1 (binding)
>>>
>>> First tests passed without problem, I will test with Cellar, etc tomorrow
>>> morning, but it looks good to me.
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>>
>>>> Hi,
>>>>
>>>> We resolved 28 issues in this release (web page will be published post
>>>> RC promotion):
>>>>
>>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>>
>>>> Staging repository:
>>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>>
>>>> Release tags:
>>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>>
>>>> Please vote to approve this release:
>>>>
>>>> [ ] +1 Approve the release
>>>> [ ] -1 Veto the release (please provide specific comments)
>>>>
>>>> This vote will be open for 72 hours.
>>>>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Dan Tran <da...@gmail.com>.
Hello Karaf devs,
regresion in KarArtifactInstaller service?
in karaf-2.2.7,
karInstaller.update( full/path/to/my/myfeature.kar ) unpacks my
'myfeature.jar' under local-repo
in karaf-2.2.8, the call, expect that I put myfeature.kar under
local-repo/myfeature.kar?
is it expected? This changes breaks my custom deployment.
Can we have this new behavior in 3.0, or 2.3 instead? since I would
like to continue upgrading to latest 2.2.x code without changing my
code.
Thanks
-Dan
On Wed, Jun 20, 2012 at 2:10 PM, Romain Gilles <ro...@gmail.com> wrote:
> +1
>
> Thanks a lot.
>
> Romain
>
> 2012/6/20 Jean-Baptiste Onofré <jb...@nanthrax.net>
>
>> +1 (binding)
>>
>> First tests passed without problem, I will test with Cellar, etc tomorrow
>> morning, but it looks good to me.
>>
>> Regards
>> JB
>>
>>
>> On 06/20/2012 10:05 PM, Jamie G. wrote:
>>
>>> Hi,
>>>
>>> We resolved 28 issues in this release (web page will be published post
>>> RC promotion):
>>>
>>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>>
>>> Staging repository:
>>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>>
>>> Release tags:
>>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>>
>>> Please vote to approve this release:
>>>
>>> [ ] +1 Approve the release
>>> [ ] -1 Veto the release (please provide specific comments)
>>>
>>> This vote will be open for 72 hours.
>>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Romain Gilles <ro...@gmail.com>.
+1
Thanks a lot.
Romain
2012/6/20 Jean-Baptiste Onofré <jb...@nanthrax.net>
> +1 (binding)
>
> First tests passed without problem, I will test with Cellar, etc tomorrow
> morning, but it looks good to me.
>
> Regards
> JB
>
>
> On 06/20/2012 10:05 PM, Jamie G. wrote:
>
>> Hi,
>>
>> We resolved 28 issues in this release (web page will be published post
>> RC promotion):
>>
>> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>>
>> Release tags:
>> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Veto the release (please provide specific comments)
>>
>> This vote will be open for 72 hours.
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1 (binding)
First tests passed without problem, I will test with Cellar, etc
tomorrow morning, but it looks good to me.
Regards
JB
On 06/20/2012 10:05 PM, Jamie G. wrote:
> Hi,
>
> We resolved 28 issues in this release (web page will be published post
> RC promotion):
> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>
> Release tags:
> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours.
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Ioannis Canellos <io...@gmail.com>.
+1
Checked the main and the minimal distributions and both look ok.
Tested with a couple of features provided with choourl, overall seems fine.
A minor issue that I notice is that some of them do not work properly
unless we modify startup properties, we need to address that in future
releases.
--
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>
**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by Christian Schneider <ch...@die-schneider.net>.
+1 (non binding)
Christian
Am 20.06.2012 22:05, schrieb Jamie G.:
> Hi,
>
> We resolved 28 issues in this release (web page will be published post
> RC promotion):
> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>
> Release tags:
> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours.
--
Christian Schneider
http://www.liquid-reality.de
Open Source Architect
Talend Application Integration Division http://www.talend.com
Re: [VOTE] Release Apache Karaf 2.2.8
Posted by "Ulhas Bhole (OS)" <ap...@gmail.com>.
+1,
-- Ulhas
On 20 Jun 2012, at 21:05, Jamie G. wrote:
> Hi,
>
> We resolved 28 issues in this release (web page will be published post
> RC promotion):
> https://svn.apache.org/repos/asf/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.2.8-release.page
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachekaraf-255/
>
> Release tags:
> https://svn.apache.org/repos/asf/karaf/tags/karaf-2.2.8/
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote will be open for 72 hours.