You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/23 18:34:39 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #332: Add sbt-license-report generated links to http whitelist
mdedetrich opened a new pull request, #332:
URL: https://github.com/apache/incubator-pekko/pull/332
Resolves: https://github.com/apache/incubator-pekko/issues/326
The solution is pretty dumb, but there doesn't appear to be a config option that allows you to explicitly ignore a file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #332: Add sbt-license-report generated links to http whitelist
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #332:
URL: https://github.com/apache/incubator-pekko/pull/332#discussion_r1202883979
##########
scripts/link-validator.conf:
##########
@@ -46,6 +46,14 @@ site-link-validator {
"https://javadoc.io/static/"
# GitHub will block with "429 Too Many Requests"
"https://github.com/"
+ # Github links generated by sbt-license-report
+ "http://github.com/FasterXML/jackson"
Review Comment:
Fixed and pushed, lets see if this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #332: Add sbt-license-report generated links to http whitelist
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #332:
URL: https://github.com/apache/incubator-pekko/pull/332#discussion_r1202881520
##########
scripts/link-validator.conf:
##########
@@ -46,6 +46,14 @@ site-link-validator {
"https://javadoc.io/static/"
# GitHub will block with "429 Too Many Requests"
"https://github.com/"
+ # Github links generated by sbt-license-report
+ "http://github.com/FasterXML/jackson"
Review Comment:
maybe just `http://github.com` to match the `429 Too Many Requests` section above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #332: Add sbt-license-report generated links to http whitelist
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #332:
URL: https://github.com/apache/incubator-pekko/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org