[GitHub] [samza] cameronlee314 commented on a change in pull request #1150: SAMZA-2318: Empty config values from coordinator stream shouldn't be removed

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1150: SAMZA-2318: Empty config values from coordinator stream shouldn't be removed
URL: https://github.com/apache/samza/pull/1150#discussion_r324286646
 
 

 ##########
 File path: samza-core/src/test/scala/org/apache/samza/util/TestCoordinatorStreamUtil.scala
 ##########
 @@ -34,4 +39,31 @@ class TestCoordinatorStreamUtil {
     Mockito.verify(systemStream).getStream
     Mockito.verify(systemAdmin).createStream(any(classOf[StreamSpec]))
   }
+
+  @Test
+  def testReadConfigFromCoordinatorStream {
+    val keyForNonBlankVal = "app.id"
+    val nonBlankVal = "1"
+    val keyForEmptyVal = "task.opt"
+    val emptyVal = ""
+    val keyForNullVal = "zk.server"
+    val nullVal = null
 
 Review comment:
   This var is unused.
   In order to test the `valueAsString == null` condition, can you please add `"null"` (as a String) to the config map? That should be the case where the bytes are non-null, but the `valueAsString` is null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services