[GitHub] graceguo-supercat commented on a change in pull request #4760: URL shortner for dashboards

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #4760: URL shortner for dashboards
URL: https://github.com/apache/incubator-superset/pull/4760#discussion_r185330381
 
 

 ##########
 File path: superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
 ##########
 @@ -157,27 +151,6 @@ class ExploreViewContainer extends React.Component {
     }
   }
 
-  addHistory({ isReplace = false, title }) {
 
 Review comment:
   i feel it's safe to keep query state in browser history.
   - we still need to keep url scheme backward compatible right? Even we display url in browser like /r/123, when user request with old scheme, we should handle it correctly.
   - after query state added into browser history, there is no real long url request happened unless user refreshed browser or someone accessed the shared url. So i guess the rate of old url scheme is pretty low.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services