You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2002/12/05 07:14:33 UTC

DO NOT REPLY [Bug 14800] - Fix initialization bug and add size parameter to form-property

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14800>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14800

Fix initialization bug and add size parameter to form-property





------- Additional Comments From martinc@apache.org  2002-12-05 06:14 -------
I guess I'm confused by this patch, since it doesn't really seem to solve the 
problem, and it breaks backwards compatibility at the same time.

* If 'size' is not specified, there is no longer any special handling for an 
array, as there is today, so no cloning will happen at all, causing a worse 
problem than the bug report describes.

* If 'size' is specified, it is not possible to specify an initial value for 
any of the elements of the array. I would have thought that in this case you 
would at least want 'initial' to specify the value to be used for each element 
of the array.

To solve the original problem reported, it would seem to me that a much simpler 
solution would be to just replace this line:

    Array.set(newValue, j, Array.get(initialValue, j));

with this one:

    Array.set(newValue, j, Array.get(initialValue, j).clone());

Would this not work for some reason?

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>