You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2002/03/21 18:52:41 UTC
DO NOT REPLY [Bug 7335] New: -
broken line in jasper/src/share/org/apache/jasper/resources/messages.properties
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7335>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7335
broken line in jasper/src/share/org/apache/jasper/resources/messages.properties
Summary: broken line in
jasper/src/share/org/apache/jasper/resources/messages.pr
operties
Product: Tomcat 4
Version: Nightly Build
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Minor
Priority: Other
Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: konradk@ca.ibm.com
a value of jsp.warning.largeFile is split into 2 lines without new line escape.
Here is a patch, joins 2 lines back into one:
Index: jasper/src/share/org/apache/jasper/resources/messages.properties
===================================================================
RCS file: /home/cvspublic/jakarta-tomcat-
4.0/jasper/src/share/org/apache/jasper/resources/messages.properties,v
retrieving revision 1.24
diff -u -r1.24 messages.properties
--- jasper/src/share/org/apache/jasper/resources/messages.properties 3 Jan
2002 08:53:31 -0000 1.24
+++ jasper/src/share/org/apache/jasper/resources/messages.properties 21 Mar
2002 17:48:42 -0000
@@ -1,4 +1,4 @@
-# $Id: messages.properties,v 1.23 2001/12/03 15:47:39 larryi Exp $
+# $Id: messages.properties,v 1.24 2002/01/03 08:53:31 remm Exp $
#
# Default localized string information
# Localized this the Default Locale as is en_US
@@ -111,8 +111,7 @@
jsp.error.setproperty.paramOrValue=setProperty: either param or value can be
present
jsp.error.setproperty.arrayVal=setProperty: can't set array property {0}
through a string constant value
jsp.warning.keepgen=Warning: Invalid value for the initParam keepgenerated.
Will use the default value of \"false\"
-jsp.warning.largeFile=Warning: Invalid value for the initParam
-largeFile. Will use the default value of \"true\"
+jsp.warning.largeFile=Warning: Invalid value for the initParam largeFile. Will
use the default value of \"true\"
jsp.warning.mappedFile=Warning: Invalid value for the initParam mappedFile.
Will use the default value of \"false\"
jsp.warning.sendErrToClient=Warning: Invalid value for the initParam
sendErrToClient. Will use the default value of \"false\"
jsp.warning.classDebugInfo=Warning: Invalid value for the initParam
classdebuginfo. Will use the default value of \"false\"
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by co...@covalent.net.
On Fri, 22 Mar 2002, Remy Maucherat wrote:
> > > below). The Coyote connector will *not* be enabled by default, but will
> > > appear commented out in the default server.xml configuration file.
> >
> > +1 on enabling it by default, commenting out the old connector.
>
> I didn't propose to do that, because, although the new connector appears
> robust and stable, there's the risk that it would have new bugs, or, even
> worse, (re)introduce some security problems. I took great care of adding all
> the URL normalization code from the old connector, so that it shouldn't
> happen, but I'd say it would still be a significant risk to make it the
> default without some extensive beta period. Since there will be such a beta
> period for 4.1, I think it is a lot safer to postpone making it the default
> for now.
>
> Comments ?
The code is clearly better and cleaner than the old connector, that means
more maintainable and easier to fix and review - if there's any problem.
And cleaner code is usually more secure :-)
But I agree it's safer to do it gradually, however I hope 4.0.5 and
3.3.2 will have coyote as the default connector.
Costin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by Remy Maucherat <re...@apache.org>.
> > below). The Coyote connector will *not* be enabled by default, but will
> > appear commented out in the default server.xml configuration file.
>
> +1 on enabling it by default, commenting out the old connector.
I didn't propose to do that, because, although the new connector appears
robust and stable, there's the risk that it would have new bugs, or, even
worse, (re)introduce some security problems. I took great care of adding all
the URL normalization code from the old connector, so that it shouldn't
happen, but I'd say it would still be a significant risk to make it the
default without some extensive beta period. Since there will be such a beta
period for 4.1, I think it is a lot safer to postpone making it the default
for now.
Comments ?
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by Remy Maucherat <re...@apache.org>.
> I have to commit and retest things (PR6982) and properties problems with
Coyote
> as soon as I am thru +1 for both.
Ok. Properties means message strings ? If so, yes, I'd say it needs to be
improved.
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Remy Maucherat wrote:
> I'd like to propose releasing 4.0.4 beta 2 within a few days (friday at the
> earliest, next tuesday at the latest). This release will include bugfixes
> (the list is in the usual release notes document in CVS) as well as the
> inclusion of the Coyote binaries (conditional to the results of the vote
> below). The Coyote connector will *not* be enabled by default, but will
> appear commented out in the default server.xml configuration file.
>
> I also plan to make a Coyote 1.0 beta 4 at the same time, to pick up the
> bugfixes and minor improvements in the Tomcat adaptors.
>
> Tomcat 4.0.4 Beta 2 release:
> <ballot>
> +1 [ ] I support the release, and I will help
> +0 [ ] I support the release
> -0 [ ] I don't support the release
> -1 [ ] I'm against the release because:
>
>
> </ballot>
>
> Inclusion of the Coyote binaries:
> <ballot>
> +1 [ ] Yes
> -1 [ ] No
> </ballot>
>
> My vote is +1 for both.
>
> Remy
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
>
I have to commit and retest things (PR6982) and properties problems with Coyote
as soon as I am thru +1 for both.
Cheers
Jean-frederic
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by Bill Barker <wb...@wilshire.com>.
> Tomcat 4.0.4 Beta 2 release:
> <ballot>
> +1 [ ] I support the release, and I will help
> +0 [X] I support the release
> -0 [ ] I don't support the release
> -1 [ ] I'm against the release because:
>
>
> </ballot>
>
> Inclusion of the Coyote binaries:
> <ballot>
> +1 [X] Yes
> -1 [ ] No
> </ballot>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by Amy Roh <am...@apache.org>.
>
> Tomcat 4.0.4 Beta 2 release:
> <ballot>
> +1 [X] I support the release, and I will help
> +0 [ ] I support the release
> -0 [ ] I don't support the release
> -1 [ ] I'm against the release because:
>
> </ballot>
>
> Inclusion of the Coyote binaries:
> <ballot>
> +1 [X] Yes
> -1 [ ] No
> </ballot>
>
> My vote is +1 for both.
>
> Remy
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by Manveen Kaur <ma...@sun.com>.
> I also plan to make a Coyote 1.0 beta 4 at the same time, to pick up the
> bugfixes and minor improvements in the Tomcat adaptors.
>
> Tomcat 4.0.4 Beta 2 release:
> <ballot>
> +1 [*] I support the release, and I will help
> +0 [ ] I support the release
> -0 [ ] I don't support the release
> -1 [ ] I'm against the release because:
>
> </ballot>
>
> Inclusion of the Coyote binaries:
> <ballot>
> +1 [*] Yes
> -1 [ ] No
> </ballot>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by co...@covalent.net.
On Thu, 21 Mar 2002, Remy Maucherat wrote:
> below). The Coyote connector will *not* be enabled by default, but will
> appear commented out in the default server.xml configuration file.
+1 on enabling it by default, commenting out the old connector.
> I also plan to make a Coyote 1.0 beta 4 at the same time, to pick up the
> bugfixes and minor improvements in the Tomcat adaptors.
>
> Tomcat 4.0.4 Beta 2 release:
> <ballot>
> +1 [X] I support the release, and I will help
> +0 [ ] I support the release
> -0 [ ] I don't support the release
> -1 [ ] I'm against the release because:
> </ballot>
>
> Inclusion of the Coyote binaries:
> <ballot>
> +1 [X] Yes
> -1 [ ] No
> </ballot>
Costin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
[VOTE] Tomcat 4.0.4 Beta 2 / Coyote 1.0 Beta 4 release
Posted by Remy Maucherat <re...@apache.org>.
I'd like to propose releasing 4.0.4 beta 2 within a few days (friday at the
earliest, next tuesday at the latest). This release will include bugfixes
(the list is in the usual release notes document in CVS) as well as the
inclusion of the Coyote binaries (conditional to the results of the vote
below). The Coyote connector will *not* be enabled by default, but will
appear commented out in the default server.xml configuration file.
I also plan to make a Coyote 1.0 beta 4 at the same time, to pick up the
bugfixes and minor improvements in the Tomcat adaptors.
Tomcat 4.0.4 Beta 2 release:
<ballot>
+1 [ ] I support the release, and I will help
+0 [ ] I support the release
-0 [ ] I don't support the release
-1 [ ] I'm against the release because:
</ballot>
Inclusion of the Coyote binaries:
<ballot>
+1 [ ] Yes
-1 [ ] No
</ballot>
My vote is +1 for both.
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>