You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/03/31 14:28:20 UTC
[GitHub] [calcite-avatica-go] liguozhong opened a new pull request #57: [WIP] ResetSession implements driver.SessionResetter.
liguozhong opened a new pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57
avatica sql query fails after running for a period of time on our online loki, this PR attempts to solve this "NoSuchConnectionException" problem.
```shell
level=error ts=2022-03-31T12:51:09.356233496Z caller=table_manager.go:233 msg="error syncing tables" err="An error was encountered while processing your request: NoSuchConnectionException{connectionId='Connection not found: invalid id, closed, or expired: ccd95a16-5496-7001-f99b-1ab0e5f19e05'}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] F21 commented on pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
F21 commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085400308
You can squash the commits by following these steps: https://gitbetter.substack.com/p/how-to-squash-git-commits?s=r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong commented on pull request #57: [WIP] [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085352915
@F21 done.
this pr has fixed "NoSuchConnectionException" issue in my loki cluster. and "NoSuchConnectionException" no longer appears in the log, but I'm not a database expert, @F21 I still need your help to review the code .
without this pr
this this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong commented on pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085400967
> Looks good to me! Please squash your commits and make the commit message the same as the title of the PR.
https://github.com/apache/calcite-avatica-go/pull/59
@F21 Hi, I have some problems with rebase, I submitted a new PR(https://github.com/apache/calcite-avatica-go/pull/59), can I close this PR by merging another PR, I am not good at using rebase to merge multiple commits.thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong commented on pull request #57: [WIP] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085294462
> Hey thanks for working on this. Can you open an issue at https://issues.apache.org/jira/secure/Dashboard.jspa and change the title of the PR to `[CALCITE-XXXX] Title of PR`? See the updated title in #56 as an example.
Ok, I will go to jira to open an issue, I have no PR experience with apache foundation.
Thanks for your quick response .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] F21 commented on pull request #57: [WIP] [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
F21 commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085359819
Looks good to me! Please squash your commits and make the commit message the same as the title of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong edited a comment on pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong edited a comment on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085397046
> Looks good to me! Please squash your commits and make the commit message the same as the title of the PR.
https://github.com/apache/calcite-avatica-go/pull/58
@F21 Hi, I have some problems with rebase, I submitted a new PR(https://github.com/apache/calcite-avatica-go/pull/58), can I close this PR by merging another PR, I am not good at using rebase to merge multiple commits.thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong removed a comment on pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong removed a comment on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085397046
> Looks good to me! Please squash your commits and make the commit message the same as the title of the PR.
https://github.com/apache/calcite-avatica-go/pull/58
@F21 Hi, I have some problems with rebase, I submitted a new PR(https://github.com/apache/calcite-avatica-go/pull/58), can I close this PR by merging another PR, I am not good at using rebase to merge multiple commits.thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong commented on pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085402153
>
thanks for your help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] F21 commented on pull request #57: [WIP] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
F21 commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085100317
Hey thanks for working on this. Can you open an issue at https://issues.apache.org/jira/secure/Dashboard.jspa and change the title of the PR to `[CALCITE-XXXX] Title of PR`? See the updated title in https://github.com/apache/calcite-avatica-go/pull/56 as an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] F21 commented on pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
F21 commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085401306
@liguozhong That's no problem. Let's move the conversation to #59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong closed pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong closed pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong commented on pull request #57: [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong commented on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085397046
> Looks good to me! Please squash your commits and make the commit message the same as the title of the PR.
https://github.com/apache/calcite-avatica-go/pull/58
Hi, I have some problems with rebase, I submitted a new PR(https://github.com/apache/calcite-avatica-go/pull/58), can I close this PR by merging another PR, I am not good at using rebase to merge multiple commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica-go] liguozhong edited a comment on pull request #57: [WIP] [CALCITE-5077] ResetSession implements driver.SessionResetter.
Posted by GitBox <gi...@apache.org>.
liguozhong edited a comment on pull request #57:
URL: https://github.com/apache/calcite-avatica-go/pull/57#issuecomment-1085352915
@F21 done.
this pr has fixed "NoSuchConnectionException" issue in my loki cluster. and "NoSuchConnectionException" no longer appears in the log, but I'm not a database expert, @F21 I still need your help to review the code .
without this pr
this this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org