You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/26 13:55:04 UTC
[GitHub] [lucene] rmuir opened a new pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
rmuir opened a new pull request #46:
URL: https://github.com/apache/lucene/pull/46
Remove duplicate compiler configuration. Anything that will fail the linter shows up in as a warning in Eclipse, nothing else.
See the JIRA issue for a longer explanation: https://issues.apache.org/jira/browse/LUCENE-9881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602577677
##########
File path: gradle/ide/eclipse.gradle
##########
@@ -78,6 +78,8 @@ configure(rootProject) {
from rootProject.file("${resources}/dot.settings")
into rootProject.file(".settings")
}
+ def ecjLintConfig = rootProject.file("gradle/validation/ecj-lint/ecj.javadocs.prefs")
+ rootProject.file(".settings/org.eclipse.jdt.core.prefs") << ecjLintConfig.text.replace("=error","=warning")
Review comment:
I'd use an explicit encoding for both reading and writing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #46:
URL: https://github.com/apache/lucene/pull/46#issuecomment-808714530
Hi,
I changed the eclipseJdt task a bit in 3538709269fedfc349f06d8486bee71540329fbb:
- The eclipseJdt task was completely disabled
- Our task is now a simple "Sync" (luceneEclipseJdt). It is hooked into the build by letting the disabled eclipseJdt task depend on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #46:
URL: https://github.com/apache/lucene/pull/46#issuecomment-808589763
I pushed a change to replace the properties directly in the sync task. I also added correct inputs. It is now also possible to change the default error mode to "error" using a project/system property.
As Robert has no computer on vacation, I will merge this PR now (he told me on chat).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on a change in pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
rmuir commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602586288
##########
File path: gradle/ide/eclipse.gradle
##########
@@ -78,6 +78,8 @@ configure(rootProject) {
from rootProject.file("${resources}/dot.settings")
into rootProject.file(".settings")
}
+ def ecjLintConfig = rootProject.file("gradle/validation/ecj-lint/ecj.javadocs.prefs")
+ rootProject.file(".settings/org.eclipse.jdt.core.prefs") << ecjLintConfig.text.replace("=error","=warning")
Review comment:
we can do it that way with java style i/o or via properties class, which i would prefer as well. keep in mind, either way will kill the "grooviness" though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler merged pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
uschindler merged pull request #46:
URL: https://github.com/apache/lucene/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on a change in pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
rmuir commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602314063
##########
File path: gradle/validation/ecj-lint/ecj.javadocs.prefs
##########
@@ -90,26 +96,30 @@ org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore
org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore
org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=error
org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
-org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=ignore
+org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=enabled
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=error
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
-org.eclipse.jdt.core.compiler.problem.terminalDeprecation=ignore
-org.eclipse.jdt.core.compiler.problem.typeParameterHiding=ignore
+org.eclipse.jdt.core.compiler.problem.terminalDeprecation=error
+org.eclipse.jdt.core.compiler.problem.typeParameterHiding=error
org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled
Review comment:
more cases of warnings that were enabled before by default in the IDE, I turned them on because they aren't failing anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on a change in pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602597775
##########
File path: gradle/ide/eclipse.gradle
##########
@@ -78,6 +78,8 @@ configure(rootProject) {
from rootProject.file("${resources}/dot.settings")
into rootProject.file(".settings")
}
+ def ecjLintConfig = rootProject.file("gradle/validation/ecj-lint/ecj.javadocs.prefs")
+ rootProject.file(".settings/org.eclipse.jdt.core.prefs") << ecjLintConfig.text.replace("=error","=warning")
Review comment:
The problem is that '.text" uses the default platform encoding.
So replace this by a method that takes charset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #46:
URL: https://github.com/apache/lucene/pull/46#issuecomment-808537778
> As said before use explicit utf-8 encoding when reading/writing file.
> Explicit properties not needed.
please, just push commits with grooviness. otherwise i can do it java-style when i have a computer again in a few weeks, i think this would make you even more unhappy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on a change in pull request #46: LUCENE-9881: synchronize ECJ linter with Eclipse IDE
Posted by GitBox <gi...@apache.org>.
rmuir commented on a change in pull request #46:
URL: https://github.com/apache/lucene/pull/46#discussion_r602313452
##########
File path: gradle/validation/ecj-lint/ecj.javadocs.prefs
##########
@@ -72,7 +77,7 @@ org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=error
org.eclipse.jdt.core.compiler.problem.nonnullTypeVariableFromLegacyInvocation=error
org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error
-org.eclipse.jdt.core.compiler.problem.nullReference=ignore
+org.eclipse.jdt.core.compiler.problem.nullReference=error
Review comment:
eclipse IDE was warning on this by default, we don't have any issues, so i turned it on as error in linter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org