You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/05 02:54:50 UTC
[GitHub] [dubbo-go-samples] beiwei30 opened a new pull request #57: fix: add run configs, bump up dubbo-go version, revise README
beiwei30 opened a new pull request #57:
URL: https://github.com/apache/dubbo-go-samples/pull/57
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #57: fix: add run configs, bump up dubbo-go version, revise README
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #57:
URL: https://github.com/apache/dubbo-go-samples/pull/57#discussion_r588846466
##########
File path: config-api/go-server/tests/integration/main_test.go
##########
@@ -20,25 +20,26 @@
package integration
import (
- hessian "github.com/apache/dubbo-go-hessian2"
- "github.com/apache/dubbo-go/config"
+ "context"
+ "os"
+ "testing"
+ "time"
+)
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
Review comment:
hessian pkg may be splited to second import block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #57: fix: add run configs, bump up dubbo-go version, revise README
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #57:
URL: https://github.com/apache/dubbo-go-samples/pull/57#discussion_r588846466
##########
File path: config-api/go-server/tests/integration/main_test.go
##########
@@ -20,25 +20,26 @@
package integration
import (
- hessian "github.com/apache/dubbo-go-hessian2"
- "github.com/apache/dubbo-go/config"
+ "context"
+ "os"
+ "testing"
+ "time"
+)
+import (
+ hessian "github.com/apache/dubbo-go-hessian2"
Review comment:
hessian pkg may be splited to second import block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks merged pull request #57: fix: add run configs, bump up dubbo-go version, revise README
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #57:
URL: https://github.com/apache/dubbo-go-samples/pull/57
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org