You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2022/08/16 02:21:27 UTC

[impala] 01/04: Update gerrit-auto-critic for a virtualenv API change

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit b86d49508a0dfcf3105abe6635e8b4ee9d53249e
Author: Laszlo Gaal <la...@cloudera.com>
AuthorDate: Sat Jul 30 00:34:17 2022 +0200

    Update gerrit-auto-critic for a virtualenv API change
    
    Recent versions of virtualenv have changed their main API during a
    massive rewrite. This means that the create_environment entry point is
    no longer available, scripts have to use 'cli_run' instead.
    
    The patch updates the Gerrit auto-critic script for this change.
    
    Change-Id: I6fb85622877b1d2835a1ed8f5a7df56185326949
    Reviewed-on: http://gerrit.cloudera.org:8080/18800
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 bin/jenkins/critique-gerrit-review.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/jenkins/critique-gerrit-review.py b/bin/jenkins/critique-gerrit-review.py
index 1e5fc72e1..466a1ad18 100755
--- a/bin/jenkins/critique-gerrit-review.py
+++ b/bin/jenkins/critique-gerrit-review.py
@@ -76,7 +76,7 @@ EXCLUDE_FILE_PATTERNS = [
 
 def setup_virtualenv():
   """Set up virtualenv with flake8-diff."""
-  virtualenv.create_environment(VENV_PATH)
+  virtualenv.cli_run([VENV_PATH])
   check_call([PIP_PATH, "install",
               "flake8=={0}".format(FLAKE8_VERSION),
               "flake8-diff=={0}".format(FLAKE8_DIFF_VERSION)])