[GitHub] [phoenix] gokceni commented on a change in pull request #657: PHOENIX-5591 Fail indextool if split-merge happens during job run

[GitBox <gi...@apache.org>]

gokceni commented on a change in pull request #657: PHOENIX-5591 Fail indextool if split-merge happens during job run
URL: https://github.com/apache/phoenix/pull/657#discussion_r358960195
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java
 ##########
 @@ -49,8 +50,42 @@
     private static final Logger LOGGER =
             LoggerFactory.getLogger(PhoenixIndexImportDirectReducer.class);
 
+    private static final String SPLIT_MERGE_ERROR_STR_FMT =
+            "Data table split/merge happened during Index rebuild. Old region cnt=%d, New region cnt = %d";
+
+    private static Integer regionCountForTesting = null;
+
+    public static void setRegionCountForTesting(Integer regionCount) {
+        regionCountForTesting = regionCount;
+    }
+
     @Override
     protected void cleanup(Context context) throws IOException, InterruptedException{
+        String strNumOfRegions = PhoenixConfigurationUtil.getNumOfRegions(context.getConfiguration());
 
 Review comment:
   It is not mappers. It is table region count. Not sure I understand what you are suggesting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services