You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2025/11/06 04:24:50 UTC
[PR] docs(mcp): add comprehensive architecture, security, and production deployment documentation [superset]
aminghadersohi opened a new pull request, #36017:
URL: https://github.com/apache/superset/pull/36017
### SUMMARY
This PR adds comprehensive documentation for the MCP service in response to review feedback on PR #35163. The documentation addresses all questions raised about the Flask singleton pattern, multitenant architecture, security model, and production deployment path.
**Addresses review feedback from PR #35163:**
- Flask singleton pattern explanation and justification
- Multitenant architecture with tenant isolation strategies
- Authentication and authorization model (dev and production)
- Security considerations and best practices
- Production deployment guide with multiple deployment options
- Migration path from development to production
**Documentation Added:**
1. **ARCHITECTURE.md** (669 lines)
- Flask singleton pattern explanation and justification
- Why module-level singleton is appropriate for MCP service
- Thread safety implementation details
- Multitenant architecture (shared process with tenant isolation)
- Tenant isolation mechanisms (database, application, JWT)
- Process models (single, multi-process, containerized)
- Database connection management
- Deployment considerations
2. **SECURITY.md** (744 lines)
- Authentication (dev: MCP_DEV_USERNAME, prod: JWT)
- JWT provider examples (Auth0, Okta, AWS Cognito, Keycloak)
- Authorization (RBAC, RLS, tool permissions)
- Session and CSRF handling
- Audit logging strategies
- Compliance considerations (GDPR, SOC2, HIPAA)
- Security checklist
- Incident response procedures
3. **PRODUCTION.md** (1,257 lines)
- Current status (what's ready vs dev-only)
- Required for production checklist
- Deployment guides (systemd, supervisord, Docker, Kubernetes)
- Reverse proxy configuration (Nginx, Apache)
- Monitoring and alerting (Prometheus, Grafana, CloudWatch)
- Migration path from dev to prod
- Troubleshooting common issues
- Performance tuning recommendations
4. **UPDATING.md**
- Added comprehensive MCP service documentation in main project changelog
- Configuration options (dev vs prod)
- Running instructions
- Security requirements
- Links to all new documentation files
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Documentation only
### TESTING INSTRUCTIONS
Review the documentation files:
- `superset/mcp_service/ARCHITECTURE.md`
- `superset/mcp_service/SECURITY.md`
- `superset/mcp_service/PRODUCTION.md`
- `UPDATING.md` (MCP service section in "Next" release)
All documentation:
- Uses concrete code examples from the actual implementation
- References existing Superset patterns (RBAC, RLS, DAOs)
- Provides deployment-ready configurations
- Includes troubleshooting guidance
- Links to related files and documentation
### ADDITIONAL INFORMATION
- [ ] Has associated issue: Related to PR #35163 review feedback
- [ ] Required feature flags: None
- [ ] Changes UI: No
- [ ] Includes DB Migration: No
- [ ] Introduces new feature or API: No - Documentation only
- [ ] Removes existing feature or API: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(mcp): add comprehensive architecture, security, and production deployment documentation [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36017:
URL: https://github.com/apache/superset/pull/36017#issuecomment-3494995588
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/36017?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.48%. Comparing base ([`1f960d5`](https://app.codecov.io/gh/apache/superset/commit/1f960d5761f31d3cac2697a988b64ba08b2d980b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3d7d57d`](https://app.codecov.io/gh/apache/superset/commit/3d7d57d8ac1d97a4e2f0ae25e1188f60f9764874?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36017 +/- ##
===========================================
+ Coverage 0 48.48% +48.48%
===========================================
Files 0 622 +622
Lines 0 45718 +45718
Branches 0 4975 +4975
===========================================
+ Hits 0 22165 +22165
- Misses 0 22928 +22928
- Partials 0 625 +625
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/36017/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/36017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.20% <ø> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/36017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.76% <ø> (?)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/36017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.47% <ø> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/36017/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/36017?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(mcp): add comprehensive architecture, security, and production deployment documentation [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36017:
URL: https://github.com/apache/superset/pull/36017#issuecomment-3494941463
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs(mcp): add comprehensive architecture, security, and production deployment documentation [superset]
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez merged PR #36017:
URL: https://github.com/apache/superset/pull/36017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org