You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/21 06:57:26 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1937: Enable Spring dependent extensions to work with Quarkus Spring

jamesnetherton opened a new pull request #1937:
URL: https://github.com/apache/camel-quarkus/pull/1937


   Works around the issue I identified in https://github.com/apache/camel-quarkus/issues/1759.
   
   I did some analysis of Spring code paths that get executed in the Camel unit tests and came up with a list of package includes & excludes for shading. 
   
   The itests pass ok, but I can't check for every possible code path. Is it better / safer to shade all packages, instead of selectively including them? Obviously there's a chance that some required stuff may have been left out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1937: Enable Spring dependent extensions to work with Quarkus Spring

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1937:
URL: https://github.com/apache/camel-quarkus/pull/1937#issuecomment-713486994


   > Do we have a piece of docs somewhere explaining why we do this? If not, a README or `<description>` in the pom would come in handy.
   
   Latest commit adds a README to the spring support extension.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton merged pull request #1937: Enable Spring dependent extensions to work with Quarkus Spring

Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1937:
URL: https://github.com/apache/camel-quarkus/pull/1937


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org