[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

[rhtyd <gi...@git.apache.org>]

Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1647#discussion_r76004158
  
    --- Diff: debian/rules ---
    @@ -5,8 +5,17 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 1)
     SYSCONFDIR = "/etc"
     DESTDIR = "debian/tmp"
     
    +ifeq ($(shell lsb_release -sr), 14.04)
    +        SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" -Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
    +else
    +        SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" -Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
    --- End diff --
    
    @wido should this be written like:   `-Vinit:Depends="systemd"`. Would it be possible to support both systemd/initd environments by adding the dependency like `systemd | jsvc` -- this way it would try to install both? On (systemd based) Ubuntu 16.04 systemd will be already installed, we can install jsvc for all systems -- so why not just depend on jsvc alone? On 14.04, the pkgs can continue to use jsvc/initd script and on 16.04 it can uses systemd, both using the same packages.
    
    I want us to avoid hosting two separate deb repositories (one for non-systemd based and one for systemd based) if possible. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---