[GitHub] [pulsar-helm-chart] NiklasWagner commented on a change in pull request #41: Fix wrong variable reference in Grafana & Pulsar Manager port

[GitBox <gi...@apache.org>]

NiklasWagner commented on a change in pull request #41:
URL: https://github.com/apache/pulsar-helm-chart/pull/41#discussion_r456465598



##########
File path: charts/pulsar/templates/pulsar-manager-deployment.yaml
##########
@@ -58,7 +58,7 @@ spec:
 {{ toYaml .Values.pulsar_manager.resources | indent 12 }}
         {{- end }}
           ports:
-          - containerPort: {{ .Values.pulsar_manager.port }}
+          - containerPort: {{ .Values.pulsar_manager.service.port }}

Review comment:
       Yep you're correct! Reading this here: https://kubernetes.io/docs/concepts/services-networking/service/#defining-a-service
   ```yaml
   apiVersion: v1
   kind: Service
   metadata:
     name: my-service
   spec:
     selector:
       app: MyApp
     ports:
       - protocol: TCP
         port: 80
         targetPort: 9376
   ```
   
   >This specification creates a new Service object named “my-service”, which targets TCP port 9376 on any Pod with the app=MyApp label.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org