You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/04 11:57:39 UTC
[jira] [Commented] (FLINK-3186) Deprecate
DataSink.sortLocalOutput() methods
[ https://issues.apache.org/jira/browse/FLINK-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080986#comment-15080986 ]
ASF GitHub Bot commented on FLINK-3186:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1478#issuecomment-168644956
Thanks for addressing the issue, merging this...
> Deprecate DataSink.sortLocalOutput() methods
> --------------------------------------------
>
> Key: FLINK-3186
> URL: https://issues.apache.org/jira/browse/FLINK-3186
> Project: Flink
> Issue Type: Task
> Components: DataSet API
> Affects Versions: 1.0.0
> Reporter: Fabian Hueske
> Assignee: Suneel Marthi
> Fix For: 1.0.0
>
>
> The DataSet API {{DataSink}} offers a method {{sortLocalOutput()}} to sort the output before it is handed to the {{OutputFormat}}.
> I propose to deprecate (and eventually remove) this method, because the same functionality can be achieved by using {{DataSet.sortPartition()}}. {{sortPartition()}} is more generic and has no drawbacks compared to {{sortLocalOutput()}}. Removing {{sortLocalOutput()}} would clean up the API and remove unnecessary code paths.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)