You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by Brock Noland <br...@cloudera.com> on 2011/10/02 00:10:07 UTC
Re: MRUNIT-15 - runTests() should throw meaningful error messages
Hello,
Any chance someone could look at the patch?
Cheers,
Brock
On Mon, Sep 26, 2011 at 7:45 PM, Brock Noland <br...@cloudera.com> wrote:
> Hello,
>
> I attached a patch to MRUNIT-15
> (https://issues.apache.org/jira/browse/MRUNIT-15) to give more
> meaningful error messages as part of the exception. I also removed a
> few lines with "Setting success to false.." when it was actually not
> setting any flags. There are some compiler errors near the lines I
> changed, but I left those to be fixed as part of MRUNIT-18.
>
> All the tests pass, for me. Let me know what you think about the patch.
>
> Cheers,
> Brock
>
Re: MRUNIT-15 - runTests() should throw meaningful error messages
Posted by "Mattmann, Chris A (388J)" <ch...@jpl.nasa.gov>.
Hey Brock,
I committed your patch, should be good to go!
Cheers,
Chris
On Oct 1, 2011, at 3:10 PM, Brock Noland wrote:
> Hello,
>
> Any chance someone could look at the patch?
>
> Cheers,
> Brock
>
> On Mon, Sep 26, 2011 at 7:45 PM, Brock Noland <br...@cloudera.com> wrote:
>
>> Hello,
>>
>> I attached a patch to MRUNIT-15
>> (https://issues.apache.org/jira/browse/MRUNIT-15) to give more
>> meaningful error messages as part of the exception. I also removed a
>> few lines with "Setting success to false.." when it was actually not
>> setting any flags. There are some compiler errors near the lines I
>> changed, but I left those to be fixed as part of MRUNIT-18.
>>
>> All the tests pass, for me. Let me know what you think about the patch.
>>
>> Cheers,
>> Brock
>>
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW: http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++