You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/14 22:23:08 UTC
[GitHub] [kafka] shayelkin opened a new pull request #10539: Minor: Move trogdor out of tools and into its own project
shayelkin opened a new pull request #10539:
URL: https://github.com/apache/kafka/pull/10539
This moves Trogdor out of tools/ and into its own project. This would
allow Trogdor to be linked against other libraries (for example, you
could build a worker that links against k8s to trigger issues through
it), without bringing those dependencies into Kafka itself through the
tools project.
It still keeps Trogdor in the CLASSPATH created in kafka-run-class.sh.
Tested by building, and running Trogdor in the resulting build.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #10539: Minor: Move trogdor out of tools and into its own project
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #10539:
URL: https://github.com/apache/kafka/pull/10539#issuecomment-819890717
Looks good overall! Can you remove the jersey dependency from tools? Now that trogdor is in a separate subproject it should not be needed any more. Same with "activation" and "jetty".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #10539: Minor: Move trogdor out of tools and into its own project
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #10539:
URL: https://github.com/apache/kafka/pull/10539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] stanislavkozlovski edited a comment on pull request #10539: Minor: Move trogdor out of tools and into its own project
Posted by GitBox <gi...@apache.org>.
stanislavkozlovski edited a comment on pull request #10539:
URL: https://github.com/apache/kafka/pull/10539#issuecomment-820230424
I echo Colin's comments. Otherwise looks great. I just built the project (with 4b6c476) and ran through the TROGDOR readme (https://github.com/apache/kafka/blob/trunk/TROGDOR.md) - it works great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] stanislavkozlovski commented on pull request #10539: Minor: Move trogdor out of tools and into its own project
Posted by GitBox <gi...@apache.org>.
stanislavkozlovski commented on pull request #10539:
URL: https://github.com/apache/kafka/pull/10539#issuecomment-820230424
I echo Colin's comments. Otherwise looks great. I just ran through the TROGDOR readme (https://github.com/apache/kafka/blob/trunk/TROGDOR.md) and it works great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org