You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/02 22:46:10 UTC
[GitHub] [geode] rhoughton-pivot opened a new pull request #6256: GEODE-9080: Add new stackdriver agent to Windows compute images
rhoughton-pivot opened a new pull request #6256:
URL: https://github.com/apache/geode/pull/6256
As a precursor to right-sizing our Windows instances, we need to know
their resource use. The jobs are not long-lived enough for the GCP
Recommendation system to tell us, so we need our own monitoring. Thus,
add stackdriver, so that we can see the data for memory and details
about CPU use.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot merged pull request #6256: GEODE-9080: Add new stackdriver agent to Windows compute images
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot merged pull request #6256:
URL: https://github.com/apache/geode/pull/6256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6256: GEODE-9080: Add new stackdriver agent to Windows compute images
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #6256:
URL: https://github.com/apache/geode/pull/6256#discussion_r606486642
##########
File path: ci/pipelines/meta/deploy_meta.sh
##########
@@ -130,7 +130,6 @@ YML
echo "Target ${FLY_TARGET} already exists."
fi
- FLY=${FLY:-$(which fly)}
Review comment:
Because lines 119-120 make it never take effect, and rectifying that logic is beyond the scope of my change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #6256: GEODE-9080: Add new stackdriver agent to Windows compute images
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #6256:
URL: https://github.com/apache/geode/pull/6256#issuecomment-812744772
@pivotal-jbarrett , I think this should be added to the images for geode-native, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #6256: GEODE-9080: Add new stackdriver agent to Windows compute images
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #6256:
URL: https://github.com/apache/geode/pull/6256#discussion_r606485345
##########
File path: ci/pipelines/meta/deploy_meta.sh
##########
@@ -130,7 +130,6 @@ YML
echo "Target ${FLY_TARGET} already exists."
fi
- FLY=${FLY:-$(which fly)}
Review comment:
since deploy_meta.sh is sometimes run by humans, why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org