[GitHub] [arrow] pitrou commented on a change in pull request #10088: ARROW-10675 [C++][Python] Support AWS S3 Web identity credentials

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #10088:
URL: https://github.com/apache/arrow/pull/10088#discussion_r615705707



##########
File path: cpp/src/arrow/filesystem/s3fs.h
##########
@@ -91,6 +94,12 @@ struct ARROW_EXPORT S3Options {
   /// Whether OutputStream writes will be issued in the background, without blocking.
   bool background_writes = true;
 
+  /// True when using SimpleAWSCredentialsProvider, else false.
+  bool creds_provided = false;
+
+  /// True when using web identity token to assume role
+  bool use_web_identity = false;

Review comment:
       Aren't `anonymous`, `creds_provided` and `use_web_identity` all exclusive? If so, how about replacing them with an enum, e.g.:
   ```c++
   struct S3Options {
     enum CredentialsKind {
       /// Anonymous access (no credentials used)
       Anonymous,
       /// Use default AWS credentials, configured through environment variables
       Default,
       /// Use explicitly-provided username and password
       Explicit,
       /// Use web identity token to assume role, configured through environment variables
       WebIdentity
     };
   
     CredentialsKind credentials_kind = Default;
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org