You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/07 21:16:50 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
MaxGekk opened a new pull request #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494
### What changes were proposed in this pull request?
In the PR, I propose to rewrite the `millisToDays` and `daysToMillis` of `DateTimeUtils` using Java 8 time API.
I removed `getOffsetFromLocalMillis` from `DateTimeUtils` because it is a private methods, and is not used anymore in Spark SQL.
### Why are the changes needed?
New implementation is based on Proleptic Gregorian calendar which has been already used by other date-time functions. This changes make `millisToDays` and `daysToMillis` consistent to rest Spark SQL API related to date & time operations.
### Does this PR introduce any user-facing change?
Yes, this might effect behavior for old dates before 1582 year.
### How was this patch tested?
By existing test suites `DateTimeUtilsSuite`, `DateFunctionsSuite`, DateExpressionsSuite`, `SQLQuerySuite` and `HiveResultSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584144132
**[Test build #118152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118152/testReport)** for PR 27494 at commit [`cb37fe3`](https://github.com/apache/spark/commit/cb37fe3e94ec62f86c884083737ffeb2bb803baa).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376795016
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/date.sql.out
##########
@@ -864,15 +864,15 @@ SELECT DATE_TRUNC('DECADE', DATE '0004-12-25')
-- !query schema
struct<date_trunc(DECADE, CAST(DATE '0004-12-25' AS TIMESTAMP)):timestamp>
-- !query output
-0000-01-01 00:07:02
+0000-01-01 00:00:00
-- !query
SELECT DATE_TRUNC('DECADE', TO_DATE('0002-12-31 BC', 'yyyy-MM-dd G'))
-- !query schema
struct<date_trunc(DECADE, CAST(to_date('0002-12-31 BC', 'yyyy-MM-dd G') AS TIMESTAMP)):timestamp>
-- !query output
--0010-01-01 00:07:02
+-0010-01-01 00:00:00
Review comment:
I was going to ask if there are any behavior changes. This is one, but it looks like it was wrong before?
Are there any others that we know of? Given recent discussions I'm extra cautious about introducing behavior changes I suppose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583776064
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584153775
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583772792
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584153788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22927/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583751622
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22837/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583751621
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583633404
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584057951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22914/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583714594
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22827/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583633404
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376985660
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -337,6 +337,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
case _ =>
}
+ localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)
Review comment:
HiveResult is used in `hive-thriftserver` too. If I set `spark.sql.datetime.java8API.enabled` to `true` in `HiveResult.hiveResultString`, this might effect on the Thrift server. Though I can correct expected results in the tests, but Thrift server may require broader changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583776447
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376988480
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -337,6 +337,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
case _ =>
}
+ localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)
Review comment:
Can we open a new PR to do it? I believe we need to do this after switching to Proleptic Gregorian calendar. We should avoid using different calendars inconsistently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584144452
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585189581
**[Test build #118300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118300/testReport)** for PR 27494 at commit [`e5d463f`](https://github.com/apache/spark/commit/e5d463f67d68efcff046851479b4789d1e4f50a0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584153170
**[Test build #118166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118166/testReport)** for PR 27494 at commit [`cb37fe3`](https://github.com/apache/spark/commit/cb37fe3e94ec62f86c884083737ffeb2bb803baa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583794112
**[Test build #118076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118076/testReport)** for PR 27494 at commit [`6a64946`](https://github.com/apache/spark/commit/6a64946661de797b35629c4f99242e8052c0fda6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583751453
**[Test build #118072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118072/testReport)** for PR 27494 at commit [`6a64946`](https://github.com/apache/spark/commit/6a64946661de797b35629c4f99242e8052c0fda6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584311832
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118166/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585189581
**[Test build #118300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118300/testReport)** for PR 27494 at commit [`e5d463f`](https://github.com/apache/spark/commit/e5d463f67d68efcff046851479b4789d1e4f50a0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584153788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22927/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583672974
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118046/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584057940
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583794225
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584311821
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583617336
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585179825
OK let's get this in 3.0 to stick with Proleptic Gregorian calendar. Can we fix the conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376978518
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -337,6 +337,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
case _ =>
}
+ localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)
Review comment:
I think this is a bug in `HiveResult`, not just this test suite.
When we produce string result, we must stick with the Proleptic Gregorian calendar and call `LocalDate/Instant.toString`. I think we should update `HiveResult.hiveResultString` and enable java 8 datetime API before calling `collect`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584153170
**[Test build #118166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118166/testReport)** for PR 27494 at commit [`cb37fe3`](https://github.com/apache/spark/commit/cb37fe3e94ec62f86c884083737ffeb2bb803baa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583617346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22810/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r377030690
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/date.sql.out
##########
@@ -864,15 +864,15 @@ SELECT DATE_TRUNC('DECADE', DATE '0004-12-25')
-- !query schema
struct<date_trunc(DECADE, CAST(DATE '0004-12-25' AS TIMESTAMP)):timestamp>
-- !query output
-0000-01-01 00:07:02
+0000-01-01 00:00:00
-- !query
SELECT DATE_TRUNC('DECADE', TO_DATE('0002-12-31 BC', 'yyyy-MM-dd G'))
-- !query schema
struct<date_trunc(DECADE, CAST(to_date('0002-12-31 BC', 'yyyy-MM-dd G') AS TIMESTAMP)):timestamp>
-- !query output
--0010-01-01 00:07:02
+-0010-01-01 00:00:00
Review comment:
Yes, the change in this particular line is caused by `localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)`. But I had to set the settings to fix another test failures like in https://github.com/apache/spark/pull/27494#issuecomment-583675754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583617346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22810/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583675884
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118045/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583675880
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r377024174
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -337,6 +337,7 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
case _ =>
}
+ localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)
Review comment:
Sure, I will do that after this PR will be merged because I will need the changes, most likely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585190160
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583714593
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584144461
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118152/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r377033471
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/date.sql.out
##########
@@ -864,15 +864,15 @@ SELECT DATE_TRUNC('DECADE', DATE '0004-12-25')
-- !query schema
struct<date_trunc(DECADE, CAST(DATE '0004-12-25' AS TIMESTAMP)):timestamp>
-- !query output
-0000-01-01 00:07:02
+0000-01-01 00:00:00
-- !query
SELECT DATE_TRUNC('DECADE', TO_DATE('0002-12-31 BC', 'yyyy-MM-dd G'))
-- !query schema
struct<date_trunc(DECADE, CAST(to_date('0002-12-31 BC', 'yyyy-MM-dd G') AS TIMESTAMP)):timestamp>
-- !query output
--0010-01-01 00:07:02
+-0010-01-01 00:00:00
Review comment:
Do you think it's helpful to do https://github.com/apache/spark/pull/27494#discussion_r376988480 first and then we can know what gets changed exactly by this fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583728345
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118061/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585352440
thanks, merging to master/3.0!
@MaxGekk let's fix https://github.com/apache/spark/pull/27494#discussion_r376978518 in a followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583794228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118076/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583672829
**[Test build #118046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118046/testReport)** for PR 27494 at commit [`cc4c07d`](https://github.com/apache/spark/commit/cc4c07dc6dfa0e729ef3123069616bce04e7e9ac).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r377027688
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/date.sql.out
##########
@@ -864,15 +864,15 @@ SELECT DATE_TRUNC('DECADE', DATE '0004-12-25')
-- !query schema
struct<date_trunc(DECADE, CAST(DATE '0004-12-25' AS TIMESTAMP)):timestamp>
-- !query output
-0000-01-01 00:07:02
+0000-01-01 00:00:00
-- !query
SELECT DATE_TRUNC('DECADE', TO_DATE('0002-12-31 BC', 'yyyy-MM-dd G'))
-- !query schema
struct<date_trunc(DECADE, CAST(to_date('0002-12-31 BC', 'yyyy-MM-dd G') AS TIMESTAMP)):timestamp>
-- !query output
--0010-01-01 00:07:02
+-0010-01-01 00:00:00
Review comment:
This is caused by https://github.com/apache/spark/pull/27494/files#diff-432455394ca50800d5de508861984ca5R340 , not the fix itself, right?
Do we have any known behavior changes caused by this fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583728343
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585161988
> are there any known behavior changes (bug fixes) caused by this patch?
1. **_millisToDays(millisUtc: Long)_** is called by fromJavaDate() which is used in many places for converting `java.sql.Date` to the number of days since epoch. For example, HiveResult, JDBC, ORC deserializer, Parquet Filters, obviously literals, Hive HadoopTableReader
2. **_millisToDays(millisUtc: Long, timeZone: TimeZone)_** is called from `CurrentBatchTimestamp` (I think we can avoid that), `monthsBetween`, truncTimestamp (we can avoid this by https://github.com/apache/spark/pull/25329)
3. **_daysToMillis(days: SQLDate)_** is called from toJavaDate() which is opposite to fromJavaDate() and is used in the same places.
4. **_daysToMillis(days: SQLDate, timeZone: TimeZone)_** is called from monthsBetween, timestamp trunctions (we can avoid that).
**NOTE:** This affects only old dates/timestamps before 1582 year.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585190165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23058/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583776447
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583728343
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583772797
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118072/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585339733
**[Test build #118300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118300/testReport)** for PR 27494 at commit [`e5d463f`](https://github.com/apache/spark/commit/e5d463f67d68efcff046851479b4789d1e4f50a0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27494: [WIP]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376733305
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -86,9 +86,13 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
}
test("SPARK-6785: java date conversion before and after epoch") {
+ def format(d: Date): String = {
+ TimestampFormatter("uuuu-MM-dd", defaultTimeZone().toZoneId)
+ .format(d.getTime * MICROS_PER_MILLIS)
+ }
def checkFromToJavaDate(d1: Date): Unit = {
val d2 = toJavaDate(fromJavaDate(d1))
- assert(d2.toString === d1.toString)
+ assert(format(d2) === format(d1))
Review comment:
I had to use the formatter to avoid calendar problems - `Date.toString` formats slightly differently than `DateTimeFormatter`, I guess because of different year lengths in calendars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583672970
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583633420
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22811/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583714593
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583714594
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22827/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583794228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118076/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584150360
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27494: [WIP]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376614669
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
##########
@@ -494,7 +494,7 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
// Valid range of DateType is [0001-01-01, 9999-12-31]
val maxMonthInterval = 10000 * 12
checkEvaluation(
- AddMonths(Literal(Date.valueOf("0001-01-01")), Literal(maxMonthInterval)), 2933261)
+ AddMonths(Literal(LocalDate.parse("0001-01-01")), Literal(maxMonthInterval)), 2933263)
Review comment:
I had to replace `Date.valueOf` by `LocalDate.parse` due to migration on another calendar from Julian to Gregorian. The expected number of days is easy to get:
```scala
val a = LocalDate.of(10001, 1, 1).toEpochDay
println(a)
2933263
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583616745
**[Test build #118045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118045/testReport)** for PR 27494 at commit [`9a2b7be`](https://github.com/apache/spark/commit/9a2b7becc37c647f63d85c519d62c729b5498939).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583776346
**[Test build #118076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118076/testReport)** for PR 27494 at commit [`6a64946`](https://github.com/apache/spark/commit/6a64946661de797b35629c4f99242e8052c0fda6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583776449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22841/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583675880
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376796005
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/date.sql.out
##########
@@ -864,15 +864,15 @@ SELECT DATE_TRUNC('DECADE', DATE '0004-12-25')
-- !query schema
struct<date_trunc(DECADE, CAST(DATE '0004-12-25' AS TIMESTAMP)):timestamp>
-- !query output
-0000-01-01 00:07:02
+0000-01-01 00:00:00
-- !query
SELECT DATE_TRUNC('DECADE', TO_DATE('0002-12-31 BC', 'yyyy-MM-dd G'))
-- !query schema
struct<date_trunc(DECADE, CAST(to_date('0002-12-31 BC', 'yyyy-MM-dd G') AS TIMESTAMP)):timestamp>
-- !query output
--0010-01-01 00:07:02
+-0010-01-01 00:00:00
Review comment:
This had been already described in the SQL migration guide. The numbers are different because internally we use Proleptic Gregorian calendar in `date_trunc` but when we collect data to the driver, we convert internal timestamps to `java.sql.Timestamp`. Actually, we switch to Julian calendar for old dates here.
By settings `localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)` in `SQLQueryTestSuite.scala`, I just keep the same calendar in all transformations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584144461
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118152/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585340731
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583714504
**[Test build #118061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118061/testReport)** for PR 27494 at commit [`1890589`](https://github.com/apache/spark/commit/1890589021d6b925ba9cce9d7b7053010e15a628).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583772797
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118072/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584060407
**[Test build #118152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118152/testReport)** for PR 27494 at commit [`cb37fe3`](https://github.com/apache/spark/commit/cb37fe3e94ec62f86c884083737ffeb2bb803baa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584310923
**[Test build #118166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118166/testReport)** for PR 27494 at commit [`cb37fe3`](https://github.com/apache/spark/commit/cb37fe3e94ec62f86c884083737ffeb2bb803baa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585340731
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585340736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118300/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583794225
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583672974
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118046/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584592829
are there any known behavior changes (bug fixes) caused by this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376974086
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
##########
@@ -494,7 +494,7 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
// Valid range of DateType is [0001-01-01, 9999-12-31]
val maxMonthInterval = 10000 * 12
checkEvaluation(
- AddMonths(Literal(Date.valueOf("0001-01-01")), Literal(maxMonthInterval)), 2933261)
+ AddMonths(Literal(LocalDate.parse("0001-01-01")), Literal(maxMonthInterval)), 2933263)
Review comment:
can we place the harcoded `2933263` with `LocalDate.of(10001, 1, 1).toEpochDay`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583751621
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585340736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118300/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583616745
**[Test build #118045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118045/testReport)** for PR 27494 at commit [`9a2b7be`](https://github.com/apache/spark/commit/9a2b7becc37c647f63d85c519d62c729b5498939).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584057951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22914/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584057940
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584311821
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584144452
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585190165
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23058/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583772792
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583675754
**[Test build #118045 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118045/testReport)** for PR 27494 at commit [`9a2b7be`](https://github.com/apache/spark/commit/9a2b7becc37c647f63d85c519d62c729b5498939).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583633420
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22811/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583632905
**[Test build #118046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118046/testReport)** for PR 27494 at commit [`cc4c07d`](https://github.com/apache/spark/commit/cc4c07dc6dfa0e729ef3123069616bce04e7e9ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583776346
**[Test build #118076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118076/testReport)** for PR 27494 at commit [`6a64946`](https://github.com/apache/spark/commit/6a64946661de797b35629c4f99242e8052c0fda6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376974086
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
##########
@@ -494,7 +494,7 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
// Valid range of DateType is [0001-01-01, 9999-12-31]
val maxMonthInterval = 10000 * 12
checkEvaluation(
- AddMonths(Literal(Date.valueOf("0001-01-01")), Literal(maxMonthInterval)), 2933261)
+ AddMonths(Literal(LocalDate.parse("0001-01-01")), Literal(maxMonthInterval)), 2933263)
Review comment:
can we place the hardcoded `2933263` with `LocalDate.of(10001, 1, 1).toEpochDay`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584311832
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118166/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583632905
**[Test build #118046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118046/testReport)** for PR 27494 at commit [`cc4c07d`](https://github.com/apache/spark/commit/cc4c07dc6dfa0e729ef3123069616bce04e7e9ac).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583751453
**[Test build #118072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118072/testReport)** for PR 27494 at commit [`6a64946`](https://github.com/apache/spark/commit/6a64946661de797b35629c4f99242e8052c0fda6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583728345
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118061/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583617336
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583751622
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22837/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-585190160
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583675884
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118045/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583728293
**[Test build #118061 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118061/testReport)** for PR 27494 at commit [`1890589`](https://github.com/apache/spark/commit/1890589021d6b925ba9cce9d7b7053010e15a628).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27494: [SPARK-30760][SQL]
Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584153775
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583714504
**[Test build #118061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118061/testReport)** for PR 27494 at commit [`1890589`](https://github.com/apache/spark/commit/1890589021d6b925ba9cce9d7b7053010e15a628).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583772648
**[Test build #118072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118072/testReport)** for PR 27494 at commit [`6a64946`](https://github.com/apache/spark/commit/6a64946661de797b35629c4f99242e8052c0fda6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494: [WIP] Port
`millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [WIP] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583672970
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-583776449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22841/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27494:
[SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27494: [SPARK-30760][SQL] Port `millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#issuecomment-584060407
**[Test build #118152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118152/testReport)** for PR 27494 at commit [`cb37fe3`](https://github.com/apache/spark/commit/cb37fe3e94ec62f86c884083737ffeb2bb803baa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org